💬 Sjors commented on issue "support BIP39 mnemonic in descriptors":
(https://github.com/bitcoin/bitcoin/issues/19151#issuecomment-1514419208)
Briefly looked at this again. Importing with private key functionality seems doable (not just watch-only).

1. We need to store the extended private key of the root node (easier after #26728): internally our wallet does this by storing the full extended public key and a regular `CKey` for the private key.
2. We don't have to store the mnemonic. But if we wanted to, we have to make sure it gets encrypted along with other private key material.
3. Both seed and passphrase would (initially) be c
...

💬 willcl-ark commented on pull request "init: Add option for rpccookie permissions":
(https://github.com/bitcoin/bitcoin/pull/26088#issuecomment-1514450115)
@aureleoules @fanquake

I think this could be re-opened to solve https://github.com/bitcoin/bitcoin/issues/25270 if @aureleoules is happy to pick it up again, otherwise I'd be happy to?

Whilst #17127 has given us more sane and secure defaults, permitting group members to access the cookie without resorting to `-startupnotify` wortkarounds or similar seems reasonable to me.

One the one hand any processes with access to the cookie could just as well be running as the same user as `bitcoin
...

💬 willcl-ark commented on issue "large wallet: Bitcoind freezes":
(https://github.com/bitcoin/bitcoin/issues/15148#issuecomment-1514458533)
@RomanBelkov is this issue still present on the current release of Bitcoin Core (v24.0.1), as there have been many wallet improvements in the years since this issue was opened?

💬 RomanBelkov commented on issue "large wallet: Bitcoind freezes":
(https://github.com/bitcoin/bitcoin/issues/15148#issuecomment-1514465381)
@willcl-ark unfortunately I'm unable to comment on issue as I'm not working with Bitcoin Core anymore for quite a while. I guess the issue can be closed as there was no development/reports from other people for 3 years :)

✅ RomanBelkov closed an issue: "large wallet: Bitcoind freezes"
(https://github.com/bitcoin/bitcoin/issues/15148)

💬 TheCharlatan commented on pull request "refactor: Extract common/args from util/system":
(https://github.com/bitcoin/bitcoin/pull/27419#issuecomment-1514467370)
Thank you for the reviews, decided to address the left over nits here:

Updated ec51c252de42e11906f114ac05e476fd88ca2176 -> be55f545d53d44fdcf2d8ae802e9eae551d120c6 ([splitSystemArgs_3](https://github.com/TheCharlatan/bitcoin/commits/splitSystemArgs_3) -> [splitSystemArgs_4](https://github.com/TheCharlatan/bitcoin/commits/splitSystemArgs_4), [compare](https://github.com/TheCharlatan/bitcoin/compare/splitSystemArgs_3..splitSystemArgs_4)):
* Addressed @ryanofsky's [comment](https://github.com/b
...

⚠️ batriskaweb3 opened an issue: "Compiling a bitcoin core version that accepts transactions over 100vkb"
(https://github.com/bitcoin/bitcoin/issues/27490)
### Please describe the feature you'd like to see added.

i couldnt manage to find any label that fits this,
when people try to inscribe ordinals that are bigger than 400kb they can not be able to because bitcoin core doesnt allow transactions over 100kvb
even though that would require the person to be a miner or pay miners for it but it still would be nice to guide us on how to compile such bitcoin core version

### Is your feature related to a problem, if so please describe it.

_No response
...

📝 TheCharlatan opened a pull request: "Kernel chain type"
(https://github.com/bitcoin/bitcoin/pull/27491)
This pull request is part of the `libbitcoinkernel` project https://github.com/bitcoin/bitcoin/issues/24303 https://github.com/bitcoin/bitcoin/projects/18 and more specifically its "Step 2: Decouple most non-consensus code from libbitcoinkernel". It is also a follow up to #26177.

It replaces pull request https://github.com/bitcoin/bitcoin/pull/27294, which just moved the constants to a new file, but did not re-declare them as enums.

The code move of the chain name constants out of the `cha
...

💬 TheCharlatan commented on pull request "refactor: Move chain names to the util library":
(https://github.com/bitcoin/bitcoin/pull/27294#issuecomment-1514490390)
Re https://github.com/bitcoin/bitcoin/pull/27294#pullrequestreview-1376476610
> However I think as long as every usage of the constants is changing anyway, it would be better to turn this into to enum and not introduce an odd namespace with string symbols. Suggestion would be to add a new `src/util/chain_types.h` file with:

I initially wanted to implement the constants as an enum, but then saw in the git history, that they were originally an enum and converted to string constants in https://
...

✅ TheCharlatan closed a pull request: "refactor: Move chain names to the util library"
(https://github.com/bitcoin/bitcoin/pull/27294)

💬 fanquake commented on issue "Compiling a bitcoin core version that accepts transactions over 100vkb":
(https://github.com/bitcoin/bitcoin/issues/27490#issuecomment-1514490496)
> a guide on what code changes should be done to compile such version

💬 fanquake commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#issuecomment-1514492185)
```bash
7ea09dd60 scripted-diff: Remove unused chainparamsbase includes
d99bd93e0 Add missing definitions in prep for scripted diff
5589a4b0d refactor: Replace string chain name constants with ChainTypes
bd6493bf3 refactor: Create chaintype files

Error: script block marker but no scripted-diff in title of commit 7ea09dd60cd43e943f9910c950b05dda89ef3725
Failed
```

💬 TheCharlatan commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#issuecomment-1514503368)
Re https://github.com/bitcoin/bitcoin/pull/27491#issuecomment-1514492185

> 7ea09dd60 scripted-diff: Remove unused chainparamsbase includes

Seems like the trailing whitespace in the commit mesasge header was tripping it up?

💬 fanquake commented on pull request "depends: fix compiling bdb with clang-16 on aarch64":
(https://github.com/bitcoin/bitcoin/pull/27462#issuecomment-1514514571)
@theuni Thanks for following up. Hopefully we'll be able to avoid the route of having to do even more invasive patching.

💬 fanquake commented on pull request "p2p: update hardcoded mainnet seeds for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27488#issuecomment-1514526711)
cc @wiz

🚀 fanquake merged a pull request: "depends: Remove `_LIBCPP_DEBUG` from depends DEBUG mode"
(https://github.com/bitcoin/bitcoin/pull/27447)

👋 fanquake's pull request is ready for review: "ci: build libc++ in DEBUG mode in MSAN jobs"
(https://github.com/bitcoin/bitcoin/pull/27448)

💬 fanquake commented on pull request "ci: build libc++ in DEBUG mode in MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/27448#issuecomment-1514531348)
Rebased post #27447.

💬 ryanofsky commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1171175379)
In commit "refactor: Replace string chain name constants with ChainTypes" (5589a4b0dd5b25017299f666127b7537f5f7a4c1)

Maybe replace `const ChainType&` with `ChainType` everywhere since it's an enum and probably more efficient to pass by value instead of by reference

💬 MarcoFalke commented on pull request "ci: build libc++ in DEBUG mode in MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/27448#issuecomment-1514559389)
is DEBUG=1 enabled for them as well in depends?