💬 Sjors commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2364109880)
The macOS 14 native failure is spurious, see #30922.

💬 achow101 commented on pull request "addrman: change internal id counting to int64_t":
(https://github.com/bitcoin/bitcoin/pull/30568#issuecomment-2364128225)
ACK 51f7668d31e2624e41c7ce77fe33162802808f3f

🚀 achow101 merged a pull request: "addrman: change internal id counting to int64_t"
(https://github.com/bitcoin/bitcoin/pull/30568)

💬 Sjors commented on issue "cmake: multiprocess guix build broken":
(https://github.com/bitcoin/bitcoin/issues/30931#issuecomment-2364167684)
cc @ryanofsky

💬 achow101 commented on pull request "interfaces: #30697 follow ups":
(https://github.com/bitcoin/bitcoin/pull/30828#issuecomment-2364168197)
ACK 84663291275248fd52da644b0c2566bbf9cc780b

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2364179467)
Rebased. You now need `cmake --build WITH_SV=ON` to enable the Stratum v2 functionality. Also slightly improved the [mining instructions](https://github.com/Sjors/bitcoin/blob/sv2/doc/stratum-v2.md#testing-guide), e.g. to use `-testnet4`.

💬 achow101 commented on pull request "fix: handle invalid `-rpcbind` port earlier":
(https://github.com/bitcoin/bitcoin/pull/30679#issuecomment-2364186619)
ACK e6994efe08b282dd9e46602bcbad69567fe91dcd

🚀 achow101 merged a pull request: "interfaces: #30697 follow ups"
(https://github.com/bitcoin/bitcoin/pull/30828)

💬 Sjors commented on pull request "multiprocess: Add IPC wrapper for Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30510#issuecomment-2364192361)
I rebased https://github.com/Sjors/bitcoin/pull/48 on top of the changes here. Managed to mine a testnet4 block.

💬 achow101 commented on pull request "refactor: Allow `CScript`'s `operator<<` to accept spans, not just vectors":
(https://github.com/bitcoin/bitcoin/pull/30765#issuecomment-2364198894)
> The PR is still in a draft phase since there isn't an overall agreement about the exact direction.

Is this still the case? If not, please update the OP.

🚀 achow101 merged a pull request: "fix: handle invalid `-rpcbind` port earlier"
(https://github.com/bitcoin/bitcoin/pull/30679)

💬 achow101 commented on pull request "interpreter: use int32_t instead of int type for risczero compile":
(https://github.com/bitcoin/bitcoin/pull/30794#issuecomment-2364203799)
ACK bc52cda1f3c007bdf1ed00aa3011e207c7531017

Did not test compilation, but int and int32_t are synonymous for us.

✅ achow101 closed an issue: "Risczero Fit"
(https://github.com/bitcoin/bitcoin/issues/30747)

🚀 achow101 merged a pull request: "interpreter: use int32_t instead of int type for risczero compile"
(https://github.com/bitcoin/bitcoin/pull/30794)

💬 achow101 commented on pull request "fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target":
(https://github.com/bitcoin/bitcoin/pull/30826#issuecomment-2364222383)
ACK f482d0e366a84008129913b442f0c955de79ac93

🚀 achow101 merged a pull request: "fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target"
(https://github.com/bitcoin/bitcoin/pull/30826)

💬 davidgumberg commented on pull request "net, net_processing: additional and consistent disconnect logging":
(https://github.com/bitcoin/bitcoin/pull/28521#issuecomment-2364259064)
reACK https://github.com/bitcoin/bitcoin/commit/9967e8feb62a0c30612e437b70d1d64a2e67b9e0

Thanks for putting up with the review churn on this, it looks great! This PR makes peer disconnect message logging more consistent, and makes us better respect the `-logips` argument.

I reviewed the range-diff:

```bash
git range-diff a74bdeea..08cd29f5 6fc46927..9967e8fe
```

<details>

<summary>Manual testing</summary>

Starting a node and then doing `bitcoin-cli setnetworkactive false` and
...

💬 achow101 commented on pull request "fuzz: Add check in `p2p_headers_presync` that chain work never exceeds minimum work":
(https://github.com/bitcoin/bitcoin/pull/30918#issuecomment-2364294764)
ACK 284bd17309ab3b124d9dcddfec62f5506383343b

🚀 achow101 merged a pull request: "fuzz: Add check in `p2p_headers_presync` that chain work never exceeds minimum work"
(https://github.com/bitcoin/bitcoin/pull/30918)

💬 l0rinc commented on pull request "refactor: Allow `CScript`'s `operator<<` to accept spans, not just vectors":
(https://github.com/bitcoin/bitcoin/pull/30765#issuecomment-2364331594)
> Is this still the case? If not, please update the OP.

Removed, thank you.