💬 fjahr commented on pull request "wallet: Write best block to disk before backup":
(https://github.com/bitcoin/bitcoin/pull/30678#discussion_r1768873992)
done

💬 fjahr commented on pull request "wallet: Write best block to disk before backup":
(https://github.com/bitcoin/bitcoin/pull/30678#discussion_r1768874108)
added

💬 fjahr commented on pull request "wallet: Write best block to disk before backup":
(https://github.com/bitcoin/bitcoin/pull/30678#discussion_r1768875839)
I have amended the log message and I have added basic coverage for the balances of the wallet. That required some further changes to the test as a whole since there were no balances before due to the use of miniwallet, so I have done this in a separate commit.

💬 LarryRuane commented on pull request "doc: cmake: prepend "build" to functional/test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/30859#issuecomment-2364098530)
@fanquake - thanks, I'll fix all these this weekend.

💬 Sjors commented on issue "Intermittent failure in p2p_1p1c_network.py", line 58, in raise_network_minfee assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB) ; AssertionError: 0.00001000 <= 0.00001000":
(https://github.com/bitcoin/bitcoin/issues/30922#issuecomment-2364108949)
I saw this several times today as well.

💬 Sjors commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2364109880)
The macOS 14 native failure is spurious, see #30922.

💬 achow101 commented on pull request "addrman: change internal id counting to int64_t":
(https://github.com/bitcoin/bitcoin/pull/30568#issuecomment-2364128225)
ACK 51f7668d31e2624e41c7ce77fe33162802808f3f

🚀 achow101 merged a pull request: "addrman: change internal id counting to int64_t"
(https://github.com/bitcoin/bitcoin/pull/30568)

💬 Sjors commented on issue "cmake: multiprocess guix build broken":
(https://github.com/bitcoin/bitcoin/issues/30931#issuecomment-2364167684)
cc @ryanofsky

💬 achow101 commented on pull request "interfaces: #30697 follow ups":
(https://github.com/bitcoin/bitcoin/pull/30828#issuecomment-2364168197)
ACK 84663291275248fd52da644b0c2566bbf9cc780b

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2364179467)
Rebased. You now need `cmake --build WITH_SV=ON` to enable the Stratum v2 functionality. Also slightly improved the [mining instructions](https://github.com/Sjors/bitcoin/blob/sv2/doc/stratum-v2.md#testing-guide), e.g. to use `-testnet4`.

💬 achow101 commented on pull request "fix: handle invalid `-rpcbind` port earlier":
(https://github.com/bitcoin/bitcoin/pull/30679#issuecomment-2364186619)
ACK e6994efe08b282dd9e46602bcbad69567fe91dcd

🚀 achow101 merged a pull request: "interfaces: #30697 follow ups"
(https://github.com/bitcoin/bitcoin/pull/30828)

💬 Sjors commented on pull request "multiprocess: Add IPC wrapper for Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30510#issuecomment-2364192361)
I rebased https://github.com/Sjors/bitcoin/pull/48 on top of the changes here. Managed to mine a testnet4 block.

💬 achow101 commented on pull request "refactor: Allow `CScript`'s `operator<<` to accept spans, not just vectors":
(https://github.com/bitcoin/bitcoin/pull/30765#issuecomment-2364198894)
> The PR is still in a draft phase since there isn't an overall agreement about the exact direction.

Is this still the case? If not, please update the OP.

🚀 achow101 merged a pull request: "fix: handle invalid `-rpcbind` port earlier"
(https://github.com/bitcoin/bitcoin/pull/30679)

💬 achow101 commented on pull request "interpreter: use int32_t instead of int type for risczero compile":
(https://github.com/bitcoin/bitcoin/pull/30794#issuecomment-2364203799)
ACK bc52cda1f3c007bdf1ed00aa3011e207c7531017

Did not test compilation, but int and int32_t are synonymous for us.

✅ achow101 closed an issue: "Risczero Fit"
(https://github.com/bitcoin/bitcoin/issues/30747)

🚀 achow101 merged a pull request: "interpreter: use int32_t instead of int type for risczero compile"
(https://github.com/bitcoin/bitcoin/pull/30794)

💬 achow101 commented on pull request "fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target":
(https://github.com/bitcoin/bitcoin/pull/30826#issuecomment-2364222383)
ACK f482d0e366a84008129913b442f0c955de79ac93