💬 i-am-yuvi commented on pull request "tracing: network connection tracepoints":
(https://github.com/bitcoin/bitcoin/pull/25832#issuecomment-2358601668)
tested ACK 🔥

Successfully ran demo scripts and functional tests!!

I have been using these tracepoints for 3-4 months from now and I find it very useful. They help you keep track of your peers, also I am working on a tool that detects spy peers and for that these tracepoints are very useful.

Great work @0xB10C.

⚠️ maflcko opened an issue: "Intermittent failure in p2p_1p1c_network.py", line 58, in raise_network_minfee assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB) ; AssertionError: 0.00001000 <= 0.00001000"
(https://github.com/bitcoin/bitcoin/issues/30922)
https://github.com/bitcoin/bitcoin/actions/runs/10923649833/job/30320807014?pr=30921#step:7:46110

```
node0 2024-09-18T14:10:27.733922Z [httpworker.2] [src/rpc/request.cpp:232] [parse] [rpc] ThreadRPCServer method=getmempoolinfo user=__cookie__
test 2024-09-18T14:10:27.734000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/Users/runner/work/bitcoin/bitcoin/test/functional/test_fr
...

💬 maflcko commented on pull request "p2p: When close to the tip, download blocks in parallel from additional peers to prevent stalling":
(https://github.com/bitcoin/bitcoin/pull/29664#issuecomment-2358652413)
The CI failed, but the logs are missing :(

https://github.com/bitcoin/bitcoin/pull/29664/checks?check_run_id=30286710796

```
�[0m�[0;31mp2p_ibd_stalling.py --v2transport | ✖ Failed | 2465 s
```

I'll re-run 10 times.

💬 maflcko commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-2358671416)
On CI:

```
�[0m�[0;31mtool_utxo_to_sqlite.py | ✖ Failed | 2 s

💬 maflcko commented on issue "Intermittent issue in p2p_i2p_ports.py AssertionError: [node 0] Expected messages "['Error connecting to [...].b32.i2p:0: Cannot connect to 127.0.0.1:60000']" does not partially match log:":
(https://github.com/bitcoin/bitcoin/issues/30030#issuecomment-2358711183)
https://github.com/bitcoin/bitcoin/actions/runs/10923053194/job/30318787539?pr=30849#step:6:2225

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1765239421)
thanks! Updated in [a9964c0](https://github.com/bitcoin/bitcoin/pull/30875/commits/a9964c04447745435747d9cc557165c43902783b)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1765239532)
thanks! Updated in [a9964c0](https://github.com/bitcoin/bitcoin/pull/30875/commits/a9964c04447745435747d9cc557165c43902783b)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1765239674)
thanks! Updated in [a9964c0](https://github.com/bitcoin/bitcoin/pull/30875/commits/a9964c04447745435747d9cc557165c43902783b)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2358734956)
> ACK [bc4a929](https://github.com/bitcoin/bitcoin/commit/bc4a929cd716cd2b412c70754749d4fda0ca2a10)
>
> pico-nit: your branch messes up the 80 column wrapping in a few spots in `doc/developer-notes.md`. This is not really consistent through the docs anyways, so I don't mind personally.

thanks for the suggestion! But I think I'll leave those for now since they don't relate to the autotools to cmake update too much and I would prefer to keep the PR more focused on those changes

💬 maflcko commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2358736153)
ACK a9964c04447745435747d9cc557165c43902783b

💬 mzumsande commented on pull request "p2p: When close to the tip, download blocks in parallel from additional peers to prevent stalling":
(https://github.com/bitcoin/bitcoin/pull/29664#issuecomment-2358747706)
> The CI failed, but the logs are missing :( I'll re-run 10 times.

Thanks, I can also reproduce it locally, so no need to do more CI runs!

💬 alfonsoromanz commented on pull request "test: add validation for gettxout RPC response":
(https://github.com/bitcoin/bitcoin/pull/30226#issuecomment-2358813435)
> You'll probably have to rebase, as it may be a silent conflict.

Yes, that was it. I've rebased and resolved the conflict. Thanks for your help!

💬 brunoerg commented on pull request "fuzz: speed up addrman":
(https://github.com/bitcoin/bitcoin/pull/30688#issuecomment-2358839941)
Force-pushed increasing the number of iterations from 100 to 1000 (the original value is 10'000). With this value, I could see faster execs (115 exec/s) and same coverage.

💬 brunoerg commented on pull request "fuzz: speed up addrman":
(https://github.com/bitcoin/bitcoin/pull/30688#discussion_r1765317533)
https://github.com/bitcoin/bitcoin/pull/30688#issuecomment-2358839941

💬 hebasto commented on issue "Trying to run bitcoin qt on Windows and getting an AV":
(https://github.com/bitcoin/bitcoin/issues/30825#issuecomment-2358859393)
I can confirm the issue for the `x64-windows` triplet.

All test pass for the `x64-windows-static` triplet.

🤔 mzumsande reviewed a pull request: "cli: Improve error message on multiwallet cli-side commands"
(https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-2313157402)
Code Review ACK 54227e681a4efa8961f1ad05d43366d88a9b686a

💬 jonatack commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2358862096)
utACK a9964c04447745435747d9cc557165c43902783b

💬 hebasto commented on issue "Trying to run bitcoin qt on Windows and getting an AV":
(https://github.com/bitcoin/bitcoin/issues/30825#issuecomment-2358870082)
@danilotg

What happens if you set the `QT_QPA_PLATFORM` environment variable to "windows"?

⚠️ jarolrod opened an issue: "cmake: adjust devtools scripts to work under cmake build environment"
(https://github.com/bitcoin/bitcoin/issues/30923)
### Please describe the feature you'd like to see added.

The following scripts no longer run without changes:
- gen-bitcoin-conf.sh
- gen-manpages.py

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

_No response_

### Describe any alternatives you've considered

_No response_

### Please leave any additional context

_No response_

🤔 jonatack reviewed a pull request: "cli: Improve error message on multiwallet cli-side commands"
(https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-2313182154)
ACK 54227e681a4efa8961f1ad05d43366d88a9b686a