💬 epompeii commented on issue "Continuous benchmark tracking":
(https://github.com/bitcoin/bitcoin/issues/27284#issuecomment-1511266170)
If using https://codespeed.bitcoinperf.com doesn't work out, I have created a continuous benchmarking for doing exactly this, Bencher: https://github.com/bencherdev/bencher

Bencher tracks changes over time. It can easily be run in CI as a GitHub Action, and it has statistical thresholds to detect deviations.

💬 pablomartin4btc commented on pull request "bugfix: rest: avoid segfault for invalid URI":
(https://github.com/bitcoin/bitcoin/pull/27468#issuecomment-1511328493)
Updated changes:
- Fixed issue detected by @theStack on the `rest/mempool` endpoint that was also calling `GetQueryParameter()`.

💬 jonatack commented on pull request "p2p: skip netgroup diversity follow-up":
(https://github.com/bitcoin/bitcoin/pull/27467#discussion_r1168692041)
Thanks @vasild, done.

💬 achow101 commented on pull request "bugfix: Properly handle "unknown" Address Type":
(https://github.com/bitcoin/bitcoin/pull/27473#issuecomment-1511385387)
ACK 0d6383fda04a99726654945a737bbb1369e0e44a

👍 stickies-v approved a pull request: "bugfix: rest: avoid segfault for invalid URI"
(https://github.com/bitcoin/bitcoin/pull/27468#pullrequestreview-1388121074)
re-ACK 11422cc

💬 achow101 commented on pull request "test: fix bumpfee 'spend_one_input' occasional failure":
(https://github.com/bitcoin/bitcoin/pull/27471#issuecomment-1511388532)
ACK e07dd5fff9eb64d7615ab515b351e296c00b1861

💬 achow101 commented on pull request "bugfix: rest: avoid segfault for invalid URI":
(https://github.com/bitcoin/bitcoin/pull/27468#issuecomment-1511393882)
ACK 11422cc5720c8d73a87600de8fe8abb156db80dc

💬 MarcoFalke commented on pull request "bugfix: Properly handle "unknown" Address Type":
(https://github.com/bitcoin/bitcoin/pull/27473#issuecomment-1511418996)
lgtm ACK 0d6383fda04a99726654945a737bbb1369e0e44a

In a follow-up, might be good to at least add a regression test, or even extend the fuzz tests, see https://github.com/bitcoin/bitcoin/issues/27472#issuecomment-1510918616

👍 furszy approved a pull request: "bugfix: Properly handle "unknown" Address Type"
(https://github.com/bitcoin/bitcoin/pull/27473#pullrequestreview-1388179447)
ACK https://github.com/bitcoin/bitcoin/commit/0d6383fda04a99726654945a737bbb1369e0e44a

🚀 fanquake merged a pull request: "bugfix: rest: avoid segfault for invalid URI"
(https://github.com/bitcoin/bitcoin/pull/27468)

💬 jonatack commented on pull request "test: fix bumpfee 'spend_one_input' occasional failure":
(https://github.com/bitcoin/bitcoin/pull/27471#issuecomment-1511439235)
Another failure just now. https://cirrus-ci.com/task/5307259153022976

📝 fanquake opened a pull request: "[24.x] Additional backports for 24.1"
(https://github.com/bitcoin/bitcoin/pull/27474)
Backports:
* https://github.com/bitcoin/bitcoin/pull/27473

✅ achow101 closed an issue: "Mishandled "unknown" Address Type"
(https://github.com/bitcoin/bitcoin/issues/27472)

🚀 achow101 merged a pull request: "bugfix: Properly handle "unknown" Address Type"
(https://github.com/bitcoin/bitcoin/pull/27473)

👍 pablomartin4btc approved a pull request: "bugfix: Properly handle "unknown" Address Type"
(https://github.com/bitcoin/bitcoin/pull/27473#pullrequestreview-1388202032)
Reproduced the issue manually from https://github.com/bitcoin/bitcoin/issues/27472. Agree with above to add more test coverage if possible.

ACK https://github.com/bitcoin/bitcoin/commit/0d6383fda04a99726654945a737bbb1369e0e44a.

💬 fanquake commented on pull request "bugfix: Properly handle "unknown" Address Type":
(https://github.com/bitcoin/bitcoin/pull/27473#issuecomment-1511452937)
Backported to 24.x in #27474.

💬 jonatack commented on pull request "[24.x] Additional backports for 24.1":
(https://github.com/bitcoin/bitcoin/pull/27474#issuecomment-1511457643)
Suggest adding https://github.com/bitcoin/bitcoin/commit/f73782a9032a462a71569e9424db9bf9eeababf3.

💬 pablomartin4btc commented on pull request "test: fix bumpfee 'spend_one_input' occasional failure":
(https://github.com/bitcoin/bitcoin/pull/27471#issuecomment-1511463221)
ACK https://github.com/bitcoin/bitcoin/commit/e07dd5fff9eb64d7615ab515b351e296c00b1861.

🤔 instagibbs reviewed a pull request: "mempool: disallow txns under min relay fee, even in packages"
(https://github.com/bitcoin/bitcoin/pull/26933#pullrequestreview-1388204359)
re-ACK https://github.com/bitcoin/bitcoin/pull/26933/commits/bf77fc9cb45209b9c560208c65abc94209cd7919

💬 instagibbs commented on pull request "mempool: disallow txns under min relay fee, even in packages":
(https://github.com/bitcoin/bitcoin/pull/26933#discussion_r1168777037)
should this just be None and have a check that it's non-None later? or is this value important?