💬 MarcoFalke commented on issue "test: `wallet_importdescriptors.py --descriptors` failure":
(https://github.com/bitcoin/bitcoin/issues/27282#issuecomment-1509741820)
Is this still an issue with a recent version of Bitcoin Core? If yes, what are the steps to reproduce?

💬 fanquake commented on issue "test: `wallet_importdescriptors.py --descriptors` failure":
(https://github.com/bitcoin/bitcoin/issues/27282#issuecomment-1509743072)
I don't think I've seen this again, only occurence seemed to be Cirrus above (before the fix). Guess we can reclose for now? Will remove from the milestone in any case.

💬 MarcoFalke commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-1509743101)
Not a regression, so I removed the milestone. Bug fixes are still welcome, though.

💬 MarcoFalke commented on issue "test: `wallet_importdescriptors.py --descriptors` failure":
(https://github.com/bitcoin/bitcoin/issues/27282#issuecomment-1509743273)
sgtm. Closing for now, until this happens again.

✅ MarcoFalke closed an issue: "test: `wallet_importdescriptors.py --descriptors` failure"
(https://github.com/bitcoin/bitcoin/issues/27282)

🚀 fanquake merged a pull request: "bumpfee: avoid making bumped transactions with too low fee when replacing outputs"
(https://github.com/bitcoin/bitcoin/pull/27308)

👍 fanquake approved a pull request: "doc: fix typo in developer-notes.md"
(https://github.com/bitcoin/bitcoin/pull/27465#pullrequestreview-1386442306)
ACK f24f4fa3f114b1bd5b7e7ff9ebb0ef73bfc81eda

🚀 fanquake merged a pull request: "doc: fix typo in developer-notes.md"
(https://github.com/bitcoin/bitcoin/pull/27465)

👍 stickies-v approved a pull request: "bugfix: rest: avoid segfault for invalid URI"
(https://github.com/bitcoin/bitcoin/pull/27468#pullrequestreview-1386480124)
ACK 827b14c33f39131ede35ddecde75cc052d977ec5

💬 furszy commented on pull request "bumpfee: allow send coins back to yourself":
(https://github.com/bitcoin/bitcoin/pull/27195#issuecomment-1509837822)
rebased, conflicts solved. Ready to go.

📝 furszy opened a pull request: "wallet: improve IBD sync time by skipping block scanning prior birth time"
(https://github.com/bitcoin/bitcoin/pull/27469)
During initial block download, the node's wallet(s) scans every arriving block looking for data that it owns.
This process can be resource-intensive, as it involves sequentially scanning all transactions within each
arriving block.

To avoid wasting processing power, we can skip blocks that occurred before the wallet's creation time,
since these blocks are guaranteed not to contain any relevant wallet data.

This has direct implications (an speed improvement) on the underlying blockchain
...

📝 Muhammedhamid23 opened a pull request: "Create docker-image.yml"
(https://github.com/bitcoin/bitcoin/pull/27470)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 furszy opened a pull request: "test: fix bumpfee 'spend_one_input' occasional failure"
(https://github.com/bitcoin/bitcoin/pull/27471)
CI test failure, in master: https://cirrus-ci.com/task/5975232842825728.
In #27469 https://cirrus-ci.com/task/6452468402356224

Most of the subtests in `wallet_bumpfee.py` expect to find spendable UTXOs of 0.001 btc in the rbf wallet (they use the `spend_one_input()` method that tries to spend one of them and if it doesn't find any, it throws an exception).

The sporadic failure comes from the recently added `test_feerate_checks_replaced_outputs` subtest that can spend all them. Leaving the
...

🤔 turkycat reviewed a pull request: "blockstorage: do not flush block to disk if it is already there"
(https://github.com/bitcoin/bitcoin/pull/27039#pullrequestreview-1386645395)
core review and local test run ACK 470ef396

💬 turkycat commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#discussion_r1167679089)
nit: use of assignment operator on line 126 while using initializer syntax for the same type on 123.

```suggestion
FlatFilePos pos2{blockman.SaveBlockToDisk(block2, /*nHeight=*2, chain, *params, /*dbp=*/nullptr)};
```

💬 turkycat commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#discussion_r1167681916)
can you explain why you're sleeping _after_ reading `last_write_time`? If I understand correctly, based on the other comments in this thread, the sleep is necessary because the file modified time may not be updated immediately after the contents are written. This test does pass on my linux machine (which has a significantly shorter resolution time), yet I feel that we should be sleeping immediately after the potential file write does/does not occur before checking the file time and verifying it?
...

💬 pinheadmz commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#issuecomment-1510029147)
concept ACK, seems like a great idea.

💬 carnhofdaki commented on pull request "Allow configuring target block time for a signet":
(https://github.com/bitcoin/bitcoin/pull/27446#issuecomment-1510084025)
> If anyone is interested in testing, I am running this for a custom signet.
>
> ```
> [signet]
> signetchallenge=512102f7561d208dd9ae99bf497273e16f389bdbd6c4742ddb8e6b216e64fa2928ad8f51ae
> signetblocktime=30
> addnode=45.79.52.207:38333
> dnsseed=0
> ```
>
> Block explorer: https://mutinynet.com faucet: https://faucet.mutinynet.com
>
> There is also a rapid gossip sync server and some lightning nodes as well

Testing synchronization with an unpatched, though rececnt `master`.
...

💬 carnhofdaki commented on pull request "Allow configuring target block time for a signet":
(https://github.com/bitcoin/bitcoin/pull/27446#issuecomment-1510089291)
Oops :) That was mainnet.

The unpatched node gets stuck at block 4000 of Mutinynet:

```
2023-04-16T05:42:04Z UpdateTip: new best=00000139b753b743c4f78b29104c511774447e1d2d9977fde03916d5125b04b3 height=4000 version=0x20000000 log2_work=34.172249 tx=4018 date='2023-04-14T10:01:11Z' progress=1.000000 cache=0.5MiB(4020txo)
2023-04-16T05:42:23Z Adding fixed seeds as 60 seconds have passed and addrman is empty for at least one reachable network
2023-04-16T05:42:23Z Added 0 fixed seeds from re
...

💬 carnhofdaki commented on pull request "Allow configuring target block time for a signet":
(https://github.com/bitcoin/bitcoin/pull/27446#issuecomment-1510139984)
`master` + this little patch (cherry-picked) runs well

```
2023-04-16T07:24:34Z Saw new header hash=000001fda3c4b1118e704e6951a6064d983b2a389bf33cb9c6db2665faf81d20 height=8655
2023-04-16T07:24:34Z [net] Saw new cmpctblock header hash=000001fda3c4b1118e704e6951a6064d983b2a389bf33cb9c6db2665faf81d20 peer=0
2023-04-16T07:24:34Z UpdateTip: new best=000001fda3c4b1118e704e6951a6064d983b2a389bf33cb9c6db2665faf81d20 height=8655 version=0x20000000 log2_work=35.285589 tx=8682 date='2023-04-16T07:24
...