🤔 glozow reviewed a pull request: "test: add check that too large txs aren't put into orphanage"
(https://github.com/bitcoin/bitcoin/pull/30784#pullrequestreview-2278486931)
ACK 66d13c870284327abc89d36c0b5cc5f58e96f570

💬 achow101 commented on pull request "http: set TCP_NODELAY when creating HTTP server":
(https://github.com/bitcoin/bitcoin/pull/30675#issuecomment-2327442239)
ACK 03d49d0f25ab5660524d5ddd171de677a808b984

🚀 achow101 merged a pull request: "http: set TCP_NODELAY when creating HTTP server"
(https://github.com/bitcoin/bitcoin/pull/30675)

💬 hodlinator commented on pull request "test: support std::optional in BOOST_CHECK_* and increase FromUserHex fuzz feature coverage":
(https://github.com/bitcoin/bitcoin/pull/30618#discussion_r1742776951)
`@{` is [Doxygen grouping syntax](https://www.doxygen.nl/manual/grouping.html). I was trying to make it work properly in generated documentation using `@name` but the `namespace std` parts were always being extracted, so opted for vanilla comment style.

💬 denavila commented on pull request "Deniability - a tool to automatically improve coin ownership privacy":
(https://github.com/bitcoin-core/gui/pull/733#issuecomment-2327557888)
Yes, it looks like recursive functions were disallowed recently.
I'll rework the code to not use recursion.

💬 achow101 commented on pull request "Add Signet and testnet4 launch shortcuts for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-2327566780)
ACK cfd03de965a081facbd72316c76603dd7aa511bd

Did not test, but the code matches the pattern used for the other networks.

💬 justinvforvendetta commented on issue "build: Boost 1.74.0 incompatible with Clang 18":
(https://github.com/bitcoin/bitcoin/issues/30751#issuecomment-2327567895)
can confirm this issue exists with boost 1.76 under same environment.

💬 hodlinator commented on pull request "test: support std::optional in BOOST_CHECK_* and increase FromUserHex fuzz feature coverage":
(https://github.com/bitcoin/bitcoin/pull/30618#discussion_r1742786068)
Was under the impression that Git had some smarts when it came to moving lines around, but at least naive `git blame` usage shows your name & commit on all the moved lines in the **.cpp**. It's straightforward code (going back in history is less necessary), and I understand your attempt to mirror the ordering from the **.h** file.

I think the ordering I pushed for in the **.h** file should stay either way, but maybe go with the more conservative approach in the **.cpp** as a compromise.

👍 tdb3 approved a pull request: "test: add check that too large txs aren't put into orphanage"
(https://github.com/bitcoin/bitcoin/pull/30784#pullrequestreview-2278662281)
re-ACK 66d13c870284327abc89d36c0b5cc5f58e96f570

Nice unit test addition.

💬 russeree commented on issue "Testnet4 consensus failure due to timewarp related "softfork"":
(https://github.com/bitcoin/bitcoin/issues/30786#issuecomment-2327623322)
> Anyone have an asic to reorg that?

Hash on the way!

📝 furszy opened a pull request: "Fix peers abruptly disconnecting from AssumeUTXO nodes during IBD"
(https://github.com/bitcoin/bitcoin/pull/30807)
Context:
AssumeUTXO nodes prioritize tip synchronization first, meaning they advertise
knowledge of all blocks posterior to the snapshot base block hash. This, in
conjunction with the current protocol behavior where nodes request blocks
from peers that directly advertise them or their descendants, causes honest
peers trying to synchronize historical blocks from AssumeUTXO nodes to
forcibly disconnect, after stalling for ~10 minutes, due to a `getdata` lack
of response while the AssumeUTXO
...

💬 hashbender commented on issue "Testnet4 consensus failure due to timewarp related "softfork"":
(https://github.com/bitcoin/bitcoin/issues/30786#issuecomment-2327647103)
You have my hashpower 🫡

📝 fjahr opened a pull request: "rpd: dumptxoutset height parameter followups (29553)"
(https://github.com/bitcoin/bitcoin/pull/30808)
First, this addresses two left-over comments in #29553:

- When running `dumptxoutset` the network gets disabled in the beginning and then re-enabled in the beginning. The network would be re-enabled even if the user had already disabled the network themself before running `dumptxoutset`. The network is now not re-enabled anymore since that might not be what the user wants.
- The `-rpcclienttimeout=0` option is added to `loadtxoutset` examples in documentation

Additionally, pablomartin4btc
...

💬 fjahr commented on pull request "rpd: dumptxoutset height parameter followups (29553)":
(https://github.com/bitcoin/bitcoin/pull/30808#issuecomment-2327682955)
cc @pablomartin4btc

💬 1440000bytes commented on issue "Testnet4 consensus failure due to timewarp related "softfork"":
(https://github.com/bitcoin/bitcoin/issues/30786#issuecomment-2327691014)
> You have my hashpower 🫡

This will help

📝 Sarsilmazxx02 opened a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/30809)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#issuecomment-2327703573)
> this PR might be a good time to enhance `test/functional/p2p_orphan_handling.py`, reducing our reliance on log messages at least

Great idea. For now, a child branch was started (https://github.com/tdb3/bitcoin/tree/enhance_p2p_orphan_handling) that adds a commit (https://github.com/tdb3/bitcoin/commit/344ab30487235a2096d878894dc6f4e2d0d1ef65) to update `p2p_orphan_handling`.

Since additional enhancements could be made to that branch (e.g. to check the orphanage when the debug log is sile
...

💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1742851986)
Updated

✅ achow101 closed a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/30809)

📝 achow101 locked a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/30809)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...