💬 instagibbs commented on pull request "cluster mempool: optimized candidate search":
(https://github.com/bitcoin/bitcoin/pull/30286#issuecomment-2327148258)
reACK 100e1b9ecb29c76187112fda9fed1c01da192c99

via `git range-diff master 12760a57b3a6cd1aeb3b7532311f648de2b45aa4 100e1b9ecb29c76187112fda9fed1c01da192c99`

just some comment updates

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2327172907)
1f720ffe25443b37624d4d52e040d29ecf93278a adds a temporary fix for a crash after finding a block. This was introduced by the interface changes. Will investigate later, as part of https://github.com/Sjors/bitcoin/pull/49.

New tag [sv2-tp-0.1.9](https://github.com/Sjors/bitcoin/releases/tag/sv2-tp-0.1.9)

📝 maflcko opened a pull request: "scripted-diff: fuzz: Rename fuzz_seed_corpus to fuzz_corpora"
(https://github.com/bitcoin/bitcoin/pull/30804)
Now that cmake was a breaking change for all fuzz scripts, it seems fine to bundle it with another breaking change to rename the fuzz corpora directory, as discussed and approved in https://github.com/bitcoin-core/qa-assets/issues/200:

* The word "seed" in the old name doesn't really apply. In reality it is a collection of fuzz input seeds, as well as fuzz inputs.
* The rename will also allow in the future (when there is a need and desire) to provide a minimal set of possibly hand-crafted or
...

💬 maflcko commented on pull request "test: fixing failing system_tests/run_command under some Locales":
(https://github.com/bitcoin/bitcoin/pull/30788#issuecomment-2327195870)
review ACK 8289373ebf089d0719a8edecb8bfbd52c244f4ee

Please adjust the pull request description, now that the approach has changed: https://github.com/bitcoin/bitcoin/pull/30788#issue-2500949706

💬 maflcko commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#discussion_r1742523187)
Fixed in https://github.com/bitcoin/bitcoin/pull/30788

💬 achow101 commented on pull request "assumeutxo: Add dumptxoutset height param, remove shell scripts":
(https://github.com/bitcoin/bitcoin/pull/29553#issuecomment-2327237127)
ACK 46c8d75d24d3355ec468f7f608effe94636e16db

🚀 achow101 merged a pull request: "assumeutxo: Add dumptxoutset height param, remove shell scripts"
(https://github.com/bitcoin/bitcoin/pull/29553)

💬 achow101 commented on pull request "kernel: Use spans instead of vectors for passing block headers to validation functions":
(https://github.com/bitcoin/bitcoin/pull/30742#issuecomment-2327273911)
ACK a2955f09792b6232f3a45aa44a498b466279a8b7

🚀 achow101 merged a pull request: "kernel: Use spans instead of vectors for passing block headers to validation functions"
(https://github.com/bitcoin/bitcoin/pull/30742)

💬 achow101 commented on pull request "log: expand BCLog::LogFlags (categories) to 64 bits":
(https://github.com/bitcoin/bitcoin/pull/26619#issuecomment-2327313569)
ACK b31a0cd0378184b2b9eb8f4bd3120cbd32c62005

👍 brunoerg approved a pull request: "fuzz: Rename fuzz_seed_corpus to fuzz_corpora"
(https://github.com/bitcoin/bitcoin/pull/30804#pullrequestreview-2278412987)
ACK 8888beea8d477b1d4a2dfd2a0bb5f686de62f3ff

📝 achow101 opened a pull request: "test: Add explicit onion bind to p2p_permissions"
(https://github.com/bitcoin/bitcoin/pull/30805)
When the bind option is replaced in the bitcoin.conf, bitcoind will attempd to bind to the default tor listening port. If another bitcoind is running that is already bound to that port, the bind will fail which, since #22729, causes the test to fail.

This failure can be avoided by explicitly binding the tor port when the bind is removed.

🚀 achow101 merged a pull request: "log: expand BCLog::LogFlags (categories) to 64 bits"
(https://github.com/bitcoin/bitcoin/pull/26619)

✅ LarryRuane closed a pull request: "logging: use bitset for categories"
(https://github.com/bitcoin/bitcoin/pull/26697)

💬 LarryRuane commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#issuecomment-2327395797)
Closing because #26619 (an alternative to this PR) has merged. We could make this active again because it is arguably cleaner and nicer, but the immediate need to increase the number of logging categories no longer exists.

👍 instagibbs approved a pull request: "refactor: TxDownloadManager + fuzzing"
(https://github.com/bitcoin/bitcoin/pull/30110#pullrequestreview-2278214287)
reACK 1d4e33e7f88162cf6fcd6aee0b63973015853591

didn't run the new fuzz test iteration though it seems reasonable to me

via `git range-diff master 2b387a156a1021ad782dc4de2fd34d5b5b81698a 1d4e33e7f88162cf6fcd6aee0b63973015853591`

💬 instagibbs commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1742665719)
this comment is outdated, as TX_REAL now means really whatever the node getdata'd

💬 fanquake commented on pull request "build: Minor build system fixes and amendments":
(https://github.com/bitcoin/bitcoin/pull/30803#discussion_r1742669417)
I think we should just remove any dates entirely.

💬 theStack commented on pull request "test: add check that too large txs aren't put into orphanage":
(https://github.com/bitcoin/bitcoin/pull/30784#issuecomment-2327406051)
@glozow:

> Concept ACK, but this should be a unit test, not a functional test looking for logs. We could accidentally delete the `return false;` line but keep the `LogPrint` line, and this test would pass.
>
> > so this is only relevant if tx standardness rules are disabled via -acceptnonstdtxns=1.
>
> Similarly, it's a bit icky to have to disable standardness checks to test this.

Agree! For some reason I haven't even considered doing this as a unit test, but it makes much more sens
...

💬 instagibbs commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#issuecomment-2327411398)
this PR might be a good time to enhance `test/functional/p2p_orphan_handling.py`, reducing our reliance on log messages at least