💬 LarryRuane commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#issuecomment-2282993104)
Thanks, Russ, I made both suggested changes (force pushed).

🤔 Shuhaib07 reviewed a pull request: "26.2 final changes"
(https://github.com/bitcoin/bitcoin/pull/30376#pullrequestreview-2232018547)
Approve

💬 Shuhaib07 commented on pull request "crypto, refactor: add new KeyPair class":
(https://github.com/bitcoin/bitcoin/pull/30051#discussion_r1713154630)
Okay

🤔 Shuhaib07 reviewed a pull request: "crypto, refactor: add new KeyPair class"
(https://github.com/bitcoin/bitcoin/pull/30051#pullrequestreview-2232024699)
Approve

📝 kirthana4323 opened a pull request: "Main"
(https://github.com/bitcoin/bitcoin/pull/30631)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ achow101 closed a pull request: "Main"
(https://github.com/bitcoin/bitcoin/pull/30631)

📝 achow101 locked a pull request: "Main"
(https://github.com/bitcoin/bitcoin/pull/30631)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 vasild commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1713192718)
This can observe a state that never was. For example, lets say `bits[]` has 2 elements, initially `[0000, 0010]`:

0. `[0000, 0010]`, `any() == true`
1. `any()` is called and it reads the first element `0000`
2. another thread sets the 1st bit, new state: `[1000, 0010]`, `any() == true`
3. another thread resets the 7th bit, new state: `[1000, 0000]`, `any() == true`
4. the execution of `any()` from 1. continues and reads the second element: `0000` and that `any()` call returns `false`, eve
...

💬 maflcko commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2283305777)
The very first machine I set up on AWS refused ssh access and had to be rebooted (fine so far after a reboot). Maybe all of this is just AWS hardware failures?

⚠️ GregTonoski opened an issue: "An "output descriptor" should not have many different checksums"
(https://github.com/bitcoin/bitcoin/issues/30632)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

There are different BIP-380 checksums for the same addresses/ScriptPubs/keys: "mpfvuvu6" and "ecrayewn".

```
$ bitcoin-cli deriveaddresses "wpkh([b8688df1]xprv9s21ZrQH143K2x4gnzRB1eZDq92Uuvy9CXbvgQGdvykXZ9mkkot6LBjzDpgaAfvzkuxJe9JKJXQ38VoPutxvACA5MsyoBs5UyQ4HZKGshGs/84'/0'/0'/0/0)#mpfvuvu6"
[
"bc1qgkju4yvvtuz0s8vqn837q396jezu2h8ex7gk98"
]
```

```
$ bitcoin-cli deriveaddresse
...

💬 paplorinc commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1713312563)
+1 for uint64_t instead of AtomicBitSet

✅ vasild closed an issue: "Finding peers to connect to after -onlynet changes may be problematic"
(https://github.com/bitcoin/bitcoin/issues/26035)

💬 vasild commented on issue "Finding peers to connect to after -onlynet changes may be problematic":
(https://github.com/bitcoin/bitcoin/issues/26035#issuecomment-2283323618)
This has been fixed by:

https://github.com/bitcoin/bitcoin/pull/26847
https://github.com/bitcoin/bitcoin/pull/27213

closing as resolved.

💬 paplorinc commented on pull request "doc: Update ccache website link":
(https://github.com/bitcoin/bitcoin/pull/30630#issuecomment-2283325788)
ACK fec74a8bcb29e7cdb1ef21c68c7c8c30c4386ca7

👍 hodlinator approved a pull request: "doc: Update ccache website link"
(https://github.com/bitcoin/bitcoin/pull/30630#pullrequestreview-2232298546)
ACK fec74a8bcb29e7cdb1ef21c68c7c8c30c4386ca7

Confirmed browser gets redirected from old URL to new URL.
(+ Pasted new URL into addressbar, removed last char, and saw the complete URL suggested based on browser history from prior redirect).

💬 dergoegge commented on issue "fuzz: `script`: Assertion `!extract_destination_ret' failed.":
(https://github.com/bitcoin/bitcoin/issues/30615#issuecomment-2283353116)
fwiw, I found this using afl++ and libfuzzer in parallel in ~16h CPU hours. The original input is much larger, but I minimized it for this issue:

```
TnNzc3NzknNzc3Nzc3Nzc3NzUXNzc3Nzc3NzcnNzc3Nzc3Nzc3Nzc3Nzc3Nzc3MAAAAAgPlzc3Nzc3NEY1wAAAAAgAEBAYABAfogAAAAc3Nzc3Nzc3Nzc3Nzc3NzbHNzc3Nzc3Jzc3//c3Nzc3Nzc3Nzc3Nzc3Nzc3Nzc3N3c3Nzc3NzRAFc/wEBAYABAQGAAQH6AS8vLy8vLy8vLy8vEi9/AC8vLy8vLy8vLy8vc3NWc3Nzc3NzlHNfc3Nzc3Pe3iHe3t7e3t7e3t7ec3NBQQCeW1yfn5+fn5+fn59cXFxcXFxcXV1cQZ+fc3Nzc3hzc3Nzc0QBXP8BAQGAAQEBgAEB+g
...

✅ glozow closed an issue: "fuzz: `script`: Assertion `!extract_destination_ret' failed."
(https://github.com/bitcoin/bitcoin/issues/30615)

🚀 glozow merged a pull request: "test: remove `ExtractDestination` false assertion for `ANCHOR` script"
(https://github.com/bitcoin/bitcoin/pull/30616)

📝 fanquake unlocked a pull request: "log: expand BCLog::LogFlags (categories) to 64 bits"
(https://github.com/bitcoin/bitcoin/pull/26619)
Increase the maximum number of logging categories from 32 to 64.

We're currently using 29 of the 32 available logging categories (there are only 3 remaining). It would be good to increase the limit soon; the fourth PR to be merged that adds a new logging category will be blocked until something like this is done.

This PR also adds a `TEST` category that uses the new range (`1ULL << 63`) in case there's a hidden assumption somewhere that the `BCLog::LogFlags` type is 32 bits. (Also added a
...

🚀 fanquake merged a pull request: "doc: Update ccache website link"
(https://github.com/bitcoin/bitcoin/pull/30630)