💬 willcl-ark commented on issue "rpcallowip = 192.168.254.0/24, 192.168.1.0/24, 192.168.0.0/24 is not accepted. How to do that?":
(https://github.com/bitcoin/bitcoin/issues/30585#issuecomment-2270654121)
Oh, I updated my saved response, thanks. Didn't realise GH was interpreting the link like that!

The correct link is https://bitcointalk.org/

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1705103582)
We still want to allow the building of Bitcoin Core on Ubuntu 22.04 using the [`cmake`](https://packages.ubuntu.com/jammy/cmake) package available in the system repository.

For reference, the last time the CMake minimum required version was updated was in https://github.com/hebasto/bitcoin/pull/123.

💬 fanquake commented on issue "docs: Windows build intructions result in a large binary":
(https://github.com/bitcoin/bitcoin/issues/30593#issuecomment-2270672301)
It's the debug symbols. If you run `strip src/bitcoind.exe` you'll end up with a ~15mb binary.

💬 hebasto commented on issue "docs: Windows build intructions result in a large binary":
(https://github.com/bitcoin/bitcoin/issues/30593#issuecomment-2270672308)
> For comparison, the latest release binary is around 15 MB.

The release binaries are stripped of debug info.

✅ fanquake closed an issue: "Improve python scripts with type hints for function parameters/return value(s)"
(https://github.com/bitcoin/bitcoin/issues/30589)

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1705137899)
> Previously benchmarks were [enabled by default](https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L180), right?

Right.

> Is this why the build is so much faster now?

As [mentioned](https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2251181234) earlier:
> Regarding the part about "the default with autoconf is on" part, in the CMake working group, we decided to enable by default only the "essential" build targets that most developers build most often in their everyday
...

💬 vostrnad commented on issue "docs: Windows build intructions result in a large binary":
(https://github.com/bitcoin/bitcoin/issues/30593#issuecomment-2270710121)
Thank you, that was it. It this something worth noting in the docs?

📝 glozow opened a pull request: "docs: update documentation for new mempoolfullrbf default"
(https://github.com/bitcoin/bitcoin/pull/30594)
Followup to #30493. Update bips.md and policy/*.md to reflect new default rules around signaling requirements in RBF.

Note: would need additional update after #30592.

🚀 fanquake merged a pull request: "Update libsecp256k1 subtree to latest master"
(https://github.com/bitcoin/bitcoin/pull/30573)

📝 TheCharlatan opened a pull request: "kernel: Introduce initial C header API"
(https://github.com/bitcoin/bitcoin/pull/30595)
This is a first attempt at introducing a C header for the libbitcoinkernel library that may be used by external applications for interfacing with Bitcoin Core's validation logic. It currently is limited to operations on blocks. This is a conscious choice, since it already offers a lot of powerful functionality, but sits just on the cusp of still being reviewable scope-wise while giving some pointers on how the rest of the API could look like.

The current design was informed by the development
...

📝 josibake opened a pull request: "fuzz: replace hardcoded numbers for bech32 limits"
(https://github.com/bitcoin/bitcoin/pull/30596)
Follow-up to #30047 to replace a hardcoded value that was missed in the original PR

💬 josibake commented on pull request "refactor: Model the bech32 charlimit as an Enum":
(https://github.com/bitcoin/bitcoin/pull/30047#discussion_r1705209950)
Good catch, this is just a leftover limit. Opened https://github.com/bitcoin/bitcoin/pull/30596 as a follow-up fix.

🤔 darosior reviewed a pull request: "miniscript: Use `ToIntegral` instead of `ParseInt64`"
(https://github.com/bitcoin/bitcoin/pull/30577#pullrequestreview-2220769703)
utACK 6714276d72244c2e2dbe9617f1341ba7fc06c0cc

✅ fanquake closed an issue: "build: Native ./depends build fails on s390x"
(https://github.com/bitcoin/bitcoin/issues/30587)

🚀 fanquake merged a pull request: "depends: fix ZMQ CMake getcachesize check"
(https://github.com/bitcoin/bitcoin/pull/30588)

💬 petertodd commented on pull request "docs: update documentation for new mempoolfullrbf default":
(https://github.com/bitcoin/bitcoin/pull/30594#issuecomment-2270831248)
ACK 7168b45ba2fa41737bdecbf102e8d61e205fcd9c

💬 petertodd commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2270837905)
I'd suggest waiting until after v28 has been released to do this. There may be a handful of users remaining that are not vulnerable to double spends in general. But run software that is incompatible with full-RBF. For example, the Wasabi coordinator software used to be an example of this, which they noticed when they were running with Knots (long since fixed).

Perfectly reasonable to give those handful of users a bit more time to fix their software.

But other than that, Concept ACK. Might
...

💬 kosuodhmwa commented on issue "rpcallowip = 192.168.254.0/24, 192.168.1.0/24, 192.168.0.0/24 is not accepted. How to do that?":
(https://github.com/bitcoin/bitcoin/issues/30585#issuecomment-2270860213)
thank you very much for your feedback :-)

🤔 ismaelsadeeq reviewed a pull request: "rename TransactionError:ALREADY_IN_CHAIN"
(https://github.com/bitcoin/bitcoin/pull/30212#pullrequestreview-2220893578)
ACK e9de0a76b99fd4708295e1178f6c079db92e7f36

👍 dergoegge approved a pull request: "fuzz: replace hardcoded numbers for bech32 limits"
(https://github.com/bitcoin/bitcoin/pull/30596#pullrequestreview-2220916330)
utACK 59c0ece0a785ce9e22fbfefce9ca228d85e5d43d