💬 ajtowns commented on pull request "Early logging improvements":
(https://github.com/bitcoin/bitcoin/pull/30386#discussion_r1677302973)
It's mostly added so that `DisableLogging()` isn't dead code; all it really achieves is a minor performance improvement. Added some comments that maybe clarifies things.

💬 ajtowns commented on pull request "Early logging improvements":
(https://github.com/bitcoin/bitcoin/pull/30386#discussion_r1677303005)
Changed

💬 ajtowns commented on pull request "Early logging improvements":
(https://github.com/bitcoin/bitcoin/pull/30386#discussion_r1677303090)
Added a followup commit to switch to string_view

⚠️ dg123lzk opened an issue: "scriptPubKey no address"
(https://github.com/bitcoin/bitcoin/issues/30450)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [X] I still think this issue should be opened here

### Report

There is no scriptPubKey in the transaction vin, how can I get the address of the transaction vin

{
"txid": "061b6336b2f7720193b389e2fe1a7f1e64eff8ff601a79665713a7104ec902fd",
"hash": "b2053bb14c98c16aecffa26999974041daffcffbd02d099a477893df807de82b",
"version": 2,
"size": 247,
"vsize": 166,
"weight": 661,

...

💬 Asma1665 commented on pull request "assumeutxo: Add dumptxoutset height param, remove shell scripts":
(https://github.com/bitcoin/bitcoin/pull/29553#issuecomment-2227858355)
Revarse my assist

💬 Sjors commented on pull request "Have createNewBlock() return a BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/30440#issuecomment-2227912652)
In https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2227392678 @TheBlueMatt wrote:

> Any IPC thing that requires serializing all the transactions for all work is going to be too slow. Bitcoin Core needs to be able to track the templates it gave out and keep them around (to keep the Transaction `shared_ptr`s in a block ready to go) until they time out.

This PR returns a `BlockTemplate` interface which causes the node to hold on to the template and its block.

The goal is to be a
...

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2227917343)
@TheBlueMatt see #30440 for my response.

💬 maflcko commented on pull request "index: Check all necessary block data is available before starting to sync":
(https://github.com/bitcoin/bitcoin/pull/29770#discussion_r1677451285)
unrelated: I wonder if at some point it could make sense to use a named type for the block status mask.

Something like `using BlockStatusMask = std::underlying_type_t<BlockStatus>;`

💬 maflcko commented on pull request "index: Check all necessary block data is available before starting to sync":
(https://github.com/bitcoin/bitcoin/pull/29770#discussion_r1677452041)
Looks like a leftover debug print?

💬 maflcko commented on pull request "refactor: Remove Span operator==, Use std::ranges::equal":
(https://github.com/bitcoin/bitcoin/pull/29071#discussion_r1677459551)
I'll fix it on the next force-push, if there is one

👍 dergoegge approved a pull request: "MiniMiner: use FeeFrac in AncestorFeerateComparator"
(https://github.com/bitcoin/bitcoin/pull/30412#pullrequestreview-2177138195)
tACK 09370529fb9f6d06f6d16bdb1fb336f7a265d8ba

Fuzzed both mini miner harnesses for a while.

👍 hebasto approved a pull request: "fix: rendering an amp characters in the wallet name for QMenu"
(https://github.com/bitcoin-core/gui/pull/828#pullrequestreview-2177151747)
ACK 948520b72d7fe8e7a3aa0d774159807058188627, module https://github.com/bitcoin-core/gui/pull/828/files#r1677136023.

Tested on Ubuntu 24.04, Windows 11 Pro and macOS 12.7.5 Monterey (x86).

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#discussion_r1677487337)
Maybe:
```C++
// Menu items remove single &. Single & are shown when && is in
// the string. So replace & with &&.
```
?

💬 dergoegge commented on pull request "fuzz: Deglobalize signature cache in sigcache test":
(https://github.com/bitcoin/bitcoin/pull/30447#discussion_r1677491573)
I think we still need to setup logging or this test will oom because this constructor logs.

💬 hebasto commented on issue "Generalized fee bumping":
(https://github.com/bitcoin-core/gui/issues/822#issuecomment-2227992916)
cc @achow101 @Sjors @GBKS

💬 Sjors commented on pull request "Have createNewBlock() return a BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/30440#issuecomment-2228006803)
Pushed a commit that adds `submitSolution` to the `BlockTemplate` interface.

✅ fanquake closed an issue: "Mini miner `AncestorFeerateComparator` Signed Integer Overflow"
(https://github.com/bitcoin/bitcoin/issues/30284)

✅ fanquake closed an issue: "fuzz: mini_miner_selection: ASSERT: mock_template_txids.size() <= blocktemplate->block.vtx.size()"
(https://github.com/bitcoin/bitcoin/issues/30367)

🚀 fanquake merged a pull request: "MiniMiner: use FeeFrac in AncestorFeerateComparator"
(https://github.com/bitcoin/bitcoin/pull/30412)

👍 hebasto approved a pull request: "Keep focus on "Hide" while ModalOverlay is visible"
(https://github.com/bitcoin-core/gui/pull/795#pullrequestreview-2177280212)
re-ACK 992b1bbd5da95ee782515fb0f5674bb7a02684b2