✅ hebasto closed an issue: "y"
(https://github.com/bitcoin/bitcoin/issues/30449)

:lock: hebasto locked an issue: "y"
(https://github.com/bitcoin/bitcoin/issues/30449)

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227347362)
> I believe that in original PR introduced a ["partial fix"](https://github.com/bitcoin/bitcoin/pull/16826) which works for the first ampersand no one just tested a wallet with several ampersands.

It might be a platform-specific issue though. See https://bugreports.qt.io/browse/QTBUG-63361.

🤔 hebasto reviewed a pull request: "fix: rendering an amp characters in the wallet name for QMenu"
(https://github.com/bitcoin-core/gui/pull/828#pullrequestreview-2176655354)
Tested 948520b72d7fe8e7a3aa0d774159807058188627 on Ubuntu 24.04 with Qt 5.15.3. It works as expected.

Going to test other platforms.

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#discussion_r1677136023)
I think that the comment should be adjusted rather than being deleted entirely.

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227351239)
cc @achow101 @jarolrod

💬 knst commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#discussion_r1677156648)
Could you suggest wording? English is not my native language

💬 andrewtoth commented on pull request "optimization: Precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-2227389053)
I did not see any improvement in the benchmark with this change. Running `./src/bench/bench_bitcoin -filter=.*Out[pP]oint.*`

commit 3b7b82b4b0c39a38538aae2cba10bec3907c5cbf
```
| ns/op | op/s | err% | ins/op | cyc/op | bra/op | miss% | total | benchmark
|--------------------:|--------------------:|--------:|----------------:|----------------:|---------------:|--------:|----------:|:----------
| 1.31 | 766,
...

💬 darosior commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1677158466)
Ugh, yes, thanks.

💬 darosior commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1677159083)
Done (in part).

💬 darosior commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1677159367)
Thanks, done.

💬 darosior commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1677159537)
Taken.

💬 TheBlueMatt commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2227392678)
> Expand createNewBlock to (optionally, only for sv2) return a vector of serialized transactions.

Any IPC thing that requires serializing all the transactions for all work is going to be too slow. Bitcoin Core needs to be able to track the templates it gave out and keep them around (to keep the Transaction `shared_ptr`s in a block ready to go) until they time out.

💬 knst commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227403684)
> It might be a platform-specific issue though. See https://bugreports.qt.io/browse/QTBUG-63361.

could someone test on Mac?
I will make probably platform's depend implementation of char replacement

💬 paplorinc commented on pull request "optimization: Precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-2227428876)
That's disappointing, thanks for checking, something's still off with my compiler, it seems.
After I finish benching https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-2227314032, I'll try this again on the dedicates server instead.
I'm also a bit surprised that the ratios are completely different compared to my measurements, e.g. `SaltedOutpointHasherBenchmark_match` and `_mismatch` are 40% off, while in my case they're basically equal. Are compilers this different?
Could you please
...

💬 HerWayBit commented on pull request "wallet: optimize migration process, batch db transactions":
(https://github.com/bitcoin/bitcoin/pull/28574#discussion_r1677181513)
https://cash.app/$SelfMadeLady270

👍 tdb3 approved a pull request: "contrib: simplify `test-security-check`"
(https://github.com/bitcoin/bitcoin/pull/30423#pullrequestreview-2176711112)
Approach ACK
Nice. Increases readability.

nit:
Thought about opportunities for deduplication (e.g. creating an object containing test cases with associated parameters/arguments, then looping through it). It's probably overkill for a file as small as `test-security-check.py` and wouldn't necessarily enhance readability.

👍 cbergqvist approved a pull request: "net: Favor peers from addrman over fetching seednodes"
(https://github.com/bitcoin/bitcoin/pull/29605#pullrequestreview-2176711714)
ACK 7aef6ba1cf1023a7ec34a57800f1044c667243a1

Couldn't wrangle git range-diff so went back to:
```console
git diff b41bbd5688f8f04b2c0e8d7f60d6df6931c17079~3 b41bbd5688f8f04b2c0e8d7f60d6df6931c17079 src/net.cpp > old
git diff 7aef6ba1cf1023a7ec34a57800f1044c667243a1~2 7aef6ba1cf1023a7ec34a57800f1044c667243a1 src/net.cpp > new
meld old new
```
Confirmed only the shuffle-function was swapped.

`test/functional/test_runner.py` passed.

💬 ajtowns commented on pull request "Early logging improvements":
(https://github.com/bitcoin/bitcoin/pull/30386#discussion_r1677302973)
It's mostly added so that `DisableLogging()` isn't dead code; all it really achieves is a minor performance improvement. Added some comments that maybe clarifies things.

💬 ajtowns commented on pull request "Early logging improvements":
(https://github.com/bitcoin/bitcoin/pull/30386#discussion_r1677303005)
Changed