💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#discussion_r1677105954)
Apparently, this code has been dead since introducing in https://github.com/bitcoin-core/gui/pull/738.

💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#issuecomment-2227310588)
> This PR changes that menu item into a menu list like Open Wallet and lets users migrate any legacy wallet in their wallet directory regardless of the wallets loaded.

Tested d45ac03a89cc500cd461f878f092cf8ec99e7760. The "Migrate Wallet" menu item is still disabled when no wallet is loaded.

💬 paplorinc commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-2227314032)
> the first commit should probably be

The first commit was just unrelated refactor, was easier to use that as a 'before'.

> a warmup run is going to take a long time

Yeah, but this makes the measurements simpler (this way I don't need the `sync` and `drop_caches`), both runs start from the same (slightly warmed up) state. Plus I didn't want to test the *exact* same settings as you did :)

> wrap hyperfine with nohup ... &

was using `tmux` for that, the warmup and the first 2 itera
...

👍 hebasto approved a pull request: "Show maximum mempool size in information window"
(https://github.com/bitcoin-core/gui/pull/825#pullrequestreview-2176638161)
ACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb, tested on Ubuntu 24.04.

🚀 hebasto merged a pull request: "Show maximum mempool size in information window"
(https://github.com/bitcoin-core/gui/pull/825)

💬 paplorinc commented on pull request "optimization: Precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-2227334986)
@andrewtoth, this is another tiny addition to the [coincache speedup](https://github.com/bitcoin/bitcoin/pull/28280), your review would be welcome.

💬 knst commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227338378)
> I'm not certain about that, but the mentioned comment might have been correct for some earlier version of Qt.
I tested with 2 version: Qt 5.15.14 and Qt 5.15.11.

Doc for [qt 6](https://doc.qt.io/qt-6/qmenubar.html) says:
> The ampersand in the menu item's text sets Alt+F as a shortcut for this menu. (You can use "&&" to get a real ampersand in the menu bar.)

Doc for [qt 5](https://doc.qt.io/qt-5/qmenubar.html) says the same:
> The ampersand in the menu item's text sets Alt+F as a shor
...

⚠️ ErnestoLara opened an issue: "y"
(https://github.com/bitcoin/bitcoin/issues/30449)

✅ hebasto closed an issue: "y"
(https://github.com/bitcoin/bitcoin/issues/30449)

:lock: hebasto locked an issue: "y"
(https://github.com/bitcoin/bitcoin/issues/30449)

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227347362)
> I believe that in original PR introduced a ["partial fix"](https://github.com/bitcoin/bitcoin/pull/16826) which works for the first ampersand no one just tested a wallet with several ampersands.

It might be a platform-specific issue though. See https://bugreports.qt.io/browse/QTBUG-63361.

🤔 hebasto reviewed a pull request: "fix: rendering an amp characters in the wallet name for QMenu"
(https://github.com/bitcoin-core/gui/pull/828#pullrequestreview-2176655354)
Tested 948520b72d7fe8e7a3aa0d774159807058188627 on Ubuntu 24.04 with Qt 5.15.3. It works as expected.

Going to test other platforms.

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#discussion_r1677136023)
I think that the comment should be adjusted rather than being deleted entirely.

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227351239)
cc @achow101 @jarolrod

💬 knst commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#discussion_r1677156648)
Could you suggest wording? English is not my native language

💬 andrewtoth commented on pull request "optimization: Precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-2227389053)
I did not see any improvement in the benchmark with this change. Running `./src/bench/bench_bitcoin -filter=.*Out[pP]oint.*`

commit 3b7b82b4b0c39a38538aae2cba10bec3907c5cbf
```
| ns/op | op/s | err% | ins/op | cyc/op | bra/op | miss% | total | benchmark
|--------------------:|--------------------:|--------:|----------------:|----------------:|---------------:|--------:|----------:|:----------
| 1.31 | 766,
...

💬 darosior commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1677158466)
Ugh, yes, thanks.

💬 darosior commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1677159083)
Done (in part).

💬 darosior commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1677159367)
Thanks, done.

💬 darosior commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1677159537)
Taken.