💬 hodlinator commented on pull request "rest: Reject negative outpoint index early in getutxos parsing":
(https://github.com/bitcoin/bitcoin/pull/30444#issuecomment-2227109971)
Have you considered migrating away from the other `ParseInt32()` call in the same file? Gets rid of the Valgrind comment.
This version keeps this one signed since it used in 2 places expecting signed:
```diff
diff --git a/src/rest.cpp b/src/rest.cpp
index 185508d2c9..e3e2dd96e6 100644
--- a/src/rest.cpp
+++ b/src/rest.cpp
@@ -954,8 +954,8 @@ static bool rest_blockhash_by_height(const std::any& context, HTTPRequest* req,
std::string height_str;
const RESTResponseFormat rf = Par
...

👍 tdb3 approved a pull request: "init: change shutdown order of load block thread and scheduler"
(https://github.com/bitcoin/bitcoin/pull/30435#pullrequestreview-2176555055)
ACK 5fd48360198d2ac49e43b24cc1469557b03567b8
Nice work.
Had to use a higher sleep than 50ms to reproduce the error on my local machine (used 150ms).

💬 sr-gi commented on pull request "net: Favor peers from addrman over fetching seednodes":
(https://github.com/bitcoin/bitcoin/pull/29605#issuecomment-2227150267)
@cbergqvist I'll squash for simplicity if you're fine with that

⚠️ lifesizebox opened an issue: "Block size evaluation requested"
(https://github.com/bitcoin/bitcoin/issues/30448)
### Please describe the feature you'd like to see added.

I recommend a block size preference evaluation. Let the users decide outside of default.

### Is your feature related to a problem, if so please describe it.

Increase transaction times, decrease costs.

### Describe the solution you'd like

Bigger blocks

### Describe any alternatives you've considered

BCH

### Please leave any additional context

A store of value that has no value besides its deemed value may not have the longevity fi
...

✅ hebasto closed an issue: "Block size evaluation requested"
(https://github.com/bitcoin/bitcoin/issues/30448)

:lock: hebasto locked an issue: "Block size evaluation requested"
(https://github.com/bitcoin/bitcoin/issues/30448)

💬 hebasto commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#issuecomment-2227216176)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "kernel: Streamline util library":
(https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-2227216319)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "test/BIP324: disconnection scenarios during v2 handshake":
(https://github.com/bitcoin/bitcoin/pull/29431#issuecomment-2227216955)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2227217140)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "build: add `-Wundef`":
(https://github.com/bitcoin/bitcoin/pull/29876#issuecomment-2227217262)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "Encapsulate warnings in generalized node::Warnings and remove globals":
(https://github.com/bitcoin/bitcoin/pull/30058#issuecomment-2227217405)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#issuecomment-2227217508)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#issuecomment-2227217787)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#issuecomment-2227217854)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "test: MiniWallet: respect passed feerate for padded txs (using `target_weight`)":
(https://github.com/bitcoin/bitcoin/pull/30162#issuecomment-2227217923)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "depends: remove `FORCE_USE_SYSTEM_CLANG`":
(https://github.com/bitcoin/bitcoin/pull/30201#issuecomment-2227218096)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "doc: use TRUC instead of v3 and add release note":
(https://github.com/bitcoin/bitcoin/pull/30272#issuecomment-2227218237)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "kernel: remove mempool_persist":
(https://github.com/bitcoin/bitcoin/pull/30344#issuecomment-2227218290)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "random: add benchmarks and drop unnecessary Shuffle function":
(https://github.com/bitcoin/bitcoin/pull/30396#issuecomment-2227218388)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.