💬 tdb3 commented on pull request "net: Allow -proxy=[::1] on nodes with IPV6 lo only":
(https://github.com/bitcoin/bitcoin/pull/30245#discussion_r1676117378)
Probably, but the examples I've seen are all typically small and exit the program if `getaddrinfo()` returns non-zero.

💬 Sjors commented on pull request "multiprocess: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#issuecomment-2225852563)
I opened draft PRs for all interface changes that I think I will need, see updated comment above: https://github.com/bitcoin/bitcoin/pull/30437#issuecomment-2225416191

💬 mzumsande commented on pull request "init: change shutdown order of load block thread and scheduler":
(https://github.com/bitcoin/bitcoin/pull/30435#discussion_r1676133196)
True. I changed the wording of the comment / commit message, referring to `SyncWithValidationInterfaceQueue` instead of `LimitValidationInterfaceQueue`.

📝 maflcko opened a pull request: "rest: Reject negative outpoint index early in getutxos parsing"
(https://github.com/bitcoin/bitcoin/pull/30444)
In `rest_getutxos` outpoint indexes such as `+N` or `-N` are accepted. This should be harmless, because any index out of range should be treated as a non-existent utxo. However, a negative index can't exist ever, so it seems better to reject all signs, whether `+` or `-`.

💬 mzumsande commented on pull request "init: change shutdown order of load block thread and scheduler":
(https://github.com/bitcoin/bitcoin/pull/30435#issuecomment-2225872790)
[e427fed ](https://github.com/bitcoin/bitcoin/commit/e427fed82f7931ae6f09a4939e0fcd6cb235ef0d)to [5fd4836](https://github.com/bitcoin/bitcoin/commit/5fd48360198d2ac49e43b24cc1469557b03567b8): reworded comment

> I guess it should be backported to 27.x? (My understanding is that this existed "forever", since 0.16.x, because `SyncWithValidationInterfaceQueue` never had a boost interruption point, or other interrupt check)

yes, this has existed for a long time, #23234 was opened in 2021.

💬 maflcko commented on pull request "init: change shutdown order of load block thread and scheduler":
(https://github.com/bitcoin/bitcoin/pull/30435#issuecomment-2225873306)
review ACK 5fd48360198d2ac49e43b24cc1469557b03567b8

💬 fjahr commented on pull request "index: Check all necessary block data is available before starting to sync":
(https://github.com/bitcoin/bitcoin/pull/29770#discussion_r1676145515)
Taken with minor edit, thanks!

💬 fjahr commented on pull request "index: Check all necessary block data is available before starting to sync":
(https://github.com/bitcoin/bitcoin/pull/29770#discussion_r1676145787)
done

💬 fjahr commented on pull request "index: Check all necessary block data is available before starting to sync":
(https://github.com/bitcoin/bitcoin/pull/29770#discussion_r1676145867)
Renamed

👋 fjahr's pull request is ready for review: "index: Check all necessary block data is available before starting to sync"
(https://github.com/bitcoin/bitcoin/pull/29770)

💬 fjahr commented on pull request "prune, rpc: Check undo data when finding pruneheight":
(https://github.com/bitcoin/bitcoin/pull/29668#discussion_r1676146166)
Done in #29770

💬 fjahr commented on pull request "prune, rpc: Check undo data when finding pruneheight":
(https://github.com/bitcoin/bitcoin/pull/29668#discussion_r1676146312)
Done in #29770

💬 fjahr commented on pull request "prune, rpc: Check undo data when finding pruneheight":
(https://github.com/bitcoin/bitcoin/pull/29668#discussion_r1676146409)
done in #29770

💬 fjahr commented on pull request "prune, rpc: Check undo data when finding pruneheight":
(https://github.com/bitcoin/bitcoin/pull/29668#discussion_r1676146466)
done in #29770

💬 fjahr commented on pull request "prune, rpc: Check undo data when finding pruneheight":
(https://github.com/bitcoin/bitcoin/pull/29668#discussion_r1676146524)
sounds good, taken as you suggested in #29770

💬 hebasto commented on pull request "depends: build libevent with CMake":
(https://github.com/bitcoin/bitcoin/pull/29835#issuecomment-2225902746)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/262.

🚀 fanquake merged a pull request: "#28984 package rbf followups"
(https://github.com/bitcoin/bitcoin/pull/30295)

💬 andrewtoth commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1676161918)
@paplorinc what do you think a better name for this parameter would be?

✅ fanquake closed a pull request: "Allow to configure custom libzmq prefix"
(https://github.com/bitcoin/bitcoin/pull/30256)

💬 fanquake commented on pull request "Allow to configure custom libzmq prefix":
(https://github.com/bitcoin/bitcoin/pull/30256#issuecomment-2225910922)
I agree. Thanks for the contribution, but we can revisit this (if needed) post-CMake.