💬 sipa commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218076997)
utACK a3122d38c65577cc13d88f8690da1e8f9d959c74, only reviewed the test change lightly.

🤔 sipa reviewed a pull request: "MiniMiner: use FeeFrac in AncestorFeerateComparator"
(https://github.com/bitcoin/bitcoin/pull/30412#pullrequestreview-2166777545)
utACK 271469b8bcb84af8f7a64c530e9cee7e0bf96352

💬 sipa commented on pull request "MiniMiner: use FeeFrac in AncestorFeerateComparator":
(https://github.com/bitcoin/bitcoin/pull/30412#discussion_r1670783767)
Nit: could be `return std::min(self_feerate, ancestor_feerate);`

🤔 mzumsande reviewed a pull request: "net: fix race condition in self-connect detection"
(https://github.com/bitcoin/bitcoin/pull/30394#pullrequestreview-2166824948)
I wonder if this could this lead to problems with "non-shy" software that would sends VERSION immediately on incoming connection (which bitcoin core doesn't do thanks to Hal Finney's #101, but alternative clients might).

When Bitcoin Core makes an outgoing connection after this patch, it won't send out the version message immediately, so it could receive a version message before sending one. In that case, I think that `ProcessMessage` could send out other messages (WTXIDRELAY etc.) before sen
...

🤔 BrandonOdiwuor reviewed a pull request: "rpc: doc: use "output script" terminology consistently in "asm"/"hex" results"
(https://github.com/bitcoin/bitcoin/pull/30408#pullrequestreview-2166843016)
ACK 29eafd5733d77b3e8f3f3ab6cd65c61ac0e8536b

LGTM

💬 glozow commented on pull request "MiniMiner: use FeeFrac in AncestorFeerateComparator":
(https://github.com/bitcoin/bitcoin/pull/30412#discussion_r1670835969)
done

💬 dergoegge commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2218139440)
> And compared to Bitcoin Core no one runs these things

Because not everyone needs to run these things but if they want to they can. Cramming everything into one software project is not sustainable.

> Indeed, it is absolutely a maintenance burden, but we've seen time and time and time again - nearly every project in Bitcoin outside of Bitcoin Core has not been sustainable and eventually turns into abandonware.

If it would end up unmaintained outside of Bitcoin Core, then it'd also end u
...

⚠️ VojtechMyslivec opened an issue: "Send RPC calls performance"
(https://github.com/bitcoin/bitcoin/issues/30416)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I want to report performance changes of `sendmany` and `sendtoaddress` RPC calls.

We use fresh-new wallet for more than an year. There are 24 descriptors in the wallet from which 12 were imported from about a month older wallet. We generated circa 300 k addresses from these imported descriptors and hundreds of addresses from the new ones. We had send about 1500 transactions from this wa
...

💬 VojtechMyslivec commented on issue "Send RPC calls performance":
(https://github.com/bitcoin/bitcoin/issues/30416#issuecomment-2218170930)
#26008 may relate? I am not sure if it was included in 27.0 release

📝 ryanofsky opened a pull request: "assumeutxo: Remove translated strings added in 30267"
(https://github.com/bitcoin/bitcoin/pull/30417)
maflcko pointed out in https://github.com/bitcoin/bitcoin/pull/30267#pullrequestreview-2155603386 that some error strings were being translated unneccessarily and incorrectly in #30267.

Switch them to untranslated for now. In the future if we add a GUI feature for loading snapshots, and it seems like it could be possible to trigger some of the errors, they could be translated at that point.

Also remove a newline in a thrown RPC exception.

💬 fanquake commented on pull request "assumeutxo: Remove translated strings added in 30267":
(https://github.com/bitcoin/bitcoin/pull/30417#issuecomment-2218224154)
This is also done in #30395.

💬 ryanofsky commented on pull request "assumeutxo: Check snapshot base block is not in invalid chain":
(https://github.com/bitcoin/bitcoin/pull/30267#discussion_r1670879567)
re: https://github.com/bitcoin/bitcoin/pull/30267#discussion_r1663611194

> What is the point of translating this message when the translation is discarded? Seems wasteful of translator's time, no?

Removed translation in #30417

💬 ryanofsky commented on pull request "assumeutxo: Check snapshot base block is not in invalid chain":
(https://github.com/bitcoin/bitcoin/pull/30267#discussion_r1670880468)
re: https://github.com/bitcoin/bitcoin/pull/30267#discussion_r1663631973

> It is not possible to pass a raw c-string pointer to transifex for translation. Only string literals can be translated.

Fixed in #30417

💬 ryanofsky commented on pull request "assumeutxo: Check snapshot base block is not in invalid chain":
(https://github.com/bitcoin/bitcoin/pull/30267#discussion_r1670879771)
re: https://github.com/bitcoin/bitcoin/pull/30267#discussion_r1663647981

> Is the trailing newline needed? This would be the first `JSONRPCError` with a trailing newline.

Removed in #30417

💬 instagibbs commented on pull request "policy: Add PayToAnchor(P2A), `OP_TRUE <0x4e73>` as a standard output script for spending":
(https://github.com/bitcoin/bitcoin/pull/30352#discussion_r1670889699)
thanks, taken

💬 instagibbs commented on pull request "#28984 package rbf followups":
(https://github.com/bitcoin/bitcoin/pull/30295#discussion_r1670908419)
removed

💬 instagibbs commented on pull request "#28984 package rbf followups":
(https://github.com/bitcoin/bitcoin/pull/30295#discussion_r1670908464)
done

💬 instagibbs commented on pull request "#28984 package rbf followups":
(https://github.com/bitcoin/bitcoin/pull/30295#discussion_r1670908480)
done

💬 theStack commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218275587)
@mzumsande: Good catch! With that in my mind, I see the following paths forward:
1. Queue outbound VERSION message immediately in `CConnman::OpenNetworkConnection` (as done in a previous version of this PR: https://github.com/theStack/bitcoin/tree/202407-p2p-fix_selfdetection_racecond_oldversion, extending the `NetEventsInterface` with a new `SendInitialMessages` method, called at the end)
2. Adapt the current state of this PR to only start processing messages of outbound peers after `m_outbou
...

💬 dergoegge commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218287690)
Option 2. seems the best to me.