💬 DevAgrawal1112 commented on pull request "#24049 Issue: Update nScore datatype":
(https://github.com/bitcoin/bitcoin/pull/27386#issuecomment-1492981982)
@hebasto Yes, I had read previous discussions that are mention in [thread](https://github.com/bitcoin/bitcoin/pull/24090)

⚠️ Sjors opened an issue: "rpc: show P2(W)SH redeemScript in getrawtransaction (and friends)"
(https://github.com/bitcoin/bitcoin/issues/27391)
### Please describe the feature you'd like to see added.

I'd like to be able to get the (decompiled) P2SH `redeemScript` and P2WSH `witnessScript` when calling `getrawtransaction` and `getblock … 2`.

### Is your feature related to a problem, if so please describe it.

I found myself having a hard time counting sigops in the recently invalid block. For scriptPubKey it's easy:

```
# Raw OP_CHECKMULTISIG: 20 x 4 sigops each
bitcoin-cli getblock 00000000000000000002ec935e245f8ae70fc68cc828f05
...

🚀 hebasto merged a pull request: "Update translation source file for v25.0 string freeze"
(https://github.com/bitcoin-core/gui/pull/724)

💬 hebasto commented on pull request "Adjust plural forms for translations":
(https://github.com/bitcoin-core/gui/pull/716#issuecomment-1493123198)
Closed in favour of #724.

✅ hebasto closed a pull request: "Adjust plural forms for translations"
(https://github.com/bitcoin-core/gui/pull/716)

💬 hebasto commented on pull request "Translatability fixups":
(https://github.com/bitcoin-core/gui/pull/599#issuecomment-1493123474)
Most of commits from this PR were merged as a part of #724.

💬 Ayush170-Future commented on pull request "addrman, refactor: improve stochastic test in `AddSingle`":
(https://github.com/bitcoin/bitcoin/pull/27319#issuecomment-1493166757)
Yeah, the left shift should be faster than the iterative approach. Yet I'm not sure how much of an improvement it will make in terms of efficiency.

But, there are other instances in the same file where the Left shift is already being used for the same purpose. As a result, I see no point in continuing to use the current iterative method for calculating the power of two. It's better to change it for the sake of consistency and better practice.

👍 Ayush170-Future approved a pull request: "addrman, refactor: improve stochastic test in `AddSingle`"
(https://github.com/bitcoin/bitcoin/pull/27319)

✅ MarcoFalke closed an issue: "get block or transaction data via rpc api when in the ibd process"
(https://github.com/bitcoin/bitcoin/issues/27388)

🚀 fanquake merged a pull request: "net processing: #26140 follow-ups"
(https://github.com/bitcoin/bitcoin/pull/27379)

💬 fanquake commented on pull request "test: Remove python3.5 workaround":
(https://github.com/bitcoin/bitcoin/pull/27378#issuecomment-1493310359)
ACK fae66fceb3147385320593d1e15faf290b0f4caf

I agree. Not seeing any issues with this on macOS, so lets merge, and revisit if any issues occur.

🚀 fanquake merged a pull request: "test: Remove python3.5 workaround"
(https://github.com/bitcoin/bitcoin/pull/27378)

🚀 fanquake merged a pull request: "depends, doc: Document `NO_USDT` option"
(https://github.com/bitcoin/bitcoin/pull/27387)

✅ fanquake closed an issue: "miniscript: comparison of integers of different signs"
(https://github.com/bitcoin/bitcoin/issues/27381)

🚀 fanquake merged a pull request: "miniscript: explicit cast instead of comparing integers of different signs"
(https://github.com/bitcoin/bitcoin/pull/27382)

💬 furszy commented on pull request "wallet, gui: bugfix, getAvailableBalance skips selected coins":
(https://github.com/bitcoin/bitcoin/pull/26699#issuecomment-1493373583)
rebased, conflict solved.

💬 martinus commented on pull request "refactor: Make `CCheckQueue` RAII-styled":
(https://github.com/bitcoin/bitcoin/pull/26762#discussion_r1155335609)
I think that removing the lock here could cause a deadlock.
`m_request_stop` is set to true and then `notify_all()` is called; but when there is a worker thread currently standing inside the `while (queue.empty() && !m_request_stop) {` loop but before the `cond.wait(lock);` it will not receive the notification and then proceed to wait in the `cond` indefinitely.

That deadlock was not possible before when the `m_mutex` had to be acquired to change `m_request_stop`, because then it was guarant
...

💬 arnabnandikgp commented on issue "gen-manpages output depends on build options, so needs to check them":
(https://github.com/bitcoin/bitcoin/issues/17506#issuecomment-1493382262)
I am not able to understand exactly what this issue is trying to resolve..I have realised that the python script talked about here generates man-pages for each binary in the src/doc/man directory..but I am not able to understand what is meant by the documentation of arguments of build parameters...can anyone please explain me and clear my confusion regarding the same.

💬 vasild commented on pull request "p2p: skip netgroup diversity of new connections for tor/i2p/cjdns":
(https://github.com/bitcoin/bitcoin/pull/27374#discussion_r1155339537)
If this assert is hit, it means that somebody has added a new entry in `enum Network`, has forgotten to update this function, has ignored the compiler warning and has ignored the CI failure. Or a memory corruption has occurred and `CNetAddr::m_net` has been overwritten with random bytes. I think `assert(false)` is the appropriate response in both cases.

💬 jessebarton commented on pull request "doc: FreeBSD DataDirectoryGroupReadable Setting":
(https://github.com/bitcoin/bitcoin/pull/26741#issuecomment-1493388398)
This was my first time doing a squash commit. If it doesn't look right I can fix it. Appreciate the help.