💬 hebasto commented on pull request "depends, doc: Document `NO_USDT` option":
(https://github.com/bitcoin/bitcoin/pull/27387#issuecomment-1492892759)
cc @0xB10C

⚠️ DRAWCORE opened an issue: "get block or transaction data via rpc api when in the ibd process"
(https://github.com/bitcoin/bitcoin/issues/27388)
### Please describe the feature you'd like to see added.

Can I get the block or transaction data via the rpc api when the bitcoin core is still in the ibd process that has not been finished?
For example , can I get the downloaded block data via calling the `getblock` api while the client is still in the ibd process?

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

_No response_

### Describe any alternatives you've consi
...

💬 0xB10C commented on pull request "depends, doc: Document `NO_USDT` option":
(https://github.com/bitcoin/bitcoin/pull/27387#issuecomment-1492918821)
ACK c9aace2bfd180906d528cc2a80bc856685fbc6ca

This also removes a stray `</dd>` from the `NO_NATPMP` docs. Maybe worth mentioning in the OP?

Change looks good to me. I did **not** run a depends build with `NO_USDT` set to test it.

💬 hebasto commented on pull request "depends, doc: Document `NO_USDT` option":
(https://github.com/bitcoin/bitcoin/pull/27387#issuecomment-1492919632)
> This also removes a stray `</dd>` from the `NO_NATPMP` docs. Maybe worth mentioning in the OP?

Done.

> Change looks good to me. I did **not** run a depends build with `NO_USDT` set to test it.

FWIW, we use `NO_USDT` in our other docs:
```
$ git grep -l NO_USDT -- doc
doc/build-freebsd.md
doc/build-openbsd.md
doc/build-unix.md
```

💬 0xB10C commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-1492942181)
Had a brief look. The `mempoolrej` log message shows that we indeed rejected the transaction but the test didn't see the reject.

Can't reproduce this locally with about 20 test runs. All pass. Might be a CI timing problem then? Will try playing around with the `bpf.perf_buffer_poll()` timeout.

Will investigate further.

💬 pinheadmz commented on issue "get block or transaction data via rpc api when in the ibd process":
(https://github.com/bitcoin/bitcoin/issues/27388#issuecomment-1492949497)
Yes this should work, did you try it? Here's example commands starting bitcoind in a fresh datadir with `-txindex`:

```
--> bitcoin-cli -datadir=/home/pinheadmz/bcd-test getblockcount
400

--> bitcoin-cli -datadir=/home/pinheadmz/bcd-test getblock 000000007bc154e0fa7ea32218a72fe2c1bb9f86cf8c9ebf9a715ed27fdb229a
{
"hash": "000000007bc154e0fa7ea32218a72fe2c1bb9f86cf8c9ebf9a715ed27fdb229a",
"confirmations": 9282,
"strippedsize": 215,
"size": 215,
"weight": 860,
"height": 1
...

📝 theStack opened a pull request: "test: refactor: replace unnecessary `BytesIO` uses"
(https://github.com/bitcoin/bitcoin/pull/27389)
Rather than needing to create intermediate stream variables, we can use helper functions like `tx_from_hex` instead or access the result directly, leading both to increased readability and less code.

💬 0xB10C commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-1492956673)
Other CI runs with similar behavior:

- https://cirrus-ci.com/task/6650565413830656?logs=ci#L3531

💬 0xB10C commented on issue "CI, tracing: run tracepoint interface tests in the CI":
(https://github.com/bitcoin/bitcoin/issues/24782#issuecomment-1492963404)
The up coming Ubuntu 23.04 seems to be shipping with an up-to-date bpfcc: https://packages.ubuntu.com/lunar/python3-bpfcc

💬 0xB10C commented on pull request "Move log messages: tx enqueue to mempool, allocation to blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27277#issuecomment-1492964604)
> CI network error https://cirrus-ci.com/task/4864754720702464?logs=ci#L61:
>
> `TimeoutError: [Errno 110] Connection timed out`

Note: The failed connections seems to be to the launchpad.net PPA with a newer bpfcc. Not using this newer PPA to install an up-to-date `bpfcc` causes warnings printed to stderr which means `interface_usdt_coinselection.py` is treated as failed. (The up-coming Ubuntu lunar seems to include an up-to-date bpfcc).

💬 DRAWCORE commented on issue "get block or transaction data via rpc api when in the ibd process":
(https://github.com/bitcoin/bitcoin/issues/27388#issuecomment-1492968313)
> Yes this should work, did you try it? Here's example commands starting bitcoind in a fresh datadir with `-txindex`:
>
> ```
> --> bitcoin-cli -datadir=/home/pinheadmz/bcd-test getblockcount
> 400
>
> --> bitcoin-cli -datadir=/home/pinheadmz/bcd-test getblock 000000007bc154e0fa7ea32218a72fe2c1bb9f86cf8c9ebf9a715ed27fdb229a
> {
> "hash": "000000007bc154e0fa7ea32218a72fe2c1bb9f86cf8c9ebf9a715ed27fdb229a",
> "confirmations": 9282,
> "strippedsize": 215,
> "size": 215,
> "we
...

💬 pinheadmz commented on issue "get block or transaction data via rpc api when in the ibd process":
(https://github.com/bitcoin/bitcoin/issues/27388#issuecomment-1492970384)
Yes with the rpc you can access anything that you have already downloaded

💬 DevAgrawal1112 commented on pull request "#24049 Issue: Update nScore datatype":
(https://github.com/bitcoin/bitcoin/pull/27386#issuecomment-1492981982)
@hebasto Yes, I had read previous discussions that are mention in [thread](https://github.com/bitcoin/bitcoin/pull/24090)

⚠️ Sjors opened an issue: "rpc: show P2(W)SH redeemScript in getrawtransaction (and friends)"
(https://github.com/bitcoin/bitcoin/issues/27391)
### Please describe the feature you'd like to see added.

I'd like to be able to get the (decompiled) P2SH `redeemScript` and P2WSH `witnessScript` when calling `getrawtransaction` and `getblock … 2`.

### Is your feature related to a problem, if so please describe it.

I found myself having a hard time counting sigops in the recently invalid block. For scriptPubKey it's easy:

```
# Raw OP_CHECKMULTISIG: 20 x 4 sigops each
bitcoin-cli getblock 00000000000000000002ec935e245f8ae70fc68cc828f05
...

🚀 hebasto merged a pull request: "Update translation source file for v25.0 string freeze"
(https://github.com/bitcoin-core/gui/pull/724)

💬 hebasto commented on pull request "Adjust plural forms for translations":
(https://github.com/bitcoin-core/gui/pull/716#issuecomment-1493123198)
Closed in favour of #724.

✅ hebasto closed a pull request: "Adjust plural forms for translations"
(https://github.com/bitcoin-core/gui/pull/716)

💬 hebasto commented on pull request "Translatability fixups":
(https://github.com/bitcoin-core/gui/pull/599#issuecomment-1493123474)
Most of commits from this PR were merged as a part of #724.

💬 Ayush170-Future commented on pull request "addrman, refactor: improve stochastic test in `AddSingle`":
(https://github.com/bitcoin/bitcoin/pull/27319#issuecomment-1493166757)
Yeah, the left shift should be faster than the iterative approach. Yet I'm not sure how much of an improvement it will make in terms of efficiency.

But, there are other instances in the same file where the Left shift is already being used for the same purpose. As a result, I see no point in continuing to use the current iterative method for calculating the power of two. It's better to change it for the sake of consistency and better practice.

👍 Ayush170-Future approved a pull request: "addrman, refactor: improve stochastic test in `AddSingle`"
(https://github.com/bitcoin/bitcoin/pull/27319)