💬 willcl-ark commented on pull request "contrib: Fixup verify-binaries OS platform parsing":
(https://github.com/bitcoin/bitcoin/pull/30147#issuecomment-2137090343)
Here is the file I was using to check the new parsing

<details>
<summary>Details</summary>

```python
#!/usr/bin/env python3

import tempfile
from verify import parse_version_string, parse_sums_file

SHASUMS = """cb35e250ae9d0328aa90e7aad0b877ed692597420a1092e8ab1a5dd756209722 bitcoin-27.0-aarch64-linux-gnu.tar.gz
9d4c28e7620d03bf346ebea388f222e4d6d2b996d7eb32fab72707b8320d5249 bitcoin-27.0-arm-linux-gnueabihf.tar.gz
7f060f2cd07746ff9d09b000b4195fee88dfca8444ab7a73f0c76aff4225227
...

📝 fanquake opened a pull request: "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE"
(https://github.com/bitcoin/bitcoin/pull/30189)
Supposedly this is no-longer needed (and hasn't been ported to CMake), so remove it's usage here. Oringinally used to suppress warnings about deprecated/removed from the standard functioanlity, which was still supported by some compilers.

🤔 MaxJitphanu reviewed a pull request: "net: Replace libnatpmp with built-in PCP+NATPMP implementation"
(https://github.com/bitcoin/bitcoin/pull/30043#pullrequestreview-2085053341)
1

💬 maflcko commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137148183)
Did you test this with the minimum required boost version 1.71?

💬 fanquake commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137156339)
> Did you test this with the minimum required boost version 1.71?

Only with 1.81.0. (depends) which still has the problematic behaviour. Used a CMake CI (which has already dropped this) with Boost 1.73.0 as a proxy for anything lower (https://github.com/hebasto/bitcoin/actions/runs/9257726144/job/25466464660).

💬 brunoerg commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1618702221)
Much better, I will update it. I think it's worth updating `getpeerinfo` too.

💬 maflcko commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137176328)
The cmake run is using g++-11, but g++-12 is required according to https://github.com/boostorg/config/pull/430/files

💬 fanquake commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137183165)
@hebasto how did you test this macro is no-longer required in the CMake build (given it wasn't ported)?

💬 hebasto commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137188611)
> @hebasto how did you test this macro is no-longer required in the CMake build (given it wasn't ported)?

https://github.com/hebasto/bitcoin/actions/runs/9283914497

💬 hebasto commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137192595)
> Did you test this with the minimum required boost version 1.71?

It is 1.73 since https://github.com/bitcoin/bitcoin/pull/29066.

🤔 BrandonOdiwuor reviewed a pull request: "test: improve BDB parser (handle internal/overflow pages, support all page sizes)"
(https://github.com/bitcoin/bitcoin/pull/30125#pullrequestreview-2085148866)
Concept ACK

💬 hebasto commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137202507)
Concept ACK.

💬 maflcko commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137223724)
Looks like 880d4aaf81f3d5d7fbb915905c2e61b816a6a747 affected depends, not sure if it even reproduces outside of that?

💬 maflcko commented on pull request "build: remove usage of DBOOST_NO_CXX98_FUNCTION_BASE":
(https://github.com/bitcoin/bitcoin/pull/30189#issuecomment-2137249188)
I could only reproduce inside of depends, which has boost 1.81, which is fixed, so LGTM, I guess. :shrug:

⚠️ kosuodhmwa opened an issue: "Where is the bitcoin.conf file located?"
(https://github.com/bitcoin/bitcoin/issues/30190)
can't find it on ~/bitcoin - and also not in its subdirectories.

Do i need to create it in ~/bitcoin/src (if the "bitcoind" executable is located there after compilation, as in my case).

Thank you very much for your feedback(s).

💬 kosuodhmwa commented on issue "Where is the bitcoin.conf file located?":
(https://github.com/bitcoin/bitcoin/issues/30190#issuecomment-2137307322)
or do i need to create it in the hidden bitcoind data directory on ~/.bitcoin ?

it also not exists there so it seems

💬 vasild commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1618807661)
On my Linux distro I have:

```cpp
struct nlmsghdr {
__u32 nlmsg_len;
...
#define NLMSG_OK(nlh,len) ((len) >= (int)sizeof(struct nlmsghdr) && \
(nlh)->nlmsg_len >= sizeof(struct nlmsghdr) && \
(nlh)->nlmsg_len <= (len))
```
So, the second argument of `NLMSG_OK()` - `len` is compared against 1. `(int)sizeof...` and 2. `...->nlmsg_len` (which is `__u32`). The only difference on FreeBSD is that in 2. it is c
...

👋 fanquake's pull request is ready for review: "build: remove usage of BOOST_NO_CXX98_FUNCTION_BASE"
(https://github.com/bitcoin/bitcoin/pull/30189)

💬 cbergqvist commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1618814697)
Added `std::conditional_t<(BITS <= 16), bitset_detail::IntBitSet<uint16_t>, ... ` and removed the `I()`, wrote unit test in bc36241f5a0a23d16645155eb819e94b0db2813e, and it indeed proves you are correct. Right now it cannot occur since `IntBitSet<uint32_t>` is the smallest we go, but better not to leave loaded footguns lying around.

<details>
<summary>Test Log</summary>

```
$ src/test/test_bitcoin -t bitset_tests
...
Running 1 test case...
test/bitset_tests.cpp(18): error: in "bitset_
...

💬 maflcko commented on issue "Where is the bitcoin.conf file located?":
(https://github.com/bitcoin/bitcoin/issues/30190#issuecomment-2137323745)
Does https://github.com/bitcoin/bitcoin/blob/master/doc/files.md help?