💬 edilmedeiros commented on pull request "doc: Update mentions of generating bitcoin.conf":
(https://github.com/bitcoin/bitcoin/pull/30154#discussion_r1610761009)
I don't like this change that much since this hardens the logical link between this file and `contrib/devtools/README.md` without any kind of automation to check if e.g. the section `gen-bitcoin-conf.sh` still exist.

💬 edilmedeiros commented on pull request "depends: Fetch miniupnpc sources from an alternative website":
(https://github.com/bitcoin/bitcoin/pull/30151#issuecomment-2125912025)
> > > Which one? http://miniupnp.free.fr/ without HTTPS?
> >
> >
> > If that does keep the sha256 hash the same then maybe.
>
> It does. Switched to that website.

This is the same URL I used to update the MacOS package in the macports project a couple of months ago, so there will be more people watching it.

🤔 luke-jr requested changes to a pull request: "Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection"
(https://github.com/bitcoin-core/gui/pull/815#pullrequestreview-2072577992)
I'm pretty sure you can just modify the existing line in `setWalletActionsEnabled` to:

```c++
historyAction->setEnabled(enabled && !isPrivacyModeActivated());
```

💬 luke-jr commented on pull request "Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection":
(https://github.com/bitcoin-core/gui/pull/815#discussion_r1610785803)
Why move this up top? Now it's after the signal is connected, so there's a tiny chance of a race...

💬 luke-jr commented on pull request "Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection":
(https://github.com/bitcoin-core/gui/pull/815#discussion_r1610789375)
This shouldn't be necessary.

💬 luke-jr commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#discussion_r1610799043)
nit

```suggestion
virtual std::map<CNetAddr, LocalServiceInfo> getNetLocalAddresses() = 0;
```

💬 luke-jr commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#discussion_r1610802187)
AFAIK Tor hidden services do still have port numbers

💬 luke-jr commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#issuecomment-2125971142)
Also, please split the interfaces changes into a different commit than the GUI changes.

💬 hernanmarino commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-2125972389)
> Needs rebase (for some reason Drahtbot isn't detecting this)

Rebased. Also deleted a couple of redundant comment as suggested by @maflcko to retrigger the false negative CI

💬 furszy commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#discussion_r1610809735)
why restart if you aren't doing anything with the node?

💬 theStack commented on pull request "improve MallocUsage() accuracy":
(https://github.com/bitcoin/bitcoin/pull/28531#issuecomment-2125983180)
@LarryRuane: Interesting problem (and very creative solution with the RBF tx :)). Fwiw, on one of my machines running OpenBSD 7.5, the same behaviour as you described occurs on commit 663e5012d318a7e80a42385ac4e6f71dec46814e: after `fill_mempool`, mempool usage is very close to the max (`'usage': 4998768`), and the subtest `test_mid_package_eviction` fails on the first MiniWallet tx submission with a `"mempool full"` error.

One idea I had to solve this at the `fill_mempool` side is to submit
...

💬 luke-jr commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#issuecomment-2126022528)
Might be a good improvement to cherry-pick [e4fddc9f395819d0bdf74003676aa563929756fa](https://github.com/luke-jr/bitcoin-core-gui/commit/e4fddc9f395819d0bdf74003676aa563929756fa) and use it to update; in testing, I found myself watching for None to change, but it never did because the string isn't updated.

💬 luke-jr commented on pull request "init: Add option for rpccookie permissions (replace 26088)":
(https://github.com/bitcoin/bitcoin/pull/28167#issuecomment-2126029671)
QA failed

💬 sipa commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2126064090)
Success! My node is reachable publicly, without configuration.

```
2024-05-23T02:06:39.536932Z [net] pcp: gateway [IPv4]: 192.168.1.1
2024-05-23T02:06:39.536973Z [net] pcp: Requesting port mapping for addr 0.0.0.0 port 8333 from gateway 192.168.1.1
2024-05-23T02:06:39.537027Z [net] pcp: Internal address after connect: 192.168.1.254
...
2024-05-23T02:06:39.538066Z [net] pcp: Received response of 8 bytes: [...]
2024-05-23T02:06:39.538101Z [net] pcp: Got unsupported version response, falli
...

✅ BenWestgate closed a pull request: "contrib: Fixup verify-binaries OS platform parsing"
(https://github.com/bitcoin/bitcoin/pull/30147)

📝 BenWestgate reopened a pull request: "contrib: Fixup verify-binaries OS platform parsing"
(https://github.com/bitcoin/bitcoin/pull/30147)
Closes #30145.

This PR solves two major issues in the `parse_version_string` function of verify-binaries:
1. `-aarch64` binaries cannot be specifically downloaded. The -platform string gets interpreted as a release candidate that doesn't exist due to containing sub-string "rc".
2. Specifying a platform with a "-" in the name causes the parser to ignore both "-platform" AND "-rcN" and download the potentially wrong (non-rc) version for every platform. This also prevented specifying just one
...

💬 Sohanking1 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2126196798)
I want to get Bitcoin or usdt Flash
If you have so please contact me

https://t.me/Sohan20001

💬 BenWestgate commented on pull request "contrib: Fixup verify-binaries OS platform parsing":
(https://github.com/bitcoin/bitcoin/pull/30147#issuecomment-2126211903)
> Merge commits in pull requests are discouraged in this repo, please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

Done.

👋 BenWestgate's pull request is ready for review: "contrib: Fixup verify-binaries OS platform parsing"
(https://github.com/bitcoin/bitcoin/pull/30147)

💬 laanwj commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2126357008)
> Success! My node is reachable publicly, without configuration.

Nice!!! Thanks for testing again.