💬 TheCharlatan commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#discussion_r1608966851)
Thanks, fixed.

💬 brunoerg commented on pull request "net: add ASMap info in `getrawaddrman` RPC":
(https://github.com/bitcoin/bitcoin/pull/30062#discussion_r1608973068)
I agree, will address it.

💬 brunoerg commented on pull request "net: add ASMap info in `getrawaddrman` RPC":
(https://github.com/bitcoin/bitcoin/pull/30062#discussion_r1608973314)
I agree, I will address it.

💬 hernanmarino commented on pull request "Correct tooltip wording for watch-only wallets":
(https://github.com/bitcoin-core/gui/pull/792#issuecomment-2123499470)
> @hernanmarino
>
> Are you still working on this?

I am active, and I'll resume working on this PR and upload a proposal soon.

💬 theStack commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1608997512)
nit: would still prefer `last_txid` over `last_hash` as it's more expressive (OTOH, in `COutPoint`, it's also called `hash`)

👍 theStack approved a pull request: "rpc: Optimize serialization and enhance metadata of dumptxoutset output"
(https://github.com/bitcoin/bitcoin/pull/29612#pullrequestreview-2069701481)
ACK 542e13b2937356810bda2c41be83c3b1675e2f2f

👋 LarryRuane's pull request is ready for review: "improve MallocUsage() accuracy"
(https://github.com/bitcoin/bitcoin/pull/28531)

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609088929)
not sure why it is doing that I will check the script to see why

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609089600)
that is strange I would think that the 3rd arg would make the tests fail in this case

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#issuecomment-2123638147)
> @kevkevinpal Did you use a tool to generate the verification script?

No I did not I just manually used `git grep` and `sed` to create the script

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#issuecomment-2123662957)
rebased to [7f7dc43](https://github.com/bitcoin/bitcoin/pull/29500/commits/7f7dc439c7d268e63eddddf3cea21c2931895078)

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609112805)
Yes that would not make sense let me see if I can improve the logging here

💬 kristapsk commented on pull request "cli: restrict multiple exclusive argument usage in bitcoin-cli":
(https://github.com/bitcoin/bitcoin/pull/30148#issuecomment-2123674336)
Concept ACK

💬 edilmedeiros commented on pull request "contrib/signet/miner: increase miner search space":
(https://github.com/bitcoin/bitcoin/pull/30130#issuecomment-2123743474)
Fair enough, committed the style suggestions.

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609172911)
I've updated this to instead only take three arguments and the last one being an optional message since I did not see anywhere we were already asserting `!=` in a chain.

This should clear up the message and allow the one location we do use a message to be used

updated in [4488120](https://github.com/bitcoin/bitcoin/pull/29500/commits/4488120ab7db775ce0ae8a73f910dddca1dee123)

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609173422)
I've updated the function to not accept the `args` param since it did not seem to be needed and instead allowed an optional 3rd param as the message

updated in [4488120](https://github.com/bitcoin/bitcoin/pull/29500/commits/4488120ab7db775ce0ae8a73f910dddca1dee123)

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609177324)
fixed in [4358c6e](https://github.com/bitcoin/bitcoin/pull/29500/commits/4358c6e7221eed21d9cf78ead5cabd6982fb9a03)

thanks for the review!

📝 achow101 opened a pull request: "contrib: Renew Windows code signing certificate"
(https://github.com/bitcoin/bitcoin/pull/30149)
Renewed the Windows code signing certificate for another 3 years.

🤔 vasild reviewed a pull request: "build: Remove `--enable-threadlocal`"
(https://github.com/bitcoin/bitcoin/pull/30137#pullrequestreview-2070106741)
ACK 17fe948cce2eb75f0f3f4b0db9d0d90648c7d4af

💬 vasild commented on pull request "build: Remove `--enable-threadlocal`":
(https://github.com/bitcoin/bitcoin/pull/30137#discussion_r1609265987)
With this it will be possible to remove `export NOWARN_CXXFLAGS="-Wno-error=unreachable-code"` from dev environment on FreeBSD, thanks!