💬 hebasto commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111650447)
I believe, that was a bug in the Wine package that has been fixed -- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917307.
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111650447)
I believe, that was a bug in the Wine package that has been fixed -- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917307.
💬 emsit commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111655985)
> @Sjors [wrote](https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2056345622):
>
> > If anyone wants to deploy a faucet, let me know and I'll send some coins... unless someone reorgs me.
>
> Yes, I'd be happy to set up a Testnet4 faucet similar to [Alt Signet Faucet](https://alt.signetfaucet.com/). Please send me some testnet coins to `tb1p4tp4l6glyr2gs94neqcpr5gha7344nfyznfkc8szkreflscsdkgqsdent4` on [Testnet4](https://mempool.space/testnet4/address/tb1p4tp4l6glyr2gs94neqc
...
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111655985)
> @Sjors [wrote](https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2056345622):
>
> > If anyone wants to deploy a faucet, let me know and I'll send some coins... unless someone reorgs me.
>
> Yes, I'd be happy to set up a Testnet4 faucet similar to [Alt Signet Faucet](https://alt.signetfaucet.com/). Please send me some testnet coins to `tb1p4tp4l6glyr2gs94neqcpr5gha7344nfyznfkc8szkreflscsdkgqsdent4` on [Testnet4](https://mempool.space/testnet4/address/tb1p4tp4l6glyr2gs94neqc
...
💬 hebasto commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111656619)
I found that the test case error messages are quite similar to ones reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917307. That bug has been fixed as well.
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111656619)
I found that the test case error messages are quite similar to ones reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917307. That bug has been fixed as well.
💬 0xB10C commented on issue "ci: Enable bpfcc-tools":
(https://github.com/bitcoin/bitcoin/issues/29804#issuecomment-2111699235)
https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/
(https://github.com/bitcoin/bitcoin/issues/29804#issuecomment-2111699235)
https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/
💬 nickguo commented on issue "Performance decrease after tapscript miniscript":
(https://github.com/bitcoin/bitcoin/issues/29098#issuecomment-2111705890)
Hello, is anyone actively working on this? -- and if not, would this be an appropriate "good first issue"?
(https://github.com/bitcoin/bitcoin/issues/29098#issuecomment-2111705890)
Hello, is anyone actively working on this? -- and if not, would this be an appropriate "good first issue"?
💬 eriknylund commented on issue "Performance decrease after tapscript miniscript":
(https://github.com/bitcoin/bitcoin/issues/29098#issuecomment-2111726566)
> Hello, is anyone actively working on this? -- and if not, would this be an appropriate "good first issue"?
@darosior replied to my open PR that he has no plans to implement right now (see https://github.com/bitcoin/bitcoin/pull/28212#issuecomment-2045410857), so afaik no one is actively working on this. I can't say if it's a good first issue, but I would be happy to help with review in combination with my 999-of-999 tests if you want to have a go at it. ❤️
(https://github.com/bitcoin/bitcoin/issues/29098#issuecomment-2111726566)
> Hello, is anyone actively working on this? -- and if not, would this be an appropriate "good first issue"?
@darosior replied to my open PR that he has no plans to implement right now (see https://github.com/bitcoin/bitcoin/pull/28212#issuecomment-2045410857), so afaik no one is actively working on this. I can't say if it's a good first issue, but I would be happy to help with review in combination with my 999-of-999 tests if you want to have a go at it. ❤️
💬 jsarenik commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111731892)
> I shared with you, the world is small 😃 ![]
Thank you! One new testnet4 faucet running at https://testnet4.anyone.eu.org/
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111731892)
> I shared with you, the world is small 😃 ![]
Thank you! One new testnet4 faucet running at https://testnet4.anyone.eu.org/
👋 maflcko's pull request is ready for review: "ci: Roll clang in test-each-commit task"
(https://github.com/bitcoin/bitcoin/pull/30060)
(https://github.com/bitcoin/bitcoin/pull/30060)
💬 maflcko commented on pull request "ci: Roll clang in test-each-commit task":
(https://github.com/bitcoin/bitcoin/pull/30060#issuecomment-2111827640)
rebased to fix commit hashes :see_no_evil:
(https://github.com/bitcoin/bitcoin/pull/30060#issuecomment-2111827640)
rebased to fix commit hashes :see_no_evil:
💬 maflcko commented on issue "ci: Enable bpfcc-tools":
(https://github.com/bitcoin/bitcoin/issues/29804#issuecomment-2111834677)
Is someone interested in moving the asan task over to GHA now?
cc @m3dwards
(https://github.com/bitcoin/bitcoin/issues/29804#issuecomment-2111834677)
Is someone interested in moving the asan task over to GHA now?
cc @m3dwards
👍 hebasto approved a pull request: "ci: Roll clang in test-each-commit task"
(https://github.com/bitcoin/bitcoin/pull/30060#pullrequestreview-2057221891)
re-ACK fa90ad23c0cb99bde305af156c978c066f7bacb8.
(https://github.com/bitcoin/bitcoin/pull/30060#pullrequestreview-2057221891)
re-ACK fa90ad23c0cb99bde305af156c978c066f7bacb8.
💬 maflcko commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111844845)
utACK df879e5a91134a67ada3167ebff4e87f163b81a9
Seems reasonable to assume that this was a wine issue, or another issue that is now fixed.
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111844845)
utACK df879e5a91134a67ada3167ebff4e87f163b81a9
Seems reasonable to assume that this was a wine issue, or another issue that is now fixed.
✅ fanquake closed a pull request: "init: Fixes for file descriptor accounting"
(https://github.com/bitcoin/bitcoin/pull/27539)
(https://github.com/bitcoin/bitcoin/pull/27539)
💬 fanquake commented on pull request "init: Fixes for file descriptor accounting":
(https://github.com/bitcoin/bitcoin/pull/27539#issuecomment-2111853223)
Closing for now, re #30065.
(https://github.com/bitcoin/bitcoin/pull/27539#issuecomment-2111853223)
Closing for now, re #30065.
💬 maflcko commented on issue "Restore wallet taking forever to load":
(https://github.com/bitcoin/bitcoin/issues/30108#issuecomment-2111855234)
Is it busy with IO or is the CPU busy? It could also be useful to attach gdb to get a stacktrace.
(https://github.com/bitcoin/bitcoin/issues/30108#issuecomment-2111855234)
Is it busy with IO or is the CPU busy? It could also be useful to attach gdb to get a stacktrace.
💬 fanquake commented on pull request "init: fixes file descriptor accounting":
(https://github.com/bitcoin/bitcoin/pull/30065#discussion_r1601187564)
I think now could also be the time to remove this FreeBSD workaround. It was needed because older versions of FreeBSD, used to ship with an old Clang (3.x). However we now require Clang 15+, and the effected version of FreeBSD 10.x, is long EOL.
(https://github.com/bitcoin/bitcoin/pull/30065#discussion_r1601187564)
I think now could also be the time to remove this FreeBSD workaround. It was needed because older versions of FreeBSD, used to ship with an old Clang (3.x). However we now require Clang 15+, and the effected version of FreeBSD 10.x, is long EOL.
🚀 fanquake merged a pull request: "ci: Roll clang in test-each-commit task"
(https://github.com/bitcoin/bitcoin/pull/30060)
(https://github.com/bitcoin/bitcoin/pull/30060)
💬 maflcko commented on pull request "[DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP":
(https://github.com/bitcoin/bitcoin/pull/29790#issuecomment-2112000903)
If the CI uses the same patterns that end-users will use, that is ideal. If it does not, then it is fine, too.
(https://github.com/bitcoin/bitcoin/pull/29790#issuecomment-2112000903)
If the CI uses the same patterns that end-users will use, that is ideal. If it does not, then it is fine, too.
💬 TheCharlatan commented on pull request "[refactor] Check CTxMemPool options in ctor":
(https://github.com/bitcoin/bitcoin/pull/28830#issuecomment-2112006683)
Rebased d447bdcfb0e38353940e4a7fc89d09482d8d39c3 -> dacdb7962c5fef8db26f6fa31facb606165d1d1e ([mempoolArgs_6](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_6) -> [mempoolArgs_7](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_7), [compare](https://github.com/TheCharlatan/bitcoin/compare/mempoolArgs_6..mempoolArgs_7))
* Fixed conflict with https://github.com/bitcoin/bitcoin/pull/29086
(https://github.com/bitcoin/bitcoin/pull/28830#issuecomment-2112006683)
Rebased d447bdcfb0e38353940e4a7fc89d09482d8d39c3 -> dacdb7962c5fef8db26f6fa31facb606165d1d1e ([mempoolArgs_6](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_6) -> [mempoolArgs_7](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_7), [compare](https://github.com/TheCharlatan/bitcoin/compare/mempoolArgs_6..mempoolArgs_7))
* Fixed conflict with https://github.com/bitcoin/bitcoin/pull/29086
👍 brunoerg approved a pull request: "p2p: detect addnode cjdns peers in GetAddedNodeInfo()"
(https://github.com/bitcoin/bitcoin/pull/30085#pullrequestreview-2057456926)
crACK d0b047494c28381942c09d0cca45baa323bfcffc
(https://github.com/bitcoin/bitcoin/pull/30085#pullrequestreview-2057456926)
crACK d0b047494c28381942c09d0cca45baa323bfcffc