💬 jonatack commented on pull request "lint: fixed typo in test_runner causing linter warning":
(https://github.com/bitcoin/bitcoin/pull/30106#issuecomment-2111412705)
See #30084.

💬 jonatack commented on pull request "contrib: lief updates":
(https://github.com/bitcoin/bitcoin/pull/30084#issuecomment-2111413331)
> If anything, I think the docs could be updated in some way to say that running the linters outside the container, or with versions that differ from the CI is generally unsupported.

Thanks for the feedback, will update.

✅ kevkevinpal closed a pull request: "lint: fixed typo in test_runner causing linter warning"
(https://github.com/bitcoin/bitcoin/pull/30106)

💬 kevkevinpal commented on pull request "lint: fixed typo in test_runner causing linter warning":
(https://github.com/bitcoin/bitcoin/pull/30106#issuecomment-2111420940)
> See #30084.

nice! closing in favor of https://github.com/bitcoin/bitcoin/pull/30084.

💬 andrewtoth commented on pull request "Drop -dbcache limit":
(https://github.com/bitcoin/bitcoin/pull/28358#issuecomment-2111425877)
> The only time -dbcache is filled beyond its previous 16GB limit is during IDB

I'm sure it will happen if you restart your node now and leave it running for long enough ;)

> In order to benefit from having the full UTXO set in RAM after a restart, we'd have to proactively load the entire UTXO set into -dbcache if space permits.

I did make a crude attempt at that years ago https://github.com/bitcoin/bitcoin/pull/18941. Not sure it is worth it.

💬 kevkevinpal commented on pull request "refactor: simplify `FormatSubVersion` using strprintf/Join":
(https://github.com/bitcoin/bitcoin/pull/30098#issuecomment-2111441030)
utACK https://github.com/bitcoin/bitcoin/pull/30084.

🤔 tdb3 reviewed a pull request: "test: Added test to ensure log and failure happen when work is less than active chainstate"
(https://github.com/bitcoin/bitcoin/pull/30105#pullrequestreview-2056736096)
Concept ACK

Thanks. It's great to add test coverage. Left a question.

💬 tdb3 commented on pull request "test: Added test to ensure log and failure happen when work is less than active chainstate":
(https://github.com/bitcoin/bitcoin/pull/30105#discussion_r1600847551)
Made a temporary modification of a word in the expected message (of `feature_assumeutxo.py` to test that a mismatch would be caught (it was, as expected). Restored to original expected message then modified the message in `validation.cpp`. This mismatch was also detected (as expected)l.

https://github.com/bitcoin/bitcoin/blob/695d80126f75a99c80d5d6c18ebaaabf7410b989/src/validation.cpp#L5659

The default timeout for `assert_debug_log()` is 2 seconds. I haven't had a chance to dig deeper y
...

💬 tdb3 commented on pull request "test: Added test to ensure log and failure happen when work is less than active chainstate":
(https://github.com/bitcoin/bitcoin/pull/30105#discussion_r1600849721)
Also made a temporary modification to this expected message. Mismatch was caught (as expected).

⚠️ jonjonez opened an issue: "Restore wallet taking forever to load"
(https://github.com/bitcoin/bitcoin/issues/30108)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [X] I still think this issue should be opened here

### Report

For some time now, I've been experiencing unusual slowdowns in Bitcoin Core, such as spending a long time without connecting to other pairs on the network and recently, I can't recover a wallet I want in the "restore wallet" option, it keeps loading for hours and never actually restores, this was never happening in Linux (ubuntu.
...

💬 fanquake commented on pull request "build: LLD based macOS toolchain":
(https://github.com/bitcoin/bitcoin/pull/21778#issuecomment-2111552513)
Guix build (aarch64):
```bash
cf99b6597c64c4d0cd75176d261a53f24779e8c3dbe9e891d9d166ae9d00d182 guix-build-f58a8678957e/output/aarch64-linux-gnu/SHA256SUMS.part
922e38e2b1a091f20caa014600936689fb9f14bf56fbd80e4c836c518897ff1f guix-build-f58a8678957e/output/aarch64-linux-gnu/bitcoin-f58a8678957e-aarch64-linux-gnu-debug.tar.gz
256c68e14a905aa6933a2dc83cad636a14ee99ac4661a287e7817efe421965ab guix-build-f58a8678957e/output/aarch64-linux-gnu/bitcoin-f58a8678957e-aarch64-linux-gnu.tar.gz
50eafd
...

💬 fanquake commented on pull request "util: avoid using thread_local variable that has a destructor":
(https://github.com/bitcoin/bitcoin/pull/30095#discussion_r1600922285)
Seems like a weird comment to add without specfic/obvious motivation, and doesn't prevent the same thing from happening elsewhere in the codebase?

🚀 fanquake merged a pull request: "refactor: simplify `FormatSubVersion` using strprintf/Join"
(https://github.com/bitcoin/bitcoin/pull/30098)

💬 fanquake commented on pull request "crypto: disable asan for sha256_sse4 with clang and -O0":
(https://github.com/bitcoin/bitcoin/pull/30097#issuecomment-2111604544)
> Upstream issue filed here: https://github.com/llvm/llvm-project/issues/92182

Thanks. Could you like to that thread from the comment added to the source, then this is probably good to go.

💬 jsarenik commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111605326)
@Sjors [wrote](https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2056345622):
> If anyone wants to deploy a faucet, let me know and I'll send some coins... unless someone reorgs me.

Yes, I'd be happy to set up a Testnet4 faucet similar to [Alt Signet Faucet](https://alt.signetfaucet.com/). Please send me some testnet coins to `tb1p4tp4l6glyr2gs94neqcpr5gha7344nfyznfkc8szkreflscsdkgqsdent4` on [Testnet4](https://mempool.space/testnet4/address/tb1p4tp4l6glyr2gs94neqcpr5gha7344nfyznfkc
...

💬 fanquake commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111607875)
> It is hard to say because https://github.com/bitcoin/bitcoin/commit/188ca75e5fe4837d16241446558c7566912f67b2 refers to the mentioned test case only. There was no links to any upstream issues.

What did you find in the mingw-w64 / GCC changelogs?

>> Erm, as of what version? Or what fix? We need more info here to be able to have any confidence.

> there are no evidences that the [test case](https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605) fails for any supported platform.
...

💬 jsarenik commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1600961392)
Could one possibly test with `-noconnect`, i.e. without connecting to the network and getting any other than genesis testnet4 block?

💬 fanquake commented on pull request "util: avoid using thread_local variable that has a destructor":
(https://github.com/bitcoin/bitcoin/pull/30095#issuecomment-2111609858)
> My understanding is that it is safe to use thread_local on FreeBSD for variables that do not have a destructor

So if we are moving forward with this assumption, what is preventing these kinds of variables being reintroduced (elsewhere) into the codebase? I'd rather `thread_local` be safe to use (in all circumstance) on a platform, or we just not use it.

This change feels a bit odd/forced because it's basically opting back into `thread_local`, but only certain usage/uncertain assumption
...

💬 emsit commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111634889)
If someone has coins they don't need, they can also donate them to the donate address of the faucet: [https://coinfaucet.eu/en/btc-testnet4/](url)

**tb1qn9rvr53m7qvrpysx48svuxsgahs88xfsskx367**

💬 hebasto commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111643871)
Please note, that the test case fails when running a Windows binary `a.exe` on Ubuntu 14.04 LTS. It is reasonable to assume that it uses packages `wine-binfmt` and `wine`.

The error messages like "err:ntdll:RtlpWaitForCriticalSection section 0x100a8 "heap.c: main process heap section" wait timed out in thread 0064, blocked by 0055, retrying (60 sec)" are specific to the Wine runtime. For example, https://www.winehq.org/pipermail/wine-devel/2003-January/013655.html.

My point is that the htt
...