💬 hebasto commented on pull request "guix: use GCC tool wrappers":
(https://github.com/bitcoin/bitcoin/pull/27345#issuecomment-1485223946)
Concept ACK.

💬 pinheadmz commented on issue "Inconsistent RPC error handling":
(https://github.com/bitcoin/bitcoin/issues/19087#issuecomment-1485227709)
The inconsistencies between single / batch RPCs are addressed in https://github.com/bitcoin/bitcoin/pull/27101 which adds a stricter jsonrpc 2.0 behavior when requested by the client (by adding `"jsonrpc": "2.0"` to the request object). In particular, we try to always return `HTTP 200 OK` unless there actually is a server error.

That PR does not affect the whitelist / authorization processing which looks like, in this discussion, is decidedly acceptable.

@Kixunil and @JeremyRubin are you
...

💬 fanquake commented on issue "depends does not compile with clang-16 (fontconfig)":
(https://github.com/bitcoin/bitcoin/issues/27299#issuecomment-1485231281)
> Maybe fontconfig can also be worked around with something like

Yea, looks like doing the same as qrencode, without a package bump, is going to be good enough for now, to solve clang-16. Going to update #27301 shortly.

👋 fanquake's pull request is ready for review: "depends: fontconfig 2.14.2"
(https://github.com/bitcoin/bitcoin/pull/27301)

💬 fanquake commented on pull request "depends: fontconfig 2.14.2":
(https://github.com/bitcoin/bitcoin/pull/27301#issuecomment-1485237720)
I've tested this with a depends build, with clang-16, and it seems to build everything.

💬 fanquake commented on pull request "ci: Use TSan new runtime (llvm-16, take 3)":
(https://github.com/bitcoin/bitcoin/pull/27298#issuecomment-1485240447)
Could rebase on #27301, and see what happens when you drop 6a05c8401984d989f1adb2a61f12e64c1f13ff82 ?

💬 RandyMcMillan commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#issuecomment-1485245445)
Concept ACK

Will test on macos x86/Arm64 today

💬 pinheadmz commented on issue "Relative paths named in the -conf parameter reset when parsing datadir in named config":
(https://github.com/bitcoin/bitcoin/issues/19990#issuecomment-1485261997)
I tried to reproduce on macOS on master @ `20bd591345`, there is still a warning (examples below). This issue is solved by https://github.com/bitcoin/bitcoin/pull/27303!

# Absolute -conf path

conf file (` /private/tmp/cdata/bitcoin.conf `):
```
datadir=/tmp/tmp2
```

command:
```
bitcoind -conf=/private/tmp/cdata/bitcoin.conf
```

output:
```
...
2023-03-27T14:40:02Z Default data directory /Users/matthewzipkin/Library/Application Support/Bitcoin
2023-03-27T14:40:02Z Using dat
...

👋 pinheadmz's pull request is ready for review: "system: cache config file path before potentially updating datadir"
(https://github.com/bitcoin/bitcoin/pull/27303)

⚠️ Zonarke opened an issue: "Where are the Developers keys to Install Bitcoin Core ?"
(https://github.com/bitcoin/bitcoin/issues/27346)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [X] I still think this issue should be opened here

### Report

I am currently trying to install Bitcoin Core on Linux, during the download verification process, I tried to import the developers PGP keys folowing this link : https://github.com/bitcoin/bitcoin/tree/master/contrib/builder-keys , wich is given by Bitcoin Core website itself (https://bitcoincore.org/en/download/), but as you can s
...

✅ hebasto closed an issue: "Segmentation fault when closing while loading wallets"
(https://github.com/bitcoin-core/gui/issues/689)

🚀 hebasto merged a pull request: "Fix segfault when shutdown during wallet open"
(https://github.com/bitcoin-core/gui/pull/693)

💬 pinheadmz commented on issue "Where are the Developers keys to Install Bitcoin Core ?":
(https://github.com/bitcoin/bitcoin/issues/27346#issuecomment-1485266336)
The keys are here: https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/trusted-keys

I'll see if we need to update the docs on the website

💬 hernanmarino commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#issuecomment-1485269836)
> Could this PR be separated in two commits:
>
> * refactoring and introducing the `RPCExecutor::executeConsoleOnlyCommand()` function
> * actually adding support for the `generate` command`
>
> ?

Yes, will do ASAP.

💬 pinheadmz commented on issue "Where are the Developers keys to Install Bitcoin Core ?":
(https://github.com/bitcoin/bitcoin/issues/27346#issuecomment-1485272621)
correction: they were moved to https://github.com/bitcoin-core/guix.sigs/tree/main/builder-keys and the original locaiton was deleted in https://github.com/bitcoin/bitcoin/pull/26598

💬 pinheadmz commented on issue "Where are the Developers keys to Install Bitcoin Core ?":
(https://github.com/bitcoin/bitcoin/issues/27346#issuecomment-1485280130)
Closing this as duplicate of https://github.com/bitcoin-core/bitcoincore.org/issues/945. Discussion should move to the bitcoincore.org repo

✅ pinheadmz closed an issue: "Where are the Developers keys to Install Bitcoin Core ?"
(https://github.com/bitcoin/bitcoin/issues/27346)

💬 hernanmarino commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1485282916)
I can confirm with clang-15.
```
Ubuntu clang version 15.0.7
Target: x86_64-pc-linux-gnu
Thread model: posix
```

💬 hebasto commented on pull request "depends: fontconfig 2.14.2":
(https://github.com/bitcoin/bitcoin/pull/27301#discussion_r1149392363)
Is `-Wno-int-conversion` really required to compile with clang-16?

💬 hebasto commented on pull request "depends: fontconfig 2.14.2":
(https://github.com/bitcoin/bitcoin/pull/27301#issuecomment-1485289625)
> depends: fontconfig 2.14.2

Update the title?