📝 MarcoFalke opened a pull request: "fuzz: Remove legacy int parse fuzz tests"
(https://github.com/bitcoin/bitcoin/pull/27344)
The fuzz tests checked that the result of the new function was equal to the legacy function. (Side note: The checks were incomplete, as evident by the follow-up fix in commit b5c9bb5cb9f4a8db57b33ef7399310c7d6de5822).

Given that they haven't found any issues in years (beside missing the above issue, that they couldn't catch), it seems time to remove them.

They may come in handy in the rare case that someone would want to modify `LocaleIndependentAtoi()` or `Parse*Int*()`, however that seem
...

💬 hebasto commented on pull request "Fix shortcut ambiguities":
(https://github.com/bitcoin-core/gui/pull/633#issuecomment-1485172473)
@shaavan Still working on this PR?

💬 MarcoFalke commented on issue "-Wmaybe-uninitialized warnings under LTO":
(https://github.com/bitcoin/bitcoin/issues/27343#issuecomment-1485175948)
Fuzz ones removed in https://github.com/bitcoin/bitcoin/pull/27344

💬 TheCharlatan commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1485177511)
> Can someone confirm that this works with clang-15 & earlier, clang-16 & later?

Can confirm for clang 14 and 15. I should start testing these PRs against clang-16 now too.

💬 hebasto commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#issuecomment-1485199088)
Please rebase due to the conflict with the current master branch (b968424c25826cc7b4aa2ec1a5afdb59b41d3377).

✅ hebasto closed a pull request: "test, refactor: Use the same shutdown path as in bitcoin-qt binary"
(https://github.com/bitcoin-core/gui/pull/611)

💬 fanquake commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1485203210)
> Can confirm for clang 14 and 15.

Thanks.

> clang-16 & later?

Actually, this isn't straightforward before #27301. All good.

✅ fanquake closed a pull request: "depends: fontconfig 2.14.2"
(https://github.com/bitcoin/bitcoin/pull/27301)

📝 fanquake reopened a pull request: "depends: fontconfig 2.14.2"
(https://github.com/bitcoin/bitcoin/pull/27301)
We need to bump this as the current version doesn't compile under `clang-16`, which is blocking upgrading sanitizer/fuzzing infrastructure (see #27298).

Untested. Need to double-check the gperf/patch dropping.

📝 fanquake opened a pull request: "guix: use GCC tool wrappers"
(https://github.com/bitcoin/bitcoin/pull/27345)
This way, correct `--plugin` arguments are passed through.

This is a prerequisite for LTO (see #25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

✅ fanquake closed a pull request: "depends: fontconfig 2.14.2"
(https://github.com/bitcoin/bitcoin/pull/27301)

🚀 fanquake merged a pull request: "build, qt: Fix handling of `CXX=clang++` when building `qt` package"
(https://github.com/bitcoin/bitcoin/pull/27314)

📝 fanquake reopened a pull request: "depends: fontconfig 2.14.2"
(https://github.com/bitcoin/bitcoin/pull/27301)
We need to bump this as the current version doesn't compile under `clang-16`, which is blocking upgrading sanitizer/fuzzing infrastructure (see #27298).

Untested. Need to double-check the gperf/patch dropping.

💬 apoelstra commented on pull request "wallet: allow importing descriptors that have no xprivs, even in a privkey-enabled wallet":
(https://github.com/bitcoin/bitcoin/pull/27337#issuecomment-1485217583)
I'm going to close this; actually supporting what I want is a much more complicated job that I expected, and it would violate the scriptpubkeyman abstraction, so probably needs extensive discussion.

✅ apoelstra closed a pull request: "wallet: allow importing descriptors that have no xprivs, even in a privkey-enabled wallet"
(https://github.com/bitcoin/bitcoin/pull/27337)

💬 apoelstra commented on issue "Should be able to import an xpub descriptor to a privkey-enabled wallet if the wallet has the privkeys":
(https://github.com/bitcoin/bitcoin/issues/27336#issuecomment-1485218760)
Feel free to close this -- I'm not planning to work on it anytime soon and I think it implies a fairly large rearchitecture of the wallet. Basically, I would like if spkmans could share private keys.

💬 hebasto commented on pull request "guix: use GCC tool wrappers":
(https://github.com/bitcoin/bitcoin/pull/27345#issuecomment-1485223946)
Concept ACK.

💬 pinheadmz commented on issue "Inconsistent RPC error handling":
(https://github.com/bitcoin/bitcoin/issues/19087#issuecomment-1485227709)
The inconsistencies between single / batch RPCs are addressed in https://github.com/bitcoin/bitcoin/pull/27101 which adds a stricter jsonrpc 2.0 behavior when requested by the client (by adding `"jsonrpc": "2.0"` to the request object). In particular, we try to always return `HTTP 200 OK` unless there actually is a server error.

That PR does not affect the whitelist / authorization processing which looks like, in this discussion, is decidedly acceptable.

@Kixunil and @JeremyRubin are you
...

💬 fanquake commented on issue "depends does not compile with clang-16 (fontconfig)":
(https://github.com/bitcoin/bitcoin/issues/27299#issuecomment-1485231281)
> Maybe fontconfig can also be worked around with something like

Yea, looks like doing the same as qrencode, without a package bump, is going to be good enough for now, to solve clang-16. Going to update #27301 shortly.

👋 fanquake's pull request is ready for review: "depends: fontconfig 2.14.2"
(https://github.com/bitcoin/bitcoin/pull/27301)