🚀 achow101 merged a pull request: "msvc: Compile `test\fuzz\bitdeque.cpp`"
(https://github.com/bitcoin/bitcoin/pull/29983)

🚀 achow101 merged a pull request: "doc: update release-process.md"
(https://github.com/bitcoin/bitcoin/pull/29645)

💬 achow101 commented on pull request "doc: update release-process.md":
(https://github.com/bitcoin/bitcoin/pull/29645#issuecomment-2087757648)
Went ahead with merging this since the vast majority of the changes here are correct and useful. It seems like there are still some questions related to the translations, but I think we can document those later when it becomes apparent that what we're actually doing diverges from the doc.

💬 hernanmarino commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#discussion_r1585735088)
Restored that TODO in my last push. Thanks

👍 alfonsoromanz approved a pull request: "test: Assumeutxo: snapshots with less work should not be loaded"
(https://github.com/bitcoin/bitcoin/pull/29428#pullrequestreview-2032863402)
Re ACK 2f1b1eee8b8a8f546fb5975ac529c4032e46f069

💬 hernanmarino commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-2087784078)
Updated to re add an incorrectly removed TODO comment.

🤔 tdb3 reviewed a pull request: "test: use sleepy wait-for-log in reindex readonly"
(https://github.com/bitcoin/bitcoin/pull/30006#pullrequestreview-2032869168)
ACK for fd6a7d3a13d89d74e161095b0e9bd3570210a40c

Thank you. This should make test execution slightly more efficient and every little bit helps with many tests running in parallel (with `test_runner`).

Built and ran all functional tests (all passed). Reviewed code changes, but didn't notice anything in addition to @maflcko's comments.

👋 sr-gi's pull request is ready for review: "net: Favor peers from addrman over fetching seednodes"
(https://github.com/bitcoin/bitcoin/pull/29605)

💬 sr-gi commented on pull request "net: Favor peers from addrman over fetching seednodes":
(https://github.com/bitcoin/bitcoin/pull/29605#issuecomment-2087925351)
Moving out from drat given #28016 was recently merged.

This comment is still outstanding, and I'd love some feedback on it: https://github.com/bitcoin/bitcoin/pull/29605#discussion_r1531258847

💬 maflcko commented on pull request "net: disconnect inside AttemptToEvictConnection":
(https://github.com/bitcoin/bitcoin/pull/27912#issuecomment-2087991015)
@willcl-ark

💬 maflcko commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-2087992693)
lgtm ACK 2f1b1eee8b8a8f546fb5975ac529c4032e46f069

💬 maflcko commented on pull request "fuzz: wallet, add target for `Crypter`":
(https://github.com/bitcoin/bitcoin/pull/28074#issuecomment-2088028856)
It is not wrong. No file in this repo uses Windows newlines and they are problematic when shown in git.



📝 maflcko opened a pull request: "lint: [doc] Clarify Windows line endings (CR LF) not to be used"
(https://github.com/bitcoin/bitcoin/pull/30010)
It has been this case since the linter was introduced years ago. Given a misunderstanding (https://github.com/bitcoin/bitcoin/pull/28074#issuecomment-2088028856), clarify the docs.

💬 maflcko commented on pull request "build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29494#issuecomment-2088049351)
Rebased (should be trivial to re-ACK)

💬 maflcko commented on pull request "net: Favor peers from addrman over fetching seednodes":
(https://github.com/bitcoin/bitcoin/pull/29605#discussion_r1585942374)
```suggestion
LogInfo("Couldn't connect to peers from addrman after %d seconds. Adding seednode (%s) to addrfetch\n", ADD_NEXT_SEEDNODE.count(), seed);
```

nit: For new code, it could make sense to use the clear and non-deprecated alias here.

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2088077663)
> > is it supposed to do this? i already had 590gb of the blockchain downloaded.
>
> If you told it to reindex, it will reindex.

Alright, its been "Processing blocks on disk" for about 2 days now, without internet.
Is it just reading and verifying whats there or something else? also does it normally take so long?

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2088079918)
You can check the progress window to see the progress and what it is doing currently. Also, you can use the task manager to see the CPU usage, or IO, to see whether it is doing work.

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2088085190)
> You can check the progress window to see the progress and what it is doing currently. Also, you can use the task manager to see the CPU usage, or IO, to see whether it is doing work.

as i said, it says "processing blocks on disk" with about 6 years remaining. But its gonna take about a week at this rate to do so, thus why im checking if its something normal. is it?

💬 WaffleApe commented on issue "Bitcoin Core 27 crash at sync - Ubuntu - No error in logs":
(https://github.com/bitcoin/bitcoin/issues/30001#issuecomment-2088088320)
[gdb.txt](https://github.com/bitcoin/bitcoin/files/15174784/gdb.txt)

Thanks for taking the time answering @maflcko.

The external HDD is mounted as a GUID Partition Table and is connected via USB3 to the motherboard's input. Only blocksdir is stored in the HDD.
The datadir is stored in the internal SSD

Attached to this message the gdb output when running bitcoin-qt in the debugger.

Please also find the `dmesg` output: https://pastebin.com/WBVXnRYe

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2088090333)
How long IBD takes depends on the speed of your CPU and other hardware components.