💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082921899)
Bitcoin Core makes heavy use of CPU, RAM and disk IO. Hardware defects might only become visible when running Bitcoin Core. You might want to check your hardware for defects.

* memtest86 to check your RAM
* to check the CPU behaviour under load, use linpack or Prime95
* to test your storage device use smartctl or CrystalDiskInfo

Source: https://bitcoin.stackexchange.com/a/12206

🚀 ryanofsky merged a pull request: "RPC: access RPC arguments by name"
(https://github.com/bitcoin/bitcoin/pull/29277)

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082926097)
ram and cpu are fine, and i believe the drive also is working fine. i took the files and moved them to another HDD. still same issue on launch.

💬 maflcko commented on pull request "miniscript: make operator""_mst consteval":
(https://github.com/bitcoin/bitcoin/pull/28657#issuecomment-2082926872)
Could rebase, as CI on master should now be passing with clang-15 in.

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082934478)
> i took the files and moved them to another HDD. still same issue on launch.

Yes, file corruption can not be fixed by moving the corrupt files from one storage to another.

👍 hebasto approved a pull request: "system: use %LOCALAPPDATA% as default datadir on windows"
(https://github.com/bitcoin/bitcoin/pull/27064#pullrequestreview-2028718273)
ACK c59b1e45db7b62ba0e0c833e6517045d3dfeacd0, tested on Windows 11 Pro 23H2.

💬 hebasto commented on pull request "system: use %LOCALAPPDATA% as default datadir on windows":
(https://github.com/bitcoin/bitcoin/pull/27064#discussion_r1583207647)
typo:
```suggestion
compatibility if it is present.
```

💬 hebasto commented on pull request "system: use %LOCALAPPDATA% as default datadir on windows":
(https://github.com/bitcoin/bitcoin/pull/27064#discussion_r1583206963)
```suggestion
Windows | `%LOCALAPPDATA%\Bitcoin\` | `C:\Users\username\AppData\Local\Bitcoin\bitcoin.conf`
```

💬 hebasto commented on pull request "system: use %LOCALAPPDATA% as default datadir on windows":
(https://github.com/bitcoin/bitcoin/pull/27064#discussion_r1583208624)
nit: Could add curly braces or put in a single line?

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082937212)
alright, how can i know which file is corrupt and fix it?

💬 hebasto commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082941948)
> ### How did you obtain Bitcoin Core
>
> Package manager

What package manager exactly?

Does the error happen with the recent official Windows binary from https://bitcoincore.org/bin/bitcoin-core-27.0/ ?

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082953057)
Direct download from https://bitcoin.org/en/download.
I hope its called a package manager, or its my mistake for filing it as such.

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082956240)
> alright, how can i know which file is corrupt and fix it?

I think a `-reindex-chainstate` should be good enough.

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082960674)
> > alright, how can i know which file is corrupt and fix it?
>
> I think a `-reindex-chainstate` should be good enough.

alright, where can i run this command though?

👍 brunoerg approved a pull request: "fuzz: don't allow adding duplicate transactions to the mempool"
(https://github.com/bitcoin/bitcoin/pull/29990#pullrequestreview-2028770893)
ACK cc15c5bfd1eb3903de246c124702a7c66c687008

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082984800)
> > alright, how can i know which file is corrupt and fix it?
>
> I think a `-reindex-chainstate` should be good enough.

still same launch result.

💬 hebasto commented on pull request "build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29494#issuecomment-2082991136)
While testing this PR I faced the problem that running linters [locally](https://github.com/bitcoin/bitcoin/tree/master/test/lint#running-locally) alters the ownership of some files in `src` to the `root` user. How to avoid such behaviour?

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082999834)
Is this an external HDD? What is the filesystem?

💬 maflcko commented on pull request "build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29494#issuecomment-2083003826)
I didn't add the docker image, nor is it modified in this pull request. If you have questions about docker or the linter usage, a separate issue may be more appropriate.

📝 alfonsoromanz opened a pull request: "test: Assumeutxo: import snapshot in a node with a divergent chain"
(https://github.com/bitcoin/bitcoin/pull/29996)
This PR adds tests to cover two scenarios of loading a snapshot when the current chain tip is:

- Not an ancestor of the snapshot block but has less work
- Not an ancestor or a descendant of the snapshot block and has more work

In the second scenario, the snapshot block does not belong to the most-work chain anymore so I believe it covers this scenario too: `TODO: Valid snapshot file and snapshot block, but the block is not on the
most-work chain`. Therefore I deleted that TODO as w
...