💬 sipa commented on pull request "Add CheckScriptPushSize to validate script push data size":
(https://github.com/bitcoin/bitcoin/pull/29981#issuecomment-2081266170)
We could simply remove them from the UTXO set if such outputs started to make a meaningful impact. Since they're already unspendable, that would not be a consensus change.

💬 srvinii commented on pull request "Add CheckScriptPushSize to validate script push data size":
(https://github.com/bitcoin/bitcoin/pull/29981#issuecomment-2081267055)
> We could simply remove them from the UTXO set if such outputs started to make a meaningful impact. Since they're already unspendable, that would not be a consensus change.

Considering this alternative, I agree that pursuing a consensus change may not be necessary if the impact of these unspendable outputs can be managed through more straightforward means. I appreciate your insight into this matter and the practical solution you've proposed.

Would you recommend any specific strategies or
...

💬 ajtowns commented on pull request "logging: Update to new logging API":
(https://github.com/bitcoin/bitcoin/pull/29231#issuecomment-2081267056)
Rebased over #28834, removed redundancy from `LogWarning("Warning: ..")`

💬 theStack commented on pull request "refactor: remove remaining unused code from cpp-subprocess":
(https://github.com/bitcoin/bitcoin/pull/29961#discussion_r1581980553)
See the last commit where the numbering is removed. Updating them is also possible of course, but it seems that these numbers don't provide any value.

✅ fanquake closed a pull request: "sync: improve CCoinsViewCache ReallocateCache"
(https://github.com/bitcoin/bitcoin/pull/28945)

✅ srvinii closed a pull request: "Add CheckScriptPushSize to validate script push data size"
(https://github.com/bitcoin/bitcoin/pull/29981)

✅ fanquake closed an issue: "build: Enable Fuzz binary in MSVC"
(https://github.com/bitcoin/bitcoin/issues/29760)

🚀 fanquake merged a pull request: "build: Enable fuzz binary in MSVC"
(https://github.com/bitcoin/bitcoin/pull/29774)

💬 Randy808 commented on issue "intermittent issue in wallet_backwards_compatibility.py: line 245, in run_test assert txs[3]["abandoned"] AssertionError":
(https://github.com/bitcoin/bitcoin/issues/29806#issuecomment-2081321444)
Sounds good, I'll add `sync_mempools()` to mitigate the immediate inconsistency observed with the `abandontransaction` call. I'll mention the potential race conditions between the signals and wallet operations, but I'm thinking that could be treated as a separate issue.

📝 Randy808 opened a pull request: "test: Fix intermittent issue in wallet_backwards_compatibility.py"
(https://github.com/bitcoin/bitcoin/pull/29982)
When creating and replacing a transaction using `bumpfee`, an async update is sent in the form of the `TransactionAddedToMempool` and `TransactionRemovedFromMempool` signals. When `wallet_backwards_compatibility.py` creates `tx3_id` this way and replaces it with `tx4_id`, the `abandontransaction` rpc is called right after. In some cases the `TransactionAddedToMempool` and `TransactionRemovedFromMempool` is handled after the transaction is abandoned in the wallet, and overwrites the transaction's
...

💬 hebasto commented on pull request "Add 1-way SSE4 SHA256 implementation using intrinsics for MSVC builds":
(https://github.com/bitcoin/bitcoin/pull/28526#issuecomment-2081336549)
> Based on #24773.

Deferring to after cmake.

✅ hebasto closed a pull request: "Add 1-way SSE4 SHA256 implementation using intrinsics for MSVC builds"
(https://github.com/bitcoin/bitcoin/pull/28526)

💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#issuecomment-2081338161)
Rebased to resolve conflicts with the merged bitcoin/bitcoin#29774.

💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#issuecomment-2081338871)
cc @achow101 @theStack

> Code changes look reasonable, but Windows stuff is not my expertise...

cc @sipsorcery :)

💬 hebasto commented on pull request "refactor: remove remaining unused code from cpp-subprocess":
(https://github.com/bitcoin/bitcoin/pull/29961#discussion_r1582021758)
ed39d261dc056e700b79da769e085c8af389451d:

The `Popen::poll()` function is used in #29868. I hope that an improved/fixed Windows implementation of the `Popen::retcode()`, which I don't have now, will allow to drop it.

📝 hebasto opened a pull request: "build, msvc: Compile `test\fuzz\bitdeque.cpp`"
(https://github.com/bitcoin/bitcoin/pull/29983)
This PR resolves one point from the https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2028808614:
> What is the issue with the bitdeque... ?

💬 hebasto commented on pull request "msvc: Compile `test\fuzz\bitdeque.cpp`":
(https://github.com/bitcoin/bitcoin/pull/29983#issuecomment-2081363960)
cc @sipa

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2081364269)
> What is the issue with the bitdeque and miniscript fuzz tests?

The https://github.com/bitcoin/bitcoin/pull/29983 resolves the issue with the former.

💬 laanwj commented on issue "depends: Cross-compiling `qt` for `arm-linux-gnueabihf` fails":
(https://github.com/bitcoin/bitcoin/issues/29980#issuecomment-2081381459)
This is caused by the 32 to 64 bit time_t transition (for the 2038 epoch problem). It will affect all 32-bit systems.

I would guess solving this requires a minimal patch to the zlib inside Qt to make the right combination of defines. i'll take a look at it.

💬 laanwj commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#issuecomment-2081398215)
New tests LGTM
Re-ACK a0943b812ef38826a4ee2732af5f24e470281117