💬 maflcko commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-2074217332)
Please delete the hidden comment in the pull description, because this will end up in the merge commit.

💬 hanmz commented on pull request "Fix typos in description.md and wallet_util.py":
(https://github.com/bitcoin/bitcoin/pull/29938#issuecomment-2074218722)
> Also:
>
> ```
> test/functional/test_framework/wallet_util.py:168: lenghts ==> lengths
> ```

Good catch, I fixed.

💬 laanwj commented on pull request "security-check: test for `_FORTIFY_SOURCE` usage in release binaries":
(https://github.com/bitcoin/bitcoin/pull/27038#issuecomment-2074237343)
Concept ACK

💬 maflcko commented on pull request "Fix typos in description.md and wallet_util.py":
(https://github.com/bitcoin/bitcoin/pull/29938#issuecomment-2074243896)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

💬 laanwj commented on pull request "security-check: test for `_FORTIFY_SOURCE` usage in release binaries":
(https://github.com/bitcoin/bitcoin/pull/27038#discussion_r1577400140)
Might want to check `.imported` to make sure it's an imported symbol, just to be sure.

💬 laanwj commented on pull request "security-check: test for `_FORTIFY_SOURCE` usage in release binaries":
(https://github.com/bitcoin/bitcoin/pull/27038#issuecomment-2074248144)
i'd be okay with skipping the check for `bitcoin-util`: it's the least relevant binary for fortification (no network access, not even file format access). Could reconsider it later if it actually gains some useful functionality 😄

💬 maflcko commented on pull request "doc: Fix gen-manpages to check build options":
(https://github.com/bitcoin/bitcoin/pull/29457#discussion_r1577404978)
> This seems arbitrary and prone to breakage, giving the hardcoding of specific components.

I don't think there is a better alternative, is there?

💬 maflcko commented on pull request "test: Add test case for spending bare multisig":
(https://github.com/bitcoin/bitcoin/pull/29120#issuecomment-2074251700)
Are you still working on this?

💬 laanwj commented on pull request "cleanse: switch to SecureZeroMemory for Windows cross-compile, check for usage":
(https://github.com/bitcoin/bitcoin/pull/26950#issuecomment-2074260637)
Concept ACK

💬 laanwj commented on pull request "cleanse: switch to SecureZeroMemory for Windows cross-compile, check for usage":
(https://github.com/bitcoin/bitcoin/pull/26950#discussion_r1577416299)
This checks that the function is there, not whether it is used, in the right places. But it may be enough as a start.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2074267427)
`cc760207b8...ea1ca3715e`: adjust `feature_config_args.py` after forbidding `-walletbroadcast` when `-privatebroadcast` is enabled.

⚠️ KonradStaniec opened an issue: "Calling `walletprocesspsbt` to sign multisig containing `OP_GREATERTHANOREQUAL` op_code"
(https://github.com/bitcoin/bitcoin/issues/29949)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I want to create signature by calling `walletprocesspsbt` endpoint to spend from multisig output. It is worth stating that this is taproot output with one leaf.

Wallet contains one of the key from multisig. Key was created by first calling `getnewaddress` and then calling `getaddressinfo` and retrieving public key.

Now the issue is that if multisig script is in format:
`<key1> OP_C
...

💬 laanwj commented on pull request "contrib: list other binaries in manpage output":
(https://github.com/bitcoin/bitcoin/pull/29585#discussion_r1577434913)
Could use `os.path.basename` it's slightly more readable and will always pick the last path item.

💬 laanwj commented on pull request "contrib: list other binaries in manpage output":
(https://github.com/bitcoin/bitcoin/pull/29585#issuecomment-2074293842)
Good idea, concept ACK.

👍 laanwj approved a pull request: "contrib: list other binaries in manpage output"
(https://github.com/bitcoin/bitcoin/pull/29585#pullrequestreview-2019127833)
Code review ACK 7c3ac598dd9a1f1a506c4931249ff6c9f1c949ba

💬 laanwj commented on pull request "build: add `-Wundef`":
(https://github.com/bitcoin/bitcoin/pull/29876#discussion_r1577456975)
i still think it'd be better, but probably not worth doing this last-minute change for autotools.
Don't know how the CMake port handles these kind of checks anyway, but might consider it there.

👍 laanwj approved a pull request: "netbase: clean up Proxy logging"
(https://github.com/bitcoin/bitcoin/pull/29882#pullrequestreview-2019199241)
ACK fb4cc5f423ce587c1e97377e8afdf92fb4850f59

💬 hebasto commented on pull request "doc: Suggest only necessary Qt packages for installation on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/29947#issuecomment-2074363052)
> > Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:
>
> Please update the version number in line 3 of the doc as well. I don't know if there is a difference between 7.4 and 7.5, but it can't hurt to be accurate here.

Sure. Updated.

💬 laanwj commented on pull request "Remove redundant `-datacarrier` option":
(https://github.com/bitcoin/bitcoin/pull/29942#issuecomment-2074372166)
This particular option was introduced 10 years ago (in e44fea55ea73f46bc9460597c7001e77acb58db7). FWIW i think we would need a stronger reason to remove it than a bit of redundancy.

💬 maflcko commented on pull request "test: Run framework unit tests in parallel":
(https://github.com/bitcoin/bitcoin/pull/29771#issuecomment-2074415872)
ACK f19f0a2e5af6c2a64900f1f229e21b6f1668bd3d 🌽

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: ACK f19f0a2e5af6c2a64900f1f229
...