💬 maflcko commented on issue "Can't version 26.1 export Bech32 address private key?":
(https://github.com/bitcoin/bitcoin/issues/29836#issuecomment-2045550220)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

💬 laanwj commented on pull request "refactor, bench, fuzz: Drop unneeded `UCharCast` calls":
(https://github.com/bitcoin/bitcoin/pull/29820#issuecomment-2045550809)
Seems fine, code review ACK 56e1e5dd10cbe51d3abc3fbf532b6b41bf62a889

💬 achow101 commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-2045554895)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

✅ achow101 closed a pull request: "Add Signet launch shortcut for Windows"
(https://github.com/bitcoin/bitcoin/pull/26334)

✅ achow101 closed a pull request: "ParseHDKeypath: support h as hardened marker"
(https://github.com/bitcoin/bitcoin/pull/28192)

💬 0xB10C commented on pull request "rpc: provide per message stats for global traffic via new RPC 'getnetmsgstats'":
(https://github.com/bitcoin/bitcoin/pull/29418#issuecomment-2045595297)
just fyi as this came up: You could count up message stats with the inbound and outbound message tracepoints. However, this does only gives you stats from the points on where you start hooking into the tracepoints, might not be as user friendly (RPC is easier to use than the tracepoints), and the tracepoints currently only work on Linux.

📝 BrandonOdiwuor opened a pull request: "Feature: Use different datadirs for different signets"
(https://github.com/bitcoin/bitcoin/pull/29838)
#### !!early draft for feedback on approach

Fixes https://github.com/bitcoin/bitcoin/issues/27494

When the `-signetchallenge` argument is provided, the hash-160 of the challenge is appended to the data directory name. This ensures that each signet has its own distinct data directory, following the naming convention `signet-XXXXXXX`.

💬 Eunovo commented on pull request "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict":
(https://github.com/bitcoin/bitcoin/pull/29680#issuecomment-2045654198)
Rebased https://github.com/bitcoin/bitcoin/commit/532d25fb536da953db2b7a6ce7405a4b105c1a56 to https://github.com/bitcoin/bitcoin/commit/47750d3cea9baf9538925362608f9a039bc760ff

> It appears to also be watching for replacements of those replacements too, and I think that is unnecessary.

@achow101 I took this out because the new replacement is not guaranteed to conflict with the original wallet transaction

Added `conflicting_block_hash` and `conflicting_block_height` to `ConflictReason`
...

💬 mjdietzx commented on pull request "tests: add functional test for miniscript decaying multisig":
(https://github.com/bitcoin/bitcoin/pull/29156#issuecomment-2045667575)
> Can you articulate what meaningful difference there is?

Tests a Miniscript descriptor and asserts that it behaves as expected at different block heights as the multisig's thresh of required signers decreases.

I can't judge how meaningful that is or if it deserves a standalone test. As someone who checks in occasionally I needed to convince myself I can really throw Miniscript into a descriptor and the wallet will work/behave like I'm used to

💬 mjdietzx commented on pull request "tests: add functional test for miniscript decaying multisig":
(https://github.com/bitcoin/bitcoin/pull/29156#discussion_r1558033127)
An interesting thing I learned with this test was psbt behavior related to `locktime`. If I created a psbt at a blockheight of 800,000 when multisig was 4-of-4 (maybe I want to pre-sign it with a cold wallet and save it for later), and then I wanted to spend it when the multisig decayed to 3-of-4 at blockheight 840,000, then wallet would not process that psbt as `complete` with 3 valid signatures like I expected (bc I guess it's using locktime of when psbt was created to know how to interpret th
...

💬 Sjors commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-2045743484)
cc @laanwj

📝 achow101 reopened a pull request: "Add Signet launch shortcut for Windows"
(https://github.com/bitcoin/bitcoin/pull/26334)
This makes it easier to launch Signet on Windows. Follows the same pattern as testnet.

Before:

<img width="766" alt="testnet" src="https://user-images.githubusercontent.com/10217/196468934-ee29d129-871b-4612-bde4-842f191403a7.png">

After:
<img width="500" alt="signet1" src="https://user-images.githubusercontent.com/10217/220358057-d9efc532-272c-45e7-81fa-3a52f58a0f29.png">
<img width="527" alt="signet2" src="https://user-images.githubusercontent.com/10217/220358067-62b3b76f-604a-4163-
...

💬 RandyMcMillan commented on pull request "gui: Hide peers details":
(https://github.com/bitcoin-core/gui/pull/505#issuecomment-2045842312)
41a1a86: update per previous suggestions

> tACK [436ac4f](https://github.com/bitcoin-core/gui/commit/436ac4f42b88e8131bf1e02554a20b3c549e7d6f)
>
> UI look & feel.
> **nit**: not a blocker, please consider previous [feedback](https://github.com/bitcoin-core/gui/pull/505#pullrequestreview-1630116141) regarding commit title length and meaningfulness, maybe `gui:` + this PR's title.

👍 pablomartin4btc approved a pull request: "Hide peers details"
(https://github.com/bitcoin-core/gui/pull/505#pullrequestreview-1989980960)
re ACK 41a1a8615dd48fdd9811b9824c49ceb934c6375e

💬 whitslack commented on pull request "contrib/init: (OpenRC) use -daemonwait to wait for startup completion":
(https://github.com/bitcoin/bitcoin/pull/24066#issuecomment-2045899595)
For posterity: note that Gentoo switched to shipping [its own local version](https://github.com/gentoo/gentoo/blob/380aad5fc649a00ae46644c130fb9a3b8970ee09/net-p2p/bitcoin-core/files/bitcoind.openrc) of the OpenRC runscript for Bitcoin Core last year because this PR had stalled.

👍 hernanmarino approved a pull request: "ci: disable `_FORTIFY_SOURCE` with MSAN"
(https://github.com/bitcoin/bitcoin/pull/29837#pullrequestreview-1990006290)
utACK 08ff17d1420a3d1c14c6b1a5436678fbb1dd9cbc . Relevant CI test seems to be working OK.

💬 hernanmarino commented on pull request "refactor, bench, fuzz: Drop unneeded `UCharCast` calls":
(https://github.com/bitcoin/bitcoin/pull/29820#issuecomment-2045952268)
ACK 56e1e5dd10cbe51d3abc3fbf532b6b41bf62a889

💬 hernanmarino commented on pull request "assumeutxo: Fix -reindex before snapshot was validated":
(https://github.com/bitcoin/bitcoin/pull/29726#issuecomment-2045961526)
crACK b7ba60f81a33db876f88b5f9af1e5025d679b5be . Good fix

💬 hernanmarino commented on pull request "lint: scripted-diff verification also requires GNU grep":
(https://github.com/bitcoin/bitcoin/pull/29689#issuecomment-2045970490)
cr ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b

👍 hernanmarino approved a pull request: "test: remove duplicated ban test"
(https://github.com/bitcoin/bitcoin/pull/29688#pullrequestreview-1990065659)
tested ACK e30e8625bbc42045b8b757a8d7e80c20cc61cebf