👍 TheCharlatan approved a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815#pullrequestreview-1984602991)
ACK 2d1819455cb4c516f6cdf81c11e869a23dee3e6b

👍 theStack approved a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815#pullrequestreview-1984605046)
ACK 2d1819455cb4c516f6cdf81c11e869a23dee3e6b

As a historical side-note, it seems like this function was first introduced for OpenSSH (managed in the OpenBSD tree) in 2010, with the name `timing_safe_cmp` back then: https://github.com/openbsd/src/commit/8488487f0974f365bb51defabda91a3e5dcdfaa6#diff-1baa12ad01bad68b45e89594ef3309ad070f9848f764f976e08c435ade846ae5R833

👍 fanquake approved a pull request: "Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us"
(https://github.com/bitcoin/bitcoin/pull/29691#pullrequestreview-1984605052)
ACK 4f273ab4360c9aa72c2feb78787e1811ab58dc16

> Someone, possibly you, should also make a PR to update it here:

I don't see why the person making the PR there matters; it's only copying what is in `kernel/chainparams`. Opened one for recent changes: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/160

🚀 fanquake merged a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815)

💬 willcl-ark commented on pull request "net_processing: make any misbehavior trigger immediate discouragement":
(https://github.com/bitcoin/bitcoin/pull/29575#issuecomment-2041180725)
Concept ACK.

IIUC this would not quite be enough to close down #9530 as it would not permit a header building on top of an invalid block with a valid header, as proposed there. Perhaps what is proposed here is superior though and ce238dd79bd3a1190a2229fac4502fa5742fc6e3 is enough to close that issue out if this goes in?

✅ willcl-ark closed an issue: "p2p sends local-scope addresses when IPv4 is behind NAT"
(https://github.com/bitcoin/bitcoin/issues/8616)

💬 willcl-ark commented on issue "p2p sends local-scope addresses when IPv4 is behind NAT":
(https://github.com/bitcoin/bitcoin/issues/8616#issuecomment-2041181753)
Closing as fixed based on prior comments from vasild.

💬 naiyoma commented on pull request "test: refactor: introduce and use `calculate_input_weight` helper":
(https://github.com/bitcoin/bitcoin/pull/29777#issuecomment-2041202409)
tACK https://github.com/bitcoin/bitcoin/pull/29777/commits/f81fad5e0f3be1f7aed59f9da00396c75c2a6406
I have tested both call sites for the helper function locally (`test/functional/wallet_send.py` and `test/functional/rpc_psbt.py`) — tests run ok.

👍 brunoerg approved a pull request: "test: remove immediate tx relay workaround in wallet_groups.py"
(https://github.com/bitcoin/bitcoin/pull/29822#pullrequestreview-1984702902)
utACK 93fae5ae7c31fa1b1095770f00adeac1cfeda4b9

🤔 glozow reviewed a pull request: "refactor: Use typesafe Wtxid in compact block encodings"
(https://github.com/bitcoin/bitcoin/pull/29752#pullrequestreview-1984703578)
ACK a8203e94123b6ea6e4f4a6320e3ad20457f44a28

⚠️ tadhaQ-nerfed-5misbu opened an issue: "Gate.io"
(https://github.com/bitcoin/bitcoin/issues/29826)

✅ pinheadmz closed an issue: "Gate.io"
(https://github.com/bitcoin/bitcoin/issues/29826)

:lock: fanquake locked an issue: "Gate.io"
(https://github.com/bitcoin/bitcoin/issues/29826)

💬 TheCharlatan commented on pull request "depends: suggest GNU patch for macOS <= 13":
(https://github.com/bitcoin/bitcoin/pull/29814#issuecomment-2041347112)
Found this https://github.com/bazelbuild/bazel/issues/16550 issue that seems to describe what might be going. Sounds like it is only a macos 13 issue?

💬 maflcko commented on pull request "test: remove immediate tx relay workaround in wallet_groups.py":
(https://github.com/bitcoin/bitcoin/pull/29822#issuecomment-2041373716)
lgtm ACK 93fae5ae7c31fa1b1095770f00adeac1cfeda4b9

💬 maflcko commented on pull request "fuzz: Some `test/fuzz/test_runner.py` improvements":
(https://github.com/bitcoin/bitcoin/pull/29821#issuecomment-2041376353)
lgtm ACK 47cedee776c6253232beb6039ea708c578211327

💬 maflcko commented on pull request "ci: remove --with-asm=no (secp256k1) from MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/29742#issuecomment-2041376657)
lgtm ACK 61641e2466768e128fef995e9fcb24cad90e527d

💬 maflcko commented on pull request "refactor, bench, fuzz: Drop unneeded `UCharCast` calls":
(https://github.com/bitcoin/bitcoin/pull/29820#issuecomment-2041377755)
lgtm ACK 56e1e5dd10cbe51d3abc3fbf532b6b41bf62a889

A (more invasive) alternative would be to use `Set(Span<std::byte>)`, or `Set(Span<BasicByte>)`

💬 fanquake commented on pull request "test: Bump timeouts in feature_index_prune and wallet_importdescriptors":
(https://github.com/bitcoin/bitcoin/pull/29791#issuecomment-2041390720)
cc @m3dwards, as I think you had been seeing these timeouts as well.

🚀 fanquake merged a pull request: "test: Bump timeouts in feature_index_prune and wallet_importdescriptors"
(https://github.com/bitcoin/bitcoin/pull/29791)