💬 ryanofsky commented on pull request "Logging cleanup":
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1553729155)
re: https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1549650210
In commit "logging: remove unused code" (d98ca056a82264884bc1aa2da3af540a73ee8f26)

> Would you prefer an assert

I'd suggest just dropping this commit entirely. If you adopt my suggestion from the first commit the `{"", BCLog::NONE}` map entry already disappears so this does not provide an additional simplification to the map, and I don't think there's really another reason to change GetLogPrefix behavior here, at le
...

💬 dergoegge commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2039930366)
> One example on line 282 of transaction_tests.cpp:

I believe this is unrelated to this PR, see https://github.com/bitcoin/bitcoin/issues/29051. `make clean` and rebuilding should fix it.

👋 fanquake's pull request is ready for review: "depends: build miniupnpc with CMake"
(https://github.com/bitcoin/bitcoin/pull/29707)

💬 glozow commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1553735891)
"or similarly small" doesn't really make sense to me. AFAICT this makes just enough transactions to go past the 5MB mempool.

💬 glozow commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1553744185)
Mempool is already empty?

💬 glozow commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1553749001)
Mempool is already empty
```suggestion
# Reset maxmempool, datacarriersize, and dynamic mempool minimum feerate
```

💬 glozow commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1553736451)
nit
```suggestion
Allows for simpler testing of scenarios with minfee > minrelay
```

💬 glozow commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1553746827)
Note that this can change the mempool min fee

📝 Sjors opened a pull request: "depends: suggest GNU patch"
(https://github.com/bitcoin/bitcoin/pull/29814)
Fixes #29792

Adds a note to `depends/README.md` that on older versions of macOS you _may_ need to use GNU patch. I phrased as a troubleshooting hint, rather than make it a default recommendation, because:

1. so far only I ran into it, and @fanquake couldn't reproduce
2. BDB is only used for the legacy wallet, which itself is deprecated
3. it seems better to replace as few default tools on macOS as possible

The instructions in `build-osx.md` don't even mention depends, so I don't touch
...

💬 TheCharlatan commented on pull request "depends: swap some cctools tools for LLVM tools":
(https://github.com/bitcoin/bitcoin/pull/29739#issuecomment-2039959065)
Tested the cross-compiled binaries and deployed bundle on macos 12.7.4.

🤔 glozow reviewed a pull request: "feefrac: avoid explicitly computing diagram; compare based on chunks"
(https://github.com/bitcoin/bitcoin/pull/29757#pullrequestreview-1983373180)
reACK c2fdcf4

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1553766100)
mm yeah let me make this a bit more bullet proof

💬 Sjors commented on pull request "net: update comment for service bit support info for seed.bitcoin.sipa.be":
(https://github.com/bitcoin/bitcoin/pull/29809#issuecomment-2039962940)
You can't know which configuration @sipa - or anyone else running that code - is using. And keeping track of all permutations gets quite noisy.

For my own seed I've occasionally added more filters for new features that were being developed. I wouldn't want to keep making pull requests to change the comment (mine doesn't mention any).

Perhaps this tool can be modified to scan which filters are in use: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/check-dnsseeds.py

💬 hebasto commented on pull request "ci: Drop duplicated compiler flags":
(https://github.com/bitcoin/bitcoin/pull/29800#discussion_r1553772500)
The `--with-sanitizers=memory` has been restored in the recent push.

💬 glozow commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1553777536)
Well I don't think you need get rid of the transactions here - you just want to make sure they get cleared by the end of the test right?

💬 fanquake commented on pull request "ci: Temporarily disable bpfcc-tools":
(https://github.com/bitcoin/bitcoin/pull/29788#issuecomment-2039984016)
Pulled this into 27.x.

💬 TheCharlatan commented on pull request "depends: suggest GNU patch for macOS <= 13":
(https://github.com/bitcoin/bitcoin/pull/29814#issuecomment-2039994022)
I am building depends on macos 12.7.4 and am not seeing any patch related errors or warning. Seems weird that this suddenly pops up now after having worked for a long time? I checked my `brew list` and don't have any entries for "patch" or "gpatch" and when I run `which patch`, it is in /usr/bin, so seems like it is just the default program?

💬 fanquake commented on pull request "depends: suggest GNU patch for macOS <= 13":
(https://github.com/bitcoin/bitcoin/pull/29814#issuecomment-2039996663)
Yea. I'm also sure that my macOS 13.6.6 system is using the default apple patch (will double check), and I don't see any issues.

💬 Sjors commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2040012852)
Rebased after #29419.

💬 maflcko commented on issue "IBD performance regression in 27.0rc1 on Windows":
(https://github.com/bitcoin/bitcoin/issues/29785#issuecomment-2040023180)
Without knowing the cause, there is little that can be done. Given that WSL-built binaries didn't regress, it hints at some build flags inside of guix. My suggestion would be to bisect while doing guix builds. An alternative would be to try to match the guix compile flags and compiler version in WSL.

Also, instead of IBD, the benchmarks can be used, if they differ enough. Though, they'll need to be enabled:
https://github.com/bitcoin/bitcoin/issues/29785#issuecomment-2034314366