✅ achow101 closed an issue: "changed username"
(https://github.com/bitcoin/bitcoin/issues/29808)
(https://github.com/bitcoin/bitcoin/issues/29808)
:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29808)
(https://github.com/bitcoin/bitcoin/issues/29808)
⚠️ tuttheking81 opened an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29810)
.
_Originally posted by @tuttheking81 in https://github.com/bitcoin/bitcoin/issues/29808_
(https://github.com/bitcoin/bitcoin/issues/29810)
.
_Originally posted by @tuttheking81 in https://github.com/bitcoin/bitcoin/issues/29808_
✅ pinheadmz closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29810)
(https://github.com/bitcoin/bitcoin/issues/29810)
:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29810)
(https://github.com/bitcoin/bitcoin/issues/29810)
⚠️ Rojolee opened an issue: "Should this heed --noshutdown?"
(https://github.com/bitcoin/bitcoin/issues/29811)
Should this heed --noshutdown?
_Originally posted by @laanwj in https://github.com/bitcoin/bitcoin/issues/12904#issuecomment-379314241_
(https://github.com/bitcoin/bitcoin/issues/29811)
Should this heed --noshutdown?
_Originally posted by @laanwj in https://github.com/bitcoin/bitcoin/issues/12904#issuecomment-379314241_
✅ achow101 closed an issue: "Should this heed --noshutdown?"
(https://github.com/bitcoin/bitcoin/issues/29811)
(https://github.com/bitcoin/bitcoin/issues/29811)
:lock: achow101 locked an issue: "Should this heed --noshutdown?"
(https://github.com/bitcoin/bitcoin/issues/29811)
(https://github.com/bitcoin/bitcoin/issues/29811)
⚠️ Richlilyjoy100 opened an issue: "H"
(https://github.com/bitcoin/bitcoin/issues/29812)
(https://github.com/bitcoin/bitcoin/issues/29812)
🤔 stratospher reviewed a pull request: "net: update comment for service bit support info for seed.bitcoin.sipa.be"
(https://github.com/bitcoin/bitcoin/pull/29809#pullrequestreview-1981717481)
Concept ACK. thanks for opening this! it's easy to forget to update support for service bit filtering here and the list just keeps getting longer.
another possibility could be just mentioning that the seeder supports service bit filtering and linking to the seeder repo to check the exact list of service bits supported. curious to know what other people think.
(https://github.com/bitcoin/bitcoin/pull/29809#pullrequestreview-1981717481)
Concept ACK. thanks for opening this! it's easy to forget to update support for service bit filtering here and the list just keeps getting longer.
another possibility could be just mentioning that the seeder supports service bit filtering and linking to the seeder repo to check the exact list of service bits supported. curious to know what other people think.
💬 stratospher commented on pull request "net: update comment for service bit support info for seed.bitcoin.sipa.be":
(https://github.com/bitcoin/bitcoin/pull/29809#discussion_r1552802169)
48afa53: there's also x49.
(https://github.com/bitcoin/bitcoin/pull/29809#discussion_r1552802169)
48afa53: there's also x49.
💬 instagibbs commented on pull request "feefrac: avoid explicitly computing diagram; compare based on chunks":
(https://github.com/bitcoin/bitcoin/pull/29757#issuecomment-2039001407)
ACK https://github.com/bitcoin/bitcoin/pull/29757/commits/c2fdcf42e9c4ca0157115e465cca298df70fc700
(https://github.com/bitcoin/bitcoin/pull/29757#issuecomment-2039001407)
ACK https://github.com/bitcoin/bitcoin/pull/29757/commits/c2fdcf42e9c4ca0157115e465cca298df70fc700
💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552969962)
that's the error string as it's reported unfortunately!
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552969962)
that's the error string as it's reported unfortunately!
💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552985927)
done
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552985927)
done
💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552985990)
no but this is even better, taken
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552985990)
no but this is even better, taken
💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552986070)
I don't want to blow away extra_args the caller may want, so took the comment suggestion for now
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552986070)
I don't want to blow away extra_args the caller may want, so took the comment suggestion for now
💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552986113)
split out the moving and docstring changes, should be minimal now?
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552986113)
split out the moving and docstring changes, should be minimal now?
✅ fanquake closed an issue: "H"
(https://github.com/bitcoin/bitcoin/issues/29812)
(https://github.com/bitcoin/bitcoin/issues/29812)
:lock: fanquake locked an issue: "H"
(https://github.com/bitcoin/bitcoin/issues/29812)
(https://github.com/bitcoin/bitcoin/issues/29812)
💬 maflcko commented on pull request "util/system: Close non-std fds when execing slave processes":
(https://github.com/bitcoin/bitcoin/pull/22417#issuecomment-2039148601)
Are you still working on this? There has been no reply to a review comment for about a year: https://github.com/bitcoin/bitcoin/pull/22417#discussion_r1253372361
(https://github.com/bitcoin/bitcoin/pull/22417#issuecomment-2039148601)
Are you still working on this? There has been no reply to a review comment for about a year: https://github.com/bitcoin/bitcoin/pull/22417#discussion_r1253372361