Bitcoin Core Github
44 subscribers
120K links
Download Telegram
💬 visualbasic6 commented on issue "issue with bug reports - censorship - issue deletion":
(https://github.com/bitcoin/bitcoin/issues/27292#issuecomment-1478190908)
you must have missed where idc - but thanks
:lock: fanquake locked an issue: "Blocks remaining falls offscreen with dutch language setting."
(https://github.com/bitcoin/bitcoin/issues/27266)
💬 jamesob commented on pull request "OP_VAULT draft":
(https://github.com/bitcoin/bitcoin/pull/26857#issuecomment-1478200900)
Closing this until the BIP is finalized and this has been tested on inquisition (https://github.com/bitcoin-inquisition/bitcoin/pull/21).
jamesob closed a pull request: "OP_VAULT draft"
(https://github.com/bitcoin/bitcoin/pull/26857)
⚠️ Bhaney44 opened an issue: "Inappropriate Spam Flag"
(https://github.com/bitcoin/bitcoin/issues/27293)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I made [PR 27042](https://github.com/bitcoin/bitcoin/pull/27042) with a dataset I built as a product of meticulous labor. I think it is relatively clear that the dataset adds value to Bitcoin as an information technology by provided data for research and development. However, the PR was flagged as spam and comments were blocked.

If there is a valid reason for why the PR was rejected, I
...
💬 fanquake commented on issue "Inappropriate Spam Flag":
(https://github.com/bitcoin/bitcoin/issues/27293#issuecomment-1478240736)
Unfortunately for you, your PR looked exactly like spam:
* Nondescript PR title
* No PR description
* Completely unmergable, nonsense commit list.

Putting that aside. A "CSV dataset of blockheaders" is obviously not something that belongs in this repository, or that we would want to merge.
fanquake closed an issue: "Inappropriate Spam Flag"
(https://github.com/bitcoin/bitcoin/issues/27293)
💬 Bhaney44 commented on issue "Inappropriate Spam Flag":
(https://github.com/bitcoin/bitcoin/issues/27293#issuecomment-1478253072)
> Unfortunately for you, your PR looked exactly like spam:
>
> * Nondescript PR title
> * No PR description
> * Completely unmergable, nonsense commit list.
>
> Putting that aside. A "CSV dataset of blockheaders" is obviously not something that belongs in this repository, or that we would want to merge.

Alright. No problem. It was my honest attempt to add real value to the network. Thank you for your time and consideration.
💬 achow101 commented on pull request "wallet, tests: Expand and test when the blank wallet flag should be un/set":
(https://github.com/bitcoin/bitcoin/pull/25634#issuecomment-1478256607)
> As far as I understand after this PR is merged we will start unsetting the blank flag and loosing the users' intent.

We were already doing that in several places, the purpose of this PR is to unify the behavior.

If you make a blank legacy wallet, importing any script, address, pubkey, or compressed private key will currently unset the blank flag. If you import an uncompressed private key and your wallet is not encrypted, we would not unset the flag. I think that's a bug, which this PR fi
...
:lock: fanquake locked an issue: "Inappropriate Spam Flag"
(https://github.com/bitcoin/bitcoin/issues/27293)
💬 1440000bytes commented on pull request "Add feerate histogram to getmempoolinfo":
(https://github.com/bitcoin/bitcoin/pull/21422#issuecomment-1478277908)
I am not against sipa as I understand fee estimation is difficult however `estimatesmartfee` sucks and could be improved.

There are lot of occasions when I found it to be irrelevant and just look at mempool.space or multiple explorers


One of the project that I found more useful: https://github.com/TrueLevelSA/btc-congestion-manager

Anyway, this PR tries to improve how projects use mempool info and should not have been controversial at any point.

Request to all developers including
...
💬 ryanofsky commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1478301187)
> I did not address anything directly related to `bitcoin-cli`, I wasn't able to reproduce any issues and I'm not exactly sure what your cli issue was. Can you provide steps and unexpected behavior for that?

The issue with bitcoind described https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470006043 is that a config file specifying a datadir which contains a second config file will ignore the second config file with no warning. I outlined three solutions for this issue here: http
...
💬 furszy commented on pull request "bumpfee: allow send coins back to yourself":
(https://github.com/bitcoin/bitcoin/pull/27195#discussion_r1143775844)
Thanks ishaanam.
At least for me, it doesn't look right to check the vector size while we loop over it. It is also not correct to use `outputs.size()` as `outputs` will be empty if the user didn't customize them.
👍 brunoerg approved a pull request: "refactor, net: End friendship of CNode, CConnman and ConnmanTestMsg"
(https://github.com/bitcoin/bitcoin/pull/27257)
re-ACK 60c3f4918190900e5f79341abcc0878214656257
💬 TheBlueMatt commented on pull request "fix: contrib: allow multi-sig binary verification":
(https://github.com/bitcoin/bitcoin/pull/23020#issuecomment-1478325196)
Can you (here or in a separate PR) add support for validating release artifacts without actually downloading them (ie pre-downloaded release artifacts)?
💬 achow101 commented on pull request "Log new headers":
(https://github.com/bitcoin/bitcoin/pull/27278#issuecomment-1478331026)
ACK 2c3a90f663a61ee147d785167a2902494d81d34d
hebasto closed a pull request: "Accurately account for mempool index memory "
(https://github.com/bitcoin/bitcoin/pull/26614)
🚀 achow101 merged a pull request: "Log new headers"
(https://github.com/bitcoin/bitcoin/pull/27278)
💬 mzumsande commented on pull request "Log new headers":
(https://github.com/bitcoin/bitcoin/pull/27278#issuecomment-1478339894)
> Unconditionally logging headers (outside of IBD) makes sense to me. It doubles the number of messages per block, but since we check their proof-of-work, it's not too bad.

It triples them, the unconditional log output when we receive a header via compact block looks like this with this PR:

```
2023-03-21T17:10:55Z Saw new header hash=0000000000000000000198c04342dff96f7940111d874c7bc73730a33b268225 height=781829
2023-03-21T17:10:55Z [net] Saw new cmpctblock header hash=000000000000000000
...
hebasto closed a pull request: "test: Make `mempool_tests/MempoolSizeLimitTest` allocation-neutral"
(https://github.com/bitcoin/bitcoin/pull/26615)