💬 dergoegge commented on pull request "Log new headers":
(https://github.com/bitcoin/bitcoin/pull/27278#issuecomment-1477933351)
Code review ACK 2c3a90f663a61ee147d785167a2902494d81d34d

💬 dergoegge commented on pull request "Refactor: Remove unused FlatFilePos::SetNull":
(https://github.com/bitcoin/bitcoin/pull/27289#issuecomment-1477936145)
Code review ACK fa67b8181c3ecf94395ecc50fd8acd436f1f8c3a

💬 jamesob commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#issuecomment-1477939852)
> When flushes would happen with e.g. lower dbcache size or longer range of blocks memory usage should be about equal, but then there should be an even larger performance benefit for this PR because it can cache more data with the same memory.

Yup - I started another run with dbcache=1000.

💬 martinus commented on pull request "refactor: Use move semantics instead of custom swap functions":
(https://github.com/bitcoin/bitcoin/pull/26749#issuecomment-1477952301)
re-ACK 95ad70ab652ddde7de65f633c36c1378b26a313a

💬 dergoegge commented on pull request "refactor, net: End friendship of CNode, CConnman and ConnmanTestMsg":
(https://github.com/bitcoin/bitcoin/pull/27257#discussion_r1143495360)
Done!

💬 MarcoFalke commented on issue "Memory leak loading legacy wallet (BDB 4.8.30)":
(https://github.com/bitcoin/bitcoin/issues/27283#issuecomment-1477980568)
My preference would be to suppress libdb4.8, but I guess that is not possible because the sanitizer doesn't see the lib in static builds?

💬 hebasto commented on pull request "Refactor: Remove unused FlatFilePos::SetNull":
(https://github.com/bitcoin/bitcoin/pull/27289#issuecomment-1478004598)
Concept ACK.

💬 hebasto commented on pull request "[DEMO] Integrate `bitcoin-tidy` clang-tidy plugin - warn on uninitialized members of aggregate types":
(https://github.com/bitcoin/bitcoin/pull/26296#issuecomment-1478008931)
> Last I checked, turning that on was essentially unusable, due to false-positives.

[Indeed](https://github.com/bitcoin/bitcoin/pull/26762#issuecomment-1477825604).

👍 theStack approved a pull request: "refactor, net: End friendship of CNode, CConnman and ConnmanTestMsg"
(https://github.com/bitcoin/bitcoin/pull/27257)
re-ACK 60c3f4918190900e5f79341abcc0878214656257

👍 josibake approved a pull request: "Log new headers"
(https://github.com/bitcoin/bitcoin/pull/27278)
ACK https://github.com/bitcoin/bitcoin/pull/27278/commits/2c3a90f663a61ee147d785167a2902494d81d34d

There were some great suggestions for how this could be improved, but I think it's smart to address them in a follow-up, considering this is useful as-is and addresses a real need.

💬 josibake commented on pull request "Log new headers":
(https://github.com/bitcoin/bitcoin/pull/27278#discussion_r1143555402)
leaving this style nit in case someone ends up re-touching this in a follow-up, because this makes my eyes burn :sob:

```suggestion
const auto msg = strprintf(
"Saw new header hash=%s height=%d", hash.ToString(), pindex->nHeight
);
```

👍 john-moffett approved a pull request: "Refactor: Remove unused FlatFilePos::SetNull"
(https://github.com/bitcoin/bitcoin/pull/27289)
ACK fa67b8181c3ecf94395ecc50fd8acd436f1f8c3a

💬 fanquake commented on pull request "Log new headers":
(https://github.com/bitcoin/bitcoin/pull/27278#issuecomment-1478030525)
> FWIW I plan to leave this as-is.

If this is something that we might want in the next released version of Core (24.1), then I think that's preferable. As we'd rather backport a less-involved patch.

💬 MarcoFalke commented on issue "test: `wallet_importdescriptors.py --descriptors` failure":
(https://github.com/bitcoin/bitcoin/issues/27282#issuecomment-1478073717)
> See also https://gist.github.com/fanquake/a458badc73abb47f8c06f009d15e1916 (combined log).

This just looks like a timeout factor error

⚠️ visualbasic6 opened an issue: "p2p dos"
(https://github.com/bitcoin/bitcoin/issues/27291)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

oh hey

i'm pretty sure there's a remote `bitcoind` cpu dos. when the messages (version/mempool) are hammered node cpu jumps from < 1% - 4% to > 100%. i've been unable to make it jump beyond ~190% but i'm not sure what a micro or micro botnet attack would look like against individual nodes.

please note that this is "incomplete homework" as @gmaxwell would probably put it. where is he
...

💬 visualbasic6 commented on issue "p2p dos":
(https://github.com/bitcoin/bitcoin/issues/27291#issuecomment-1478166944)
also - separate issue - but i don't think anyone ever patched my exposed pw "protected" api crash

https://youtube.com/watch?v=cjJM3y718IM

for that you just spam junk b64 in auth - but anyone with their api exposed, password protected or not, probably deserves to have their node disabled remotely 😏

k i'm done here

mad <3,
https://twitter.com/123456

⚠️ visualbasic6 opened an issue: "issue with bug reports - censorship - issue deletion"
(https://github.com/bitcoin/bitcoin/issues/27292)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

https://github.com/bitcoin/bitcoin/issues/27291

wat

more info: https://www.reddit.com/r/hacking/comments/11xlis0/bitcoin_dos_github_issue_with_attack_code_written/


![image](https://user-images.githubusercontent.com/38997186/226676286-f5f993e5-e473-4785-8118-1eb335b7ff
...

💬 visualbasic6 commented on issue "issue with bug reports - censorship - issue deletion":
(https://github.com/bitcoin/bitcoin/issues/27292#issuecomment-1478177307)
much open source very cypherpunk mucho decentralization

💬 fanquake commented on issue "issue with bug reports - censorship - issue deletion":
(https://github.com/bitcoin/bitcoin/issues/27292#issuecomment-1478190517)
You must have missed: https://github.com/bitcoin/bitcoin/blob/master/SECURITY.md.

✅ fanquake closed an issue: "issue with bug reports - censorship - issue deletion"
(https://github.com/bitcoin/bitcoin/issues/27292)