💬 maflcko commented on pull request "Update rpcauth.py":
(https://github.com/bitcoin/bitcoin/pull/29433#issuecomment-1943705614)
Missing `contrib:` prefix in pull title?

💬 1440000bytes commented on issue "Move from Static Dust Limit [330 / 546 sats] to Variable Dust Limit [= to TxFee]":
(https://github.com/bitcoin/bitcoin/issues/29423#issuecomment-1943724704)
So this tx will be considered dust and won't get relayed if such solution is implemented: [bdc168f1d6c38c66c762ccb36655a118436347b074f4a1ff1c8cad4e7429ae0f](https://mempool.space/tx/bdc168f1d6c38c66c762ccb36655a118436347b074f4a1ff1c8cad4e7429ae0f)?

💬 BrandonOdiwuor commented on issue "gen-manpages output depends on build options, so needs to check them":
(https://github.com/bitcoin/bitcoin/issues/17506#issuecomment-1943751907)
any progress with this?

💬 BrandonOdiwuor commented on issue "psbt: set global_xpubs (at least for multisig descriptors)":
(https://github.com/bitcoin/bitcoin/issues/27583#issuecomment-1943762831)
What's the progress with this?

💬 BrandonOdiwuor commented on issue "psbt: set global_xpubs (at least for multisig descriptors)":
(https://github.com/bitcoin/bitcoin/issues/27583#issuecomment-1943763250)
@achow101 what do you think of this?

💬 fanquake commented on pull request "test: fix RPC coverage check":
(https://github.com/bitcoin/bitcoin/pull/29387#issuecomment-1943815753)
This still seems broken. i.e Running `--legacy-wallet` tests directly will no-longer work:
```bash
test/functional/test_runner.py wallet_createwallet.py --legacy-wallet
Temporary test directory at /tmp/test_runner_₿_🏃_20240214_135022
Running Unit Tests for Test Framework Modules
.....................
----------------------------------------------------------------------
Ran 21 tests in 25.689s

OK
usage: create_cache.py [options]
create_cache.py: error: argument --descriptors: not al
...

📝 jadijadi opened a pull request: "qt: prevent weird focus rect on inital sync"
(https://github.com/bitcoin-core/gui/pull/795)
During the initial sync, the Tab moves the focus to the widgets of the main window, even when the ModalOverlay is visible. This creates some weird rectangular *selections on the screen*.

This PR fixes this by keeping the focus on the "Hide" button while the ModalOverlay is visible.

Fixes #783

💬 jadijadi commented on pull request "qt: prevent weird focus rect on inital sync":
(https://github.com/bitcoin-core/gui/pull/795#issuecomment-1943826231)
To reproduce the issue (tested on Mac & KDE):
- open bitcoin gui with wallet
- Hide the sync modal
- Go to send tab
- Highlight the Label
- Click on the progress bar to open the sync modal
- press TAB and a misplaced rectangular highlight should appear

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#discussion_r1489543326)
The template provider tests are quite brittle because they use a real socket.

💬 virtu commented on pull request "Remove `dnsseed.bitcoin.dashjr.org` temporarily":
(https://github.com/bitcoin/bitcoin/pull/29149#issuecomment-1943890840)
> There is the monitoring site at https://www.21.ninja/dns-seeds/ run by @virtu - maybe having some additional statistics about the diversity of results could have caught this issue?

Finally got around to this. I added two:
- The first attempts to measure diversity by counting the [distinct number of versions](https://21.ninja/dns-seeds/node-version-count/)
- The second is tailored specific for the issue at hand and shows the [version range](https://21.ninja/dns-seeds/node-version-range/)

💬 furszy commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1943916606)
Update: I'm cooking another set of improvements.. will try to have them for tonight.

💬 Xaspr commented on issue "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error":
(https://github.com/bitcoin/bitcoin/issues/29255#issuecomment-1943928072)
Thank you.

I did a memtest86 check (the mix option), and a Prime95 stress test for about 24 hours in total. I encountered no issues.

CrystalDiskInfo has no critical warnings and gives Health Status as Good 99%.

💬 pablomartin4btc commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1489587984)
When you run it, it will install an old version which doesn't work.

```
pip install transifex-client
Defaulting to user installation because normal site-packages is not writeable
Collecting transifex-client
Downloading transifex-client-0.12.5.tar.gz (181 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 181.5/181.5 KB 199.8 kB/s eta 0:00:00
Preparing metadata (setup.py) ... done
Requirement already satisfied: six in /usr/lib/python3/dist-packages (from transifex-client) (1.16.0)
R
...

💬 sr-gi commented on pull request "net: attempts to connect to all resolved addresses when connecting to a node":
(https://github.com/bitcoin/bitcoin/pull/28834#discussion_r1489634608)
I've changed `resolvedAddresses` -> `connect_to`, and `resolvedAddr` -> `target_addr` for consistency

💬 furszy commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1944061663)
Or well, I just crafted a simple version of what I'm doing (because I'm planning to create a statement builder around this work, and that will take me some more time).

Could you please try this branch: https://github.com/furszy/bitcoin-core/tree/2024_wallet_batch_migration_multi_insert and share the results?

It is essentially #28574 + 506b73872b9ce232e8c6b9fefbdb0c33e04d0707. The new commit introduces a raw multi-insert statement. Locally, this shows a significant speedup but I'm on a SSD.
...

💬 kristapsk commented on pull request "Update rpcauth.py":
(https://github.com/bitcoin/bitcoin/pull/29433#issuecomment-1944067063)
Concept ACK

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#discussion_r1489710751)
For the time being I just added handling for `MSG_MORE` (on e.g. macOS sequential messages are sent separately while on Linux they're combined). I also made the timeouts a bit longer.

Hopefully that does the trick. This can be revisited closer to the time when the Template Provider is ready for its own PR.

💬 sr-gi commented on pull request "net: attempts to connect to all resolved addresses when connecting to a node":
(https://github.com/bitcoin/bitcoin/pull/28834#discussion_r1489732482)
> What is the worst thing that can happen? A broken/malicious hostname could resolve to 100s addresses all of which timeout slowly, causing some delay here.

We are limiting the number of resolutions to 256

> I think that is ok, given that pzsDest never comes unchecked from random/evil peers over the P2P network and is always provided manually by the operator of the node, right?

That's my intuition too, yes. This is the call tree for `ConnectNode`:

```
RPC::AddConnection --> Add
...

🤔 vasild reviewed a pull request: "kernel: Remove dependency on CScheduler"
(https://github.com/bitcoin/bitcoin/pull/28960#pullrequestreview-1879760071)
Approach ACK c02fd0379c425f486f1b80a81962c1aa68b8a852

Mostly minor stuff below plus a suggestion about the lifetime of the objects.

💬 vasild commented on pull request "kernel: Remove dependency on CScheduler":
(https://github.com/bitcoin/bitcoin/pull/28960#discussion_r1489303118)
nit: in commit message of a38dfb797f175aab45352f85fa80371861b22cd5 `[refactor] Prepare for g_signals de-globalization`:

`s/ValidationSignals/CMainSignals/`