💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1471593836)
Rebased 6d9826f182d9122d4464d35d6682dc6fb4b1116e -> 593a9f36609a74f47175e681a3921f3975272766 ([removeBlockstorageArgs_7](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_7) -> [removeBlockstorageArgs_8](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_7..removeBlockstorageArgs_8)) on newest master to resolve conflicts.

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138371447)
39fa0de08adc2cd19081bb5679d26a6b8b6cb331: Commit message is wrong?

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138372306)
unrelated: If you want, you can add this file to ci iwyu in ./ci/test/06_...

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138374800)
Commit message is wrong too in e78003b42d6bbd166fd87aea357788c712506a6f

💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#issuecomment-1471633104)
nice re-ACK dbeca792a9980085d00be0f9d78187ca3a4d7cdc 🚜

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: nice re-ACK dbeca792a
...

💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1138393045)
nice

💬 hebasto commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471636284)
> If these files aren't changed then the translations would break, wouldn't they?

The `bitcon_<LANGUAGE>.ts` translation files are updated by [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) tool. For example, see https://github.com/bitcoin/bitcoin/pull/27251.

Updating `<source>` strings without updating `<translation>` ones do break translations.

💬 rebroad commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471643050)
The meaning hasn't changed though, just the grammar, so the existing
translations in other languages are still good. Can the existing
translations be retained if I delete the translation file changes?

On Thu, 16 Mar 2023, 09:55 Hennadii Stepanov, ***@***.***>
wrote:

> If these files aren't changed then the translations would break, wouldn't
> they?
>
> The bitcon_<LANGUAGE>.ts translation files are updated by
> bitcoin-maintainer-tools/update-translations.py
> <https://github.com/bitcoin-core/
...

💬 hebasto commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471659745)
> Can the existing translations be retained if I delete the translation file changes?

If the suggested changes to the `src/qt/forms/modaloverlay.ui` file will be merged, during the next translation cycle translators will see the updated strings being marked as "untranslated". Therefore, they have to translate them again, which is, actually, an additional burden. And `*.ts` translation files will be updated regardless of your manual update. Therefore, it looks just pointless.

💬 rebroad commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471662821)
So, how are we supposed to change just the English language in a change
without affecting other languages?

On Thu, 16 Mar 2023, 10:09 Hennadii Stepanov, ***@***.***>
wrote:

> Can the existing translations be retained if I delete the translation file
> changes?
>
> If the suggested changes to the src/qt/forms/modaloverlay.ui file will be
> merged, during the next translation cycle translators will see the updated
> strings being marked as "untranslated". Therefore, they have to translate
> them
...

💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#issuecomment-1471668768)
Also, tested with my diff from https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1133856319

💬 willcl-ark commented on pull request "Updated copyright years":
(https://github.com/bitcoin/bitcoin/pull/27267#issuecomment-1471693836)
The tool is detailed here, although it doesn't mention when it's actioned: https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/README.md#copyright_headerpy

💬 MarcoFalke commented on pull request "refactor: rpc: remove ParseNonRFCJSONValue()":
(https://github.com/bitcoin/bitcoin/pull/27256#discussion_r1138447900)
missing check of value

💬 hebasto commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471760745)
> So, how are we supposed to change just the English language in a change without affecting other languages?

I don't think it is feasible with the current translation process/tools.

💬 stickies-v commented on pull request "refactor: rpc: remove ParseNonRFCJSONValue()":
(https://github.com/bitcoin/bitcoin/pull/27256#discussion_r1138500030)
Left it out because I didn't want to test `AmountFromValue()` here, but I could indeed still just check the `double` value directly. Fixed, thanks.

💬 MarcoFalke commented on pull request "refactor: rpc: remove ParseNonRFCJSONValue()":
(https://github.com/bitcoin/bitcoin/pull/27256#discussion_r1138501819)
wrong commit

💬 stickies-v commented on pull request "reduce cs_main scope, guard block index 'nFile' under a local mutex":
(https://github.com/bitcoin/bitcoin/pull/27006#discussion_r1138503518)
Starting to feel like a struct for those 3 members would be appropriate

💬 hebasto commented on issue "Blocks remaining falls offscreen with dutch language setting.":
(https://github.com/bitcoin-core/gui/issues/721#issuecomment-1471786320)
> Make message re-sizeable.

You can still resize the main window from 
to 

A few additional notes.

> ### What version of Bitcoin Core are you using?
>
> 22.0

I assume you downloaded your Bitcoin Core from https://bitcoin.org/en/bitcoin-core/

If so, please be
...

💬 stickies-v commented on pull request "refactor: rpc: remove ParseNonRFCJSONValue()":
(https://github.com/bitcoin/bitcoin/pull/27256#discussion_r1138513576)
rush, I must not. fixed - sorry.

💬 darosior commented on pull request "MiniTapscript: port Miniscript to Tapscript":
(https://github.com/bitcoin/bitcoin/pull/27255#discussion_r1138537375)
Yeah, it didn't matter since the computation is trivial and the bounds more loose for Tapscript anyways. But your suggestion is clearer indeed, taken, thanks.