💬 mxaddict commented on pull request "Updated copyright years":
(https://github.com/bitcoin/bitcoin/pull/27267#issuecomment-1471405486)
I see, is this process documented somewhere?
(https://github.com/bitcoin/bitcoin/pull/27267#issuecomment-1471405486)
I see, is this process documented somewhere?
💬 rebroad commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471455924)
If these files aren't changed then the translations would break, wouldn't
they?
On Wed, 15 Mar 2023, 19:27 Hennadii Stepanov, ***@***.***>
wrote:
> Translation files should be modified during the translation process only.
> Please drop those changes from this PR.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin-core/gui/pull/720#issuecomment-1470692898>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALVTK574WMIXB74LQ2VMXDW4IJ2VANCNF
...
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471455924)
If these files aren't changed then the translations would break, wouldn't
they?
On Wed, 15 Mar 2023, 19:27 Hennadii Stepanov, ***@***.***>
wrote:
> Translation files should be modified during the translation process only.
> Please drop those changes from this PR.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin-core/gui/pull/720#issuecomment-1470692898>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALVTK574WMIXB74LQ2VMXDW4IJ2VANCNF
...
💬 MarcoFalke commented on pull request "Remove almost all blockstorage globals":
(https://github.com/bitcoin/bitcoin/pull/25781#discussion_r1138289180)
This shouldn't be exposed at all, so I think making it `private` and `ImportingNow` a friend or so might be better?
(https://github.com/bitcoin/bitcoin/pull/25781#discussion_r1138289180)
This shouldn't be exposed at all, so I think making it `private` and `ImportingNow` a friend or so might be better?
💬 jamesmichaeltate1 commented on pull request "rest: add verbose and mempool_sequence query params for mempool/contents":
(https://github.com/bitcoin/bitcoin/pull/26207#issuecomment-1471520348)
(Bitcoin.org)
(https://github.com/bitcoin/bitcoin/pull/26207#issuecomment-1471520348)
(Bitcoin.org)
⚠️ SkybuckFlying opened an issue: "Blocks remaining falls offscreen with dutch language setting."
(https://github.com/bitcoin-core/gui/issues/721)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
It's difficult to see how many blocks remain to be downloaded.
### Expected behaviour
It should be possible to see how many blocks are remaining.
Possible solution1:
Make message re-sizeable.
Make message screen larger in width.
Make message description shorter.
Make it possible to copy & paste the text so the user can paste it elsewhere to get a better idea.
...
(https://github.com/bitcoin-core/gui/issues/721)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
It's difficult to see how many blocks remain to be downloaded.
### Expected behaviour
It should be possible to see how many blocks are remaining.
Possible solution1:
Make message re-sizeable.
Make message screen larger in width.
Make message description shorter.
Make it possible to copy & paste the text so the user can paste it elsewhere to get a better idea.
...
💬 SkybuckFlying commented on issue "Blocks remaining falls offscreen with dutch language setting.":
(https://github.com/bitcoin/bitcoin/issues/27266#issuecomment-1471545980)
Thx. Done. With one additional screenshot ! ;)
(https://github.com/bitcoin/bitcoin/issues/27266#issuecomment-1471545980)
Thx. Done. With one additional screenshot ! ;)
💬 vasild commented on pull request "p2p: Improve diversification of new connections":
(https://github.com/bitcoin/bitcoin/pull/27264#issuecomment-1471557583)
I guess to ensure that it was set according to the expectations and also to serve as a hint to the reader that it will never be those values. Usually such asserts are put right after setting the variable is finished. It is ok without it too. Up to you. Thanks!
(https://github.com/bitcoin/bitcoin/pull/27264#issuecomment-1471557583)
I guess to ensure that it was set according to the expectations and also to serve as a hint to the reader that it will never be those values. Usually such asserts are put right after setting the variable is finished. It is ok without it too. Up to you. Thanks!
💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1471593836)
Rebased 6d9826f182d9122d4464d35d6682dc6fb4b1116e -> 593a9f36609a74f47175e681a3921f3975272766 ([removeBlockstorageArgs_7](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_7) -> [removeBlockstorageArgs_8](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_7..removeBlockstorageArgs_8)) on newest master to resolve conflicts.
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1471593836)
Rebased 6d9826f182d9122d4464d35d6682dc6fb4b1116e -> 593a9f36609a74f47175e681a3921f3975272766 ([removeBlockstorageArgs_7](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_7) -> [removeBlockstorageArgs_8](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_7..removeBlockstorageArgs_8)) on newest master to resolve conflicts.
💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138371447)
39fa0de08adc2cd19081bb5679d26a6b8b6cb331: Commit message is wrong?
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138371447)
39fa0de08adc2cd19081bb5679d26a6b8b6cb331: Commit message is wrong?
💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138372306)
unrelated: If you want, you can add this file to ci iwyu in ./ci/test/06_...
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138372306)
unrelated: If you want, you can add this file to ci iwyu in ./ci/test/06_...
💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138374800)
Commit message is wrong too in e78003b42d6bbd166fd87aea357788c712506a6f
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1138374800)
Commit message is wrong too in e78003b42d6bbd166fd87aea357788c712506a6f
💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#issuecomment-1471633104)
nice re-ACK dbeca792a9980085d00be0f9d78187ca3a4d7cdc 🚜
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: nice re-ACK dbeca792a
...
(https://github.com/bitcoin/bitcoin/pull/27199#issuecomment-1471633104)
nice re-ACK dbeca792a9980085d00be0f9d78187ca3a4d7cdc 🚜
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: nice re-ACK dbeca792a
...
💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1138393045)
nice
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1138393045)
nice
💬 hebasto commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471636284)
> If these files aren't changed then the translations would break, wouldn't they?
The `bitcon_<LANGUAGE>.ts` translation files are updated by [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) tool. For example, see https://github.com/bitcoin/bitcoin/pull/27251.
Updating `<source>` strings without updating `<translation>` ones do break translations.
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471636284)
> If these files aren't changed then the translations would break, wouldn't they?
The `bitcon_<LANGUAGE>.ts` translation files are updated by [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) tool. For example, see https://github.com/bitcoin/bitcoin/pull/27251.
Updating `<source>` strings without updating `<translation>` ones do break translations.
💬 rebroad commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471643050)
The meaning hasn't changed though, just the grammar, so the existing
translations in other languages are still good. Can the existing
translations be retained if I delete the translation file changes?
On Thu, 16 Mar 2023, 09:55 Hennadii Stepanov, ***@***.***>
wrote:
> If these files aren't changed then the translations would break, wouldn't
> they?
>
> The bitcon_<LANGUAGE>.ts translation files are updated by
> bitcoin-maintainer-tools/update-translations.py
> <https://github.com/bitcoin-core/
...
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471643050)
The meaning hasn't changed though, just the grammar, so the existing
translations in other languages are still good. Can the existing
translations be retained if I delete the translation file changes?
On Thu, 16 Mar 2023, 09:55 Hennadii Stepanov, ***@***.***>
wrote:
> If these files aren't changed then the translations would break, wouldn't
> they?
>
> The bitcon_<LANGUAGE>.ts translation files are updated by
> bitcoin-maintainer-tools/update-translations.py
> <https://github.com/bitcoin-core/
...
💬 hebasto commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471659745)
> Can the existing translations be retained if I delete the translation file changes?
If the suggested changes to the `src/qt/forms/modaloverlay.ui` file will be merged, during the next translation cycle translators will see the updated strings being marked as "untranslated". Therefore, they have to translate them again, which is, actually, an additional burden. And `*.ts` translation files will be updated regardless of your manual update. Therefore, it looks just pointless.
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471659745)
> Can the existing translations be retained if I delete the translation file changes?
If the suggested changes to the `src/qt/forms/modaloverlay.ui` file will be merged, during the next translation cycle translators will see the updated strings being marked as "untranslated". Therefore, they have to translate them again, which is, actually, an additional burden. And `*.ts` translation files will be updated regardless of your manual update. Therefore, it looks just pointless.
💬 rebroad commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471662821)
So, how are we supposed to change just the English language in a change
without affecting other languages?
On Thu, 16 Mar 2023, 10:09 Hennadii Stepanov, ***@***.***>
wrote:
> Can the existing translations be retained if I delete the translation file
> changes?
>
> If the suggested changes to the src/qt/forms/modaloverlay.ui file will be
> merged, during the next translation cycle translators will see the updated
> strings being marked as "untranslated". Therefore, they have to translate
> them
...
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471662821)
So, how are we supposed to change just the English language in a change
without affecting other languages?
On Thu, 16 Mar 2023, 10:09 Hennadii Stepanov, ***@***.***>
wrote:
> Can the existing translations be retained if I delete the translation file
> changes?
>
> If the suggested changes to the src/qt/forms/modaloverlay.ui file will be
> merged, during the next translation cycle translators will see the updated
> strings being marked as "untranslated". Therefore, they have to translate
> them
...
💬 MarcoFalke commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#issuecomment-1471668768)
Also, tested with my diff from https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1133856319
(https://github.com/bitcoin/bitcoin/pull/27199#issuecomment-1471668768)
Also, tested with my diff from https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1133856319
💬 willcl-ark commented on pull request "Updated copyright years":
(https://github.com/bitcoin/bitcoin/pull/27267#issuecomment-1471693836)
The tool is detailed here, although it doesn't mention when it's actioned: https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/README.md#copyright_headerpy
(https://github.com/bitcoin/bitcoin/pull/27267#issuecomment-1471693836)
The tool is detailed here, although it doesn't mention when it's actioned: https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/README.md#copyright_headerpy
💬 MarcoFalke commented on pull request "refactor: rpc: remove ParseNonRFCJSONValue()":
(https://github.com/bitcoin/bitcoin/pull/27256#discussion_r1138447900)
missing check of value
(https://github.com/bitcoin/bitcoin/pull/27256#discussion_r1138447900)
missing check of value