💬 achow101 commented on pull request "rest: add verbose and mempool_sequence query params for mempool/contents":
(https://github.com/bitcoin/bitcoin/pull/26207#issuecomment-1470979803)
ACK 1ff5d61dfdaf8987e5619162662e4c760af76a43

🚀 achow101 merged a pull request: "rest: add verbose and mempool_sequence query params for mempool/contents"
(https://github.com/bitcoin/bitcoin/pull/26207)

💬 ishaanam commented on pull request "bumpfee: allow send coins back to yourself":
(https://github.com/bitcoin/bitcoin/pull/27195#discussion_r1137912817)
In 7cb4dc157a711210e18f3c9b492150b6eb984b30 " bumpfee: enable send coins back to yourself "

While this certainly looks correct, I think there is more concise way of doing this within the outputs loop before this one. I've implemented it here if you would like to take a look: https://github.com/ishaanam/bitcoin/commit/5b1017c1ea11c8fe2351a9110e4c6ddad6e77f8a. The advantage of this would be that the sanity check would not be required and imo it would be a bit more readable.

💬 pablomartin4btc commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#discussion_r1137927627)
I'll try from my side and give it a go later this week.

👍 hernanmarino approved a pull request: "cli: add validation to cli side commands besides when it's used with -rpcwallet"
(https://github.com/bitcoin/bitcoin/pull/26990)
ACK a870f5affcfb85f91afe989db0824313985158d8

⚠️ SkybuckFlying opened an issue: "Blocks remaining falls offscreen with dutch language setting."
(https://github.com/bitcoin/bitcoin/issues/27266)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

It's difficult to see how many blocks remain to be downloaded.

### Expected behaviour

It should be possible to see how many blocks are remaining.

Possible solution1:

1. Make message re-sizeable.
2. Make message screen larger in width.
3. Make message description shorter.
4. Make it possible to copy & paste the text so the user can paste it elsewhere to get a better idea.
5. Mak
...

📝 mxaddict opened a pull request: "Updated copyright years"
(https://github.com/bitcoin/bitcoin/pull/27267)
Not sure if this is a thing that should be done, but I noticed that alot of the copyright years are set in the past for the comments.

💬 amitiuttarwar commented on pull request "addrman: Enable selecting addresses by network":
(https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1138102842)
yeah, just to clarify- the tried table doesn't have to be empty, it just needs to have no matches for the specific network. I tried to capture that in the beginning of the comment: "since the only ipv4 address is on the new table", but let me know if there's something else that would help make that more clear

💬 fanquake commented on pull request "Updated copyright years":
(https://github.com/bitcoin/bitcoin/pull/27267#issuecomment-1471361748)
Thanks, but these are changed (if needed) using a script, at only certain times a year.

✅ fanquake closed a pull request: "Updated copyright years"
(https://github.com/bitcoin/bitcoin/pull/27267)

💬 fanquake commented on issue "Blocks remaining falls offscreen with dutch language setting.":
(https://github.com/bitcoin/bitcoin/issues/27266#issuecomment-1471363042)
Please move this issue to the GUI repo: https://github.com/bitcoin-core/gui.

✅ fanquake closed an issue: "Blocks remaining falls offscreen with dutch language setting."
(https://github.com/bitcoin/bitcoin/issues/27266)

💬 mxaddict commented on pull request "Updated copyright years":
(https://github.com/bitcoin/bitcoin/pull/27267#issuecomment-1471405486)
I see, is this process documented somewhere?

💬 rebroad commented on pull request "Correct poor grammar in wallet synchronization warning.":
(https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471455924)
If these files aren't changed then the translations would break, wouldn't
they?

On Wed, 15 Mar 2023, 19:27 Hennadii Stepanov, ***@***.***>
wrote:

> Translation files should be modified during the translation process only.
> Please drop those changes from this PR.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin-core/gui/pull/720#issuecomment-1470692898>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALVTK574WMIXB74LQ2VMXDW4IJ2VANCNF
...

💬 MarcoFalke commented on pull request "Remove almost all blockstorage globals":
(https://github.com/bitcoin/bitcoin/pull/25781#discussion_r1138289180)
This shouldn't be exposed at all, so I think making it `private` and `ImportingNow` a friend or so might be better?

💬 jamesmichaeltate1 commented on pull request "rest: add verbose and mempool_sequence query params for mempool/contents":
(https://github.com/bitcoin/bitcoin/pull/26207#issuecomment-1471520348)
(Bitcoin.org)

⚠️ SkybuckFlying opened an issue: "Blocks remaining falls offscreen with dutch language setting."
(https://github.com/bitcoin-core/gui/issues/721)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

It's difficult to see how many blocks remain to be downloaded.

### Expected behaviour

It should be possible to see how many blocks are remaining.

Possible solution1:

Make message re-sizeable.
Make message screen larger in width.
Make message description shorter.
Make it possible to copy & paste the text so the user can paste it elsewhere to get a better idea.

...

💬 SkybuckFlying commented on issue "Blocks remaining falls offscreen with dutch language setting.":
(https://github.com/bitcoin/bitcoin/issues/27266#issuecomment-1471545980)
Thx. Done. With one additional screenshot ! ;)

💬 vasild commented on pull request "p2p: Improve diversification of new connections":
(https://github.com/bitcoin/bitcoin/pull/27264#issuecomment-1471557583)
I guess to ensure that it was set according to the expectations and also to serve as a hint to the reader that it will never be those values. Usually such asserts are put right after setting the variable is finished. It is ok without it too. Up to you. Thanks!

💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1471593836)
Rebased 6d9826f182d9122d4464d35d6682dc6fb4b1116e -> 593a9f36609a74f47175e681a3921f3975272766 ([removeBlockstorageArgs_7](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_7) -> [removeBlockstorageArgs_8](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_7..removeBlockstorageArgs_8)) on newest master to resolve conflicts.