Bitcoin Core Github
44 subscribers
120K links
Download Telegram
💬 maflcko commented on issue "bitcoin core v.26 shuts down without warning - Doesnt save blocks downloaded":
(https://github.com/bitcoin/bitcoin/issues/29348#issuecomment-1916637658)
Please check your debug.log for possible causes; Alternatively you can upload it here.

You can find the debug.log in your [data dir](https://github.com/bitcoin/bitcoin/blob/master/doc/files.md#data-directory-location).

Please be aware that the debug log might contain personally identifying information.
💬 maflcko commented on issue "bitcoin core v.26 shuts down without warning - Doesnt save blocks downloaded":
(https://github.com/bitcoin/bitcoin/issues/29348#issuecomment-1916638124)
Bitcoin Core makes heavy use of CPU, RAM and disk IO. Hardware defects might only become visible when running Bitcoin Core. You might want to check your hardware for defects.

* memtest86 to check your RAM
* to check the CPU behaviour under load, use linpack or Prime95
* to test your storage device use smartctl or CrystalDiskInfo

Source: https://bitcoin.stackexchange.com/a/12206
💬 Rucade commented on issue "bitcoin core v.26 shuts down without warning - Doesnt save blocks downloaded":
(https://github.com/bitcoin/bitcoin/issues/29348#issuecomment-1916671273)
debug log
[debug.log](https://github.com/bitcoin/bitcoin/files/14097165/debug.log)
💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1471073380)
Done
💬 Rucade commented on issue "bitcoin core v.26 shuts down without warning - Doesnt save blocks downloaded":
(https://github.com/bitcoin/bitcoin/issues/29348#issuecomment-1916672672)
> Please check your debug.log for possible causes; Alternatively you can upload it here.
>
> You can find the debug.log in your [data dir](https://github.com/bitcoin/bitcoin/blob/master/doc/files.md#data-directory-location).
>
> Please be aware that the debug log might contain personally identifying information.

[debug.log](https://github.com/bitcoin/bitcoin/files/14097173/debug.log)
💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1471074052)
Removed `PackageWithAncestorCounts`, now just using `Package`. Did a bit of refactoring inside `PackageV3Checks` so that we can use references instead of copies for the Txid and Wtxid.
💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1471074300)
Removed the duplicate check, nice
💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1471074585)
Indeed! I've removed the duplicate check
💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1471074986)
Not sure if this was a joke :sweat_smile: I've changed it to use `tx_v3_child_heavy['tx'].get_vsize()` now. Is that something that sometimes doesn't work?
💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1471076099)
I updated the comment to say "not strictly necessary" for packages.
💬 fanquake commented on issue "bitcoin core v.26 shuts down without warning - Doesnt save blocks downloaded":
(https://github.com/bitcoin/bitcoin/issues/29348#issuecomment-1916682936)
> 2024-01-19T10:49:39Z Bitcoin Core version v22.0.0 (release build)

Are you sure you are running 26.0? Your logs claim 22.0.
🤔 willcl-ark reviewed a pull request: "net: enable v2transport by default"
(https://github.com/bitcoin/bitcoin/pull/29347#pullrequestreview-1851002292)
If we are now defaulting v2 to enabled, do we want to enable v2transport on a few more of the p2p functional tests, here or in a followup? I currently see the following enabled/disabled variants running the test suite with default options:

<details>

<summary>P2P tests w/ v2 status</summary>

```log
p2p_add_connections.py | ✓ Passed | 7 s
p2p_addr_relay.py | ✓ Passed | 15 s
p2p_addrfetch.py
...
🚀 glozow merged a pull request: "test: Treat msg_version.relay as unsigned, Remove `struct` packing in messages.py"
(https://github.com/bitcoin/bitcoin/pull/29067)
glozow closed an issue: "assumeutxo: nTx and nChainTx violations in CheckBlockIndex"
(https://github.com/bitcoin/bitcoin/issues/29261)
🚀 glozow merged a pull request: "validation: fix misleading checkblockindex comments"
(https://github.com/bitcoin/bitcoin/pull/29299)
🚀 glozow merged a pull request: "doc: update `BroadcastTransaction` comment"
(https://github.com/bitcoin/bitcoin/pull/29308)
👍 ismaelsadeeq approved a pull request: "rpc: validate fee estimation mode case insensitive"
(https://github.com/bitcoin/bitcoin/pull/29175#pullrequestreview-1851027724)
Re-Ack be8ae64b82e2c5b003a8703668ce1751442288e4
💬 maflcko commented on issue "assumeutxo: nTx and nChainTx violations in CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/issues/29261#issuecomment-1916736479)
> The following checks do seem to work, though:

Pull requests welcome
💬 ismaelsadeeq commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#issuecomment-1916752768)
Rebased on master for green CI.
💬 maflcko commented on pull request "test: Treat msg_version.relay as unsigned, Remove `struct` packing in messages.py":
(https://github.com/bitcoin/bitcoin/pull/29067#issuecomment-1916764354)
The following command can be used to find single-byte conversion that can have one (default) argument dropped in Python 3.11. (https://github.com/bitcoin/bitcoin/pull/29067#issuecomment-1880721233)

```sh
git grep 'bytes(1, '