💬 ishaanam commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1137792608)
I have now added test coverage for the lock as well.

💬 LarryRuane commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#discussion_r1137821241)
```suggestion
if (RPCExecutor::executeConsoleOnlyCommand(executableCommand, wallet_model)) {
return;
}
```
(or could put `return` on the same line)

💬 LarryRuane commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#discussion_r1137822858)
these can be removed

💬 LarryRuane commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#discussion_r1137822991)
```suggestion
const std::vector<std::string> parsedCommand{parseHelper(command)};
```

💬 LarryRuane commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#discussion_r1137827055)
That's strange, when I run `clang-format-diff`, it moves this left, where they should be:

<details>
<summary>click to expand</summary>

```
$ git show -U0 | ./contrib/devtools/clang-format-diff.py -p1 -i -v
Formatting src/qt/rpcconsole.cpp
$ git diff
diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
index 1408b289f..63820464b 100644
--- a/src/qt/rpcconsole.cpp
+++ b/src/qt/rpcconsole.cpp
@@ -419,12 +419,12 @@ void RPCExecutor::request(const QString &command, const WalletMo
...

💬 achow101 commented on pull request "Remove almost all blockstorage globals":
(https://github.com/bitcoin/bitcoin/pull/25781#issuecomment-1470936630)
ACK fadf8b818226dc60adf88e927160f9c9680473a4

🚀 achow101 merged a pull request: "Remove almost all blockstorage globals"
(https://github.com/bitcoin/bitcoin/pull/25781)

💬 achow101 commented on pull request "wallet: 25806 follow-up":
(https://github.com/bitcoin/bitcoin/pull/27227#issuecomment-1470952578)
ACK 475c20aa568d597c7850c784058596ae26f37496

🚀 achow101 merged a pull request: "wallet: 25806 follow-up"
(https://github.com/bitcoin/bitcoin/pull/27227)

💬 achow101 commented on pull request "rest: add verbose and mempool_sequence query params for mempool/contents":
(https://github.com/bitcoin/bitcoin/pull/26207#issuecomment-1470979803)
ACK 1ff5d61dfdaf8987e5619162662e4c760af76a43

🚀 achow101 merged a pull request: "rest: add verbose and mempool_sequence query params for mempool/contents"
(https://github.com/bitcoin/bitcoin/pull/26207)

💬 ishaanam commented on pull request "bumpfee: allow send coins back to yourself":
(https://github.com/bitcoin/bitcoin/pull/27195#discussion_r1137912817)
In 7cb4dc157a711210e18f3c9b492150b6eb984b30 " bumpfee: enable send coins back to yourself "

While this certainly looks correct, I think there is more concise way of doing this within the outputs loop before this one. I've implemented it here if you would like to take a look: https://github.com/ishaanam/bitcoin/commit/5b1017c1ea11c8fe2351a9110e4c6ddad6e77f8a. The advantage of this would be that the sanity check would not be required and imo it would be a bit more readable.

💬 pablomartin4btc commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#discussion_r1137927627)
I'll try from my side and give it a go later this week.

👍 hernanmarino approved a pull request: "cli: add validation to cli side commands besides when it's used with -rpcwallet"
(https://github.com/bitcoin/bitcoin/pull/26990)
ACK a870f5affcfb85f91afe989db0824313985158d8

⚠️ SkybuckFlying opened an issue: "Blocks remaining falls offscreen with dutch language setting."
(https://github.com/bitcoin/bitcoin/issues/27266)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

It's difficult to see how many blocks remain to be downloaded.

### Expected behaviour

It should be possible to see how many blocks are remaining.

Possible solution1:

1. Make message re-sizeable.
2. Make message screen larger in width.
3. Make message description shorter.
4. Make it possible to copy & paste the text so the user can paste it elsewhere to get a better idea.
5. Mak
...

📝 mxaddict opened a pull request: "Updated copyright years"
(https://github.com/bitcoin/bitcoin/pull/27267)
Not sure if this is a thing that should be done, but I noticed that alot of the copyright years are set in the past for the comments.

💬 amitiuttarwar commented on pull request "addrman: Enable selecting addresses by network":
(https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1138102842)
yeah, just to clarify- the tried table doesn't have to be empty, it just needs to have no matches for the specific network. I tried to capture that in the beginning of the comment: "since the only ipv4 address is on the new table", but let me know if there's something else that would help make that more clear

💬 fanquake commented on pull request "Updated copyright years":
(https://github.com/bitcoin/bitcoin/pull/27267#issuecomment-1471361748)
Thanks, but these are changed (if needed) using a script, at only certain times a year.

✅ fanquake closed a pull request: "Updated copyright years"
(https://github.com/bitcoin/bitcoin/pull/27267)

💬 fanquake commented on issue "Blocks remaining falls offscreen with dutch language setting.":
(https://github.com/bitcoin/bitcoin/issues/27266#issuecomment-1471363042)
Please move this issue to the GUI repo: https://github.com/bitcoin-core/gui.