Bitcoin Core Github
44 subscribers
121K links
Download Telegram
💬 fanquake commented on pull request "fuzz: Exit and log stderr for parse_test_list errors":
(https://github.com/bitcoin/bitcoin/pull/29304#issuecomment-1909776685)
Looks like this is working as intended https://cirrus-ci.com/task/5482198250291200?logs=ci#L9646:
```bash
+ test/fuzz/test_runner.py -j6 -l DEBUG /ci_container_base/ci/scratch/qa-assets/fuzz_seed_corpus/ --empty_min_time=60
==29805==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x55ef0724925d (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x93625d)
#1 0x55ef09320bb9 (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/
...
💬 fanquake commented on pull request "fuzz: Exit and log stderr for parse_test_list errors":
(https://github.com/bitcoin/bitcoin/pull/29304#issuecomment-1909777779)
We should also fix the symbolizing in that env.
💬 willcl-ark commented on pull request "init: Add option for rpccookie permissions (replace 26088)":
(https://github.com/bitcoin/bitcoin/pull/28167#discussion_r1466110010)
The cookie should be read-only on Windows by deafult, so I've moved the logging up into `InitRPCAuthentication` [here](https://github.com/bitcoin/bitcoin/pull/28167/commits/fcd100cb8e35e7cb00a58a697274a1f2cdb3cc75#diff-a8ffd831b801d5170ec47bd2cde728ada0ffb3571f03ad70d93fc66c2009309aR269-R272), which now also returns an error if the user tries to set `rpccookieperms` on windows.
fanquake closed an issue: "Fido2 lock after 21 Million Mint "
(https://github.com/bitcoin/bitcoin/issues/29310)
💬 willcl-ark commented on pull request "init: Add option for rpccookie permissions (replace 26088)":
(https://github.com/bitcoin/bitcoin/pull/28167#discussion_r1466111038)
Thanks! My formatter is having some difficulty with diff/range-based formatting at the moment. Fixed.
💬 willcl-ark commented on pull request "init: Add option for rpccookie permissions (replace 26088)":
(https://github.com/bitcoin/bitcoin/pull/28167#discussion_r1466112815)
IMO list comprehensions are fine, but seeing as I voided half the point of using one (creating a one-liner), so took the change to a regular for loop in 7516e9120e202395dabebd5b7212d9c2d3787c43
willcl-ark closed an issue: "followups: Various potential improvements arising out of chainman-deglobalizing review"
(https://github.com/bitcoin/bitcoin/issues/21766)
💬 willcl-ark commented on issue "followups: Various potential improvements arising out of chainman-deglobalizing review":
(https://github.com/bitcoin/bitcoin/issues/21766#issuecomment-1909787062)
Going to close this tracking issue as all of the changes listed in OP are now merged.
⚠️ mmaryo opened an issue: "Unable to open wallet UI with ubuntu 23.10"
(https://github.com/bitcoin/bitcoin/issues/29311)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Hello,
I noticed that the UI does not open.


### Expected behaviour

to open the UI

### Steps to reproduce

I copy past the command of the shortcut
`env BAMF_DESKTOP_FILE_HINT=/var/lib/snapd/desktop/applications/bitcoin-core_bitcoin-qt.desktop /snap/bin/bitcoin-core.qt %u`
in a terminal

The terminal output of the command line
`Fontconfig warning: FcPattern object weight does n
...
🚀 fanquake merged a pull request: "build: always set `-g -O2` in `CORE_CXXFLAGS`"
(https://github.com/bitcoin/bitcoin/pull/29205)
💬 hebasto commented on pull request "Avoid non-self-contained Windows header":
(https://github.com/bitcoin-core/gui/pull/789#discussion_r1466158566)
> Comment should be removed?

Thanks! Done.
💬 Sjors commented on pull request "Make (Read/Write)BinaryFile work with char vector, use AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29229#discussion_r1466158963)
Glad something useful came out of this PR :-)
💬 Sjors commented on pull request "Make (Read/Write)BinaryFile work with char vector, use AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29229#discussion_r1466160913)
@vasild I would also prefer to fix things in AutoFile, but perhaps add a few comments to explain what happens?
💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1466162584)
It was intentionally vague, because I might just be doing something else wrong. I'll read @maflcko's suggestion.
💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1466164116)
Without that command I got the same behavior as if the command wasn't there. Presumably it's asynchronous and we somehow have to wait for it. Maybe the above solution avoids the problem altogether.
💬 Sjors commented on pull request "CKey: add Serialize and Unserialize":
(https://github.com/bitcoin/bitcoin/pull/29295#discussion_r1466165495)
Good point.
💬 maflcko commented on issue "Unable to open wallet UI with ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29311#issuecomment-1909861017)
> Also I follow this https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions

There is no need to install dependencies for already packaged Bitcoin Core, since it has the dependencies bundled.



> Fontconfig warning: FcPattern object weight does not accept value [0 205) [1]

This issue tracker does not provide fontconfig support, but you can try a search engine of your choice to track down the issue and solutions. It may be related to the fontconfi
...
💬 fanquake commented on issue "Unable to open wallet UI with ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29311#issuecomment-1909863507)
Close or move to GUI repo? cc @hebasto
💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1466174158)
Looks like https://packages.ubuntu.com/noble/podman and https://packages.debian.org/trixie/podman includes the fixed `--replace`, so might try that at one point.
💬 mmaryo commented on issue "Unable to open wallet UI with ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29311#issuecomment-1909908601)
Hello
Thank you
this command line works
https://github.com/keshavbhatt/olivia/issues/95#issuecomment-774747492

But my wallet is empty?
![image](https://github.com/bitcoin/bitcoin/assets/1669985/ea4f2af4-dadb-4281-9b24-055fce2d7fa9)


May I find it somewhere else?
Are there logs?