💬 fanquake commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1463611946)
What is "kill harder"? Containers are already being `--all --force` removed below:
```bash
-a, --all Remove all containers
-f, --force Force removal of a running or unusable container
```
so they shouldn't need to be "stopped" beforehand?

Also, shouldn't this be `podman`?

💬 fanquake commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1463613779)
Also, why is this `sleep` here?

🚀 fanquake merged a pull request: "Add test for negative transaction version w/ CSV to tx_valid.json"
(https://github.com/bitcoin/bitcoin/pull/29291)

💬 stratospher commented on pull request "test/BIP324: functional tests for v2 P2P encryption":
(https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1463620264)
`respond_v2_handshake()` is supposed keep reading bytes from `bitcoind` and shoot out ellswift bytes when first mismatch from 16 bytes `V1_PREFIX` happens. Let's say the mismatch happens after reading 3 bytes - we still need to store the 3 bytes read somewhere (currently stored in `self.received_prefix`) since it's actually the first 3 bytes of ellswift which `bitcoind` was sending us.

we need this 3 bytes later in `complete_handshake()` to read the remaining 64-3 bytes and to compute ellswif
...

💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1463636403)
An alternative (with podman 4.8+) would be to use `run --replace`, see https://github.com/containers/podman/commit/f21c1d238da393cb11c75e408a736336b979e6d5

👍 fanquake approved a pull request: "depends: Update libmultiprocess library to fix C++20 macos build error"
(https://github.com/bitcoin/bitcoin/pull/29276#pullrequestreview-1839389410)
ACK b8105b3ed7c97cd6545dba99d0e13c33f183e450.

✅ fanquake closed an issue: "build: multiprocess compile failure on macOS"
(https://github.com/bitcoin/bitcoin/issues/29248)

🚀 fanquake merged a pull request: "depends: Update libmultiprocess library to fix C++20 macos build error"
(https://github.com/bitcoin/bitcoin/pull/29276)

💬 luke-jr commented on pull request "init: handle empty settings file gracefully":
(https://github.com/bitcoin/bitcoin/pull/29144#issuecomment-1906571657)
Should we perhaps add (and recommend, for non-GUI users), a `-resetguisettings` for non-GUI?

⚠️ helpau opened an issue: "Huge disk fragmentation"
(https://github.com/bitcoin/bitcoin/issues/29296)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

very many fragmented files

### Expected behaviour

files are not fragmented

### Steps to reproduce

An extra description of the behaviour from #26063
Prerequisite: disc defragmented (I used Full optimization from UltraDefrag), Windows Security(including real-time protection) are disabled.
1. Start Bitcoin Core
2. Wait for half an hour
3. Stop Bitcoin Core
4. Run UltraDefrag report

...

✅ achow101 closed an issue: "Huge disk fragmentation"
(https://github.com/bitcoin/bitcoin/issues/29296)

💬 achow101 commented on issue "Huge disk fragmentation":
(https://github.com/bitcoin/bitcoin/issues/29296#issuecomment-1906702516)
Disk fragmentation is a property of your hardware and your operating system. Software such as Bitcoin Core do not have low level access to the filesystem and hardware to control where the data will be physically placed. This is a problem with your operating system and how it chooses where files are actually physically stored.

✅ mjdietzx closed an issue: "Build error on macOS, tag v26.0 builds fine"
(https://github.com/bitcoin/bitcoin/issues/29289)

💬 mjdietzx commented on issue "Build error on macOS, tag v26.0 builds fine":
(https://github.com/bitcoin/bitcoin/issues/29289#issuecomment-1906734501)
> Which version of clang are you using?

```
Apple clang version 13.0.0 (clang-1300.0.29.30)
Target: x86_64-apple-darwin21.1.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```

I tried building master @ f1ab078ed7742c3350438f0315846948cf317e67 on my newer MacBook Pro. Builds properly with no errors. Where clang version is:
```
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: arm64-apple-darwin22.1.0

...

💬 murchandamus commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463859645)
Yeah, that would improve it

🤔 murchandamus reviewed a pull request: "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2"
(https://github.com/bitcoin/bitcoin/pull/29242#pullrequestreview-1839716607)
ACK a14b95129d3a2894b7a41ce919a426bb60f62e35

Note: I am fairly familiar with the concept of feerate diagram checks, but not particularly familiar with the mempool code.

💬 murchandamus commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463863198)
```suggestion
* having a conflicting input with a proposed transaction
```

💬 murchandamus commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463866212)
If all diagrams always start with `FeeFrac{0, 0}`, why do we need to mention that as a first element?

💬 achow101 commented on pull request "wallet: fix coin selection tracing to return -1 when no change pos":
(https://github.com/bitcoin/bitcoin/pull/29272#issuecomment-1906770454)
ACK d55fdb1a495190e213b1b5127f5d91e4a409765e

🚀 achow101 merged a pull request: "wallet: fix coin selection tracing to return -1 when no change pos"
(https://github.com/bitcoin/bitcoin/pull/29272)