💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463285858)
direct_conflicts -> the set of transactions that have at least one input conflicting with a proposed transaction.
all_conflicts -> Everything that would be evicted by the proposed transaction

I'll touch this up a bit but this is the nomenclature elsewhere

💬 hebasto commented on pull request "build: always set `-g -O2` in `CORE_CXXFLAGS`":
(https://github.com/bitcoin/bitcoin/pull/29205#issuecomment-1906078874)
> > While always overriding Autotools' defaults, are there any particular reasons not using -O3 instead of -O2?
>
> AFAIK `-O3` isn't safe.

How?

FWIW, `-O3` is used by default in CMake for "Release" builds.

📝 Sjors opened a pull request: "CKey: add Unserialize"
(https://github.com/bitcoin/bitcoin/pull/29295)
In #28983 I need to read and write two private keys to/from disk that are used by Stratum v2 peers to (optionally) authenticate us.

For the write part, I initially just put the key data into a `std::vector<unsigned char>` and then used a modified version of `WriteBinaryFile`. But @vasild pointed out in #29229 that:

> `CKey` stores sensitive data and takes care to wipe it from memory when freed. In #28983 `Read/WriteBinaryData()` is used in a way that defeats that - the sensitive data will
...

💬 Sjors commented on pull request "CKey: add Unserialize":
(https://github.com/bitcoin/bitcoin/pull/29295#issuecomment-1906103142)
Opened as draft because I suspect this can be done less verbosely.

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463314427)
I can't recall honestly, removed that line

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463314511)
ah hmm, I'm not sure that matters for correctness of test, but jacked up the last chunk's size just to make it clearer what we're testing

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463314570)
tried my own re-explanation. I agree as-is is confusing

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463314620)
tried my own explanation

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463314778)
fixed

💬 Sjors commented on pull request "Make (Read/Write)BinaryFile work with char vector, use AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29229#issuecomment-1906105122)
I opened #29295 for `CKey`.

I no longer need this PR myself, but happy to continue it.

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463315597)
taken

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463315777)
done

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#issuecomment-1906111930)
@murchandamus comments should be addressed or taken

💬 Sjors commented on pull request "CKey: add Unserialize":
(https://github.com/bitcoin/bitcoin/pull/29295#issuecomment-1906152265)
Added `Serialize` for completeness. This only saves me a `MakeUCharSpan(key)`.

💬 fanquake commented on issue "Mac App UI is freezed most of the time, with no active peers":
(https://github.com/bitcoin/bitcoin/issues/29293#issuecomment-1906155455)
cc @hebasto

💬 ryanofsky commented on pull request "ci: Rename tasks (previous releases, macOS cross)":
(https://github.com/bitcoin/bitcoin/pull/29218#issuecomment-1906162604)
Mostly just asking for curiousity, since I guess I can rebase, but in some of my PR's I see:

```sh
./ci/test/00_setup_env.sh: line 33: ./ci/test/00_setup_env_native_qt5.sh: No such file or directory
```

https://cirrus-ci.com/task/5895775641665536
https://cirrus-ci.com/task/5238795365253120

And I'm confused about why this happens. Which cirrus is running, is it mixing and matching the cirrus configuration and scripts from different branches?

💬 furszy commented on issue "Mac App UI is freezed most of the time, with no active peers":
(https://github.com/bitcoin/bitcoin/issues/29293#issuecomment-1906176335)
I briefly started working on this in the past but stopped because of the new GUI development.
Depending on the new GUI progress, I could (slowly but steady) start improving this situation.

💬 fanquake commented on issue "Mac App UI is freezed most of the time, with no active peers":
(https://github.com/bitcoin/bitcoin/issues/29293#issuecomment-1906178121)
Shoudn't this be closed and marked as a duplicate of one of the existing issues in the GUI repo, and or moved to the GUI repo?

💬 hebasto commented on issue "Mac App UI is freezed most of the time, with no active peers":
(https://github.com/bitcoin/bitcoin/issues/29293#issuecomment-1906194363)
Closing this a the former of reported problems
> App is not responding most of the time, mouse is spinning

is a duplicate of https://github.com/bitcoin-core/gui/issues/299.

And the latter
> there is no stable active peers - there is almost no progress for 2 weeks.

seems better to ask elsewhere, for instance, on https://bitcoin.stackexchange.com/.

✅ hebasto closed an issue: "Mac App UI is freezed most of the time, with no active peers"
(https://github.com/bitcoin/bitcoin/issues/29293)