💬 brunoerg commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1137297128)
Yes, you're right, there is a way to simplify it, no need to rewrite the filter. Force-pushed addressing it.

📝 rebroad opened a pull request: "Correct poor grammar in wallet synchronization warning."
(https://github.com/bitcoin-core/gui/pull/720)
This pull request updates the wallet synchronization warning text to provide a clearer and more concise message to users. The original text was somewhat clumsy and suffered from grammatical issues, which could lead to confusion. The changes made are as follows:

- Replace the original warning text with a more concise and grammatically correct version.
- Clarify that transactions using bitcoin from unseen transactions due to ongoing synchronization will be rejected by the network.

These cha
...

💬 stickies-v commented on issue "Feature request: alert PR author in case of CI failure":
(https://github.com/bitcoin/bitcoin/issues/27178#issuecomment-1470269530)
Drahtbot could also update its comment to prefix it with instructions on what to do in case of CI failure? Also, I don't think I've actually ever received an email from label changes and can't find any settings or documentation for it?

So, perhaps the combination of DrahtBot:
1. assigning author to the PR to trigger a notification (the notification itself won't really contain any useful info, but I don't think it'll necessarily be too confusing either)
2. adding the "CI failed" label to mak
...

💬 ryanofsky commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470284856)
It seems like there is a problem to be addressed here, though I'm not 100% sure what the best way to address it would be. You could have a datadir A containing a bitcoin.conf file specifying another datadir B that contains another bitcoin.conf file specifying another datadir C that contains another bitcoin.conf file, and so on.

Various ways this could be handled:

1. Follow the path forever just merging all the bitcoin.conf settings values together and only failing if there is a loop.
2. F
...

💬 petertodd commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1470288671)
FYI, first bit of work on this, a minor cleanup to the logic: https://github.com/bitcoin/bitcoin/pull/27261

💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1470291207)
Thank you for the review!

Updated 600ab02bf58e073a93936438a7e884b3a7110f1c -> b3e78dc91d01e364b77aacd9fb9a2f88688ab8a6 ([tc/2022-09-libbitcoinkernel-chainparams-args_7](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_7) -> [tc/2022-09-libbitcoinkernel-chainparams-args_8](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkern
...

💬 rebroad commented on pull request "Refine wallet synchronization warning for enhanced clarity":
(https://github.com/bitcoin/bitcoin/pull/27262#issuecomment-1470300845)
Moved to https://github.com/bitcoin-core/gui/pull/720

💬 ryanofsky commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470305275)
> bitcoin_wallet searches wallets on datadir? but for other tools there are walletdir parameter...

This looks like another thing that should be fixed, though in practice right now `bitcoin-wallet` only operates on one wallet at a time, so if you wanted to specify `bitcoin-wallet -walletdir=/path -wallet=mywallet` you could just specify `bitcoin-wallet -wallet=/path/mywallet` instead

The `bitcoin-wallet` code actually would actually already use the `-walletdir` value if it could be passed:
...

📝 pinheadmz opened a pull request: "logging: accept "none" as argument for rpc logging"
(https://github.com/bitcoin/bitcoin/pull/27263)
The help message for rpc `logging` includes:

```
In addition, the following are available as category names with special meanings:
- "all", "1" : represent all logging categories.
- "none", "0" : even if other logging categories are specified, ignore all of them.
```

However "none" is not currently recognized:

```
$ bitcoin/src/bitcoin-cli logging "[\"none\"]"
error code: -8
error message:
unknown logging category none
```

This patch adds the string "none" to match the
...

💬 jonatack commented on pull request "logging: accept "none" as argument for rpc logging":
(https://github.com/bitcoin/bitcoin/pull/27263#issuecomment-1470312655)
I don't think that brings the missing functionality (see #27231, am updating it to just drop the functionality).

💬 fanquake commented on pull request "logging: accept "none" as argument for rpc logging":
(https://github.com/bitcoin/bitcoin/pull/27263#issuecomment-1470313674)
See also #27231.

💬 pinheadmz commented on pull request "logging: accept "none" as argument for rpc logging":
(https://github.com/bitcoin/bitcoin/pull/27263#issuecomment-1470314719)
word! sorry, will track #27231 and review when its ready

✅ pinheadmz closed a pull request: "logging: accept "none" as argument for rpc logging"
(https://github.com/bitcoin/bitcoin/pull/27263)

📝 stratospher opened a pull request: "p2p: Improve diversification of new connections"
(https://github.com/bitcoin/bitcoin/pull/27264)
Revives #19860.

In order to make sure that our persistent outbound slots belong to different netgroups, distinct net groups of our peers are added to [`setConnected`](https://github.com/bitcoin/bitcoin/blob/8c4958bd4c06026dc108bc7f5f063d1f389d279b/src/net.cpp#L1716). We’d only open a persistent outbound connection to peers which have a different netgroup compared to those netgroups present in `setConnected`.

**behaviour on master**

we open persistent outbound connections to peers which
...

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137365115)
Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137365304)
Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367474)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367980)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367822)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137368863)


Thx, can be marked resolved