🚀 fanquake merged a pull request: "depends: Allow PATH with spaces in directory names."
(https://github.com/bitcoin/bitcoin/pull/29237)

💬 willcl-ark commented on pull request "init: Add option for rpccookie permissions (replace 26088)":
(https://github.com/bitcoin/bitcoin/pull/28167#issuecomment-1892167852)
OK I added a commit to change default cookie perms to `400`, and rebased on master to try and get the unrelated CI failure to go away.

✅ fanquake closed a pull request: "build: Fix LTO functionality"
(https://github.com/bitcoin/bitcoin/pull/28876)

💬 fanquake commented on pull request "build: Fix LTO functionality":
(https://github.com/bitcoin/bitcoin/pull/28876#issuecomment-1892168841)
> FWIW, the https://github.com/bitcoin/bitcoin/pull/29185 makes this PR outdated.

Closing this for now, given it looks like we are going ahead with #29185.

💬 1440000bytes commented on pull request "OP_CHECKTEMPLATEVERIFY, OP_CHECKSIGFROMSTACK(VERIFY), OP_INTERNALKEY validation (LNHANCE)":
(https://github.com/bitcoin/bitcoin/pull/29198#issuecomment-1892179472)
I think [consensus ](https://github.com/bitcoin/bitcoin/labels/Consensus) label should be added for this pull request

📝 fanquake opened a pull request: "depends: add NM output to gen_id"
(https://github.com/bitcoin/bitcoin/pull/29249)
`NM` is part of the current toolset, and can be set by the user. Include it in `gen_id`.

💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1452381557)
done

💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1452381462)
done

💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1452381283)
done

💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1452381691)
done

💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1452381645)
done

💬 furszy commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#issuecomment-1892185801)
Thanks for the review @andrewtoth!
All nits tackled, [small diff](https://github.com/bitcoin/bitcoin/compare/6c603490023317a84c7c96ef4b64f4f96ea03d1f..79e10351b1ce1f8db98ece67aacc24f323008b37). Ready to go.

💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#issuecomment-1892249295)
Rebased on fix for CI issue

⚠️ Laughter79 opened an issue: "https://api.substack.com/feed/podcast/375278/private/b6bb76fe-b98c-4862-8885-1b0beb0fb3e4.rss"
(https://github.com/bitcoin/bitcoin/issues/29250)

✅ willcl-ark closed an issue: "https://api.substack.com/feed/podcast/375278/private/b6bb76fe-b98c-4862-8885-1b0beb0fb3e4.rss"
(https://github.com/bitcoin/bitcoin/issues/29250)

:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29250)

💬 fanquake commented on pull request "build: remove `--enable-lto`":
(https://github.com/bitcoin/bitcoin/pull/29185#issuecomment-1892283371)
This is waiting on https://github.com/google/oss-fuzz/pull/11498 downstream.

🤔 furszy reviewed a pull request: "sqlite: Disallow writing from multiple `SQLiteBatch`s"
(https://github.com/bitcoin/bitcoin/pull/29112#pullrequestreview-1821862931)
> Changed TxnAbort and TxnCommit to always release the lock.

This breaks the db txn isolation property.
The db txn is still active at the engine level, the lock shouldn't be released when the sqlite statement fails to execute (only when the abort/commit command executes successfully). Otherwise, other concurrent handlers are allowed to access db at the same time and, in the worst possible outcome, dump information to disk that should have been discarded.

Check this out 71170998. Made a te
...

💬 maflcko commented on pull request "ci, iwyu: Update mappings":
(https://github.com/bitcoin/bitcoin/pull/27710#discussion_r1452493222)
are you still working on this?

🚀 fanquake merged a pull request: "log mempool loading progress"
(https://github.com/bitcoin/bitcoin/pull/29227)