👍 fanquake approved a pull request: "ci, iwyu: Drop backported mappings"
(https://github.com/bitcoin/bitcoin/pull/29186#pullrequestreview-1815973973)
ACK a395218d8cdffba375006590edca58c844126b16

🚀 fanquake merged a pull request: "ci, iwyu: Drop backported mappings"
(https://github.com/bitcoin/bitcoin/pull/29186)

💬 fanquake commented on pull request "depends: remove dependency on Darwin libtool":
(https://github.com/bitcoin/bitcoin/pull/29232#issuecomment-1887516591)
Looks good. Have tested this in the LLD PR. Will ACK after rebase and adding the PIC fix for libnatpmp.

💬 jonatack commented on pull request "logging: Simplify API for level based logging":
(https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1449103019)
ab34dc6012351 The loglevel help wasn't updated with this change (note that this commit is an incomplete copy of [`118c756` (#25203)](https://github.com/bitcoin/bitcoin/pull/25203/commits/118c7567f62df2b882877590f232242d7c627a05) from the Severity-based logging parent PR). Fixed in #29230.

💬 theuni commented on pull request "depends: remove dependency on Darwin libtool":
(https://github.com/bitcoin/bitcoin/pull/29232#issuecomment-1887518447)
Rebased on master and fixed up pic.

💬 achow101 commented on pull request "test: add assumeutxo wallet test":
(https://github.com/bitcoin/bitcoin/pull/28838#issuecomment-1887519279)
ACK 997b9a73e5166b4244f7c5b4fe144d524f3005f4

💬 stickies-v commented on pull request "doc: update -loglevel help following merge of PR 28318":
(https://github.com/bitcoin/bitcoin/pull/29230#discussion_r1449106936)
LGTM. Since we're already hardcoding "info, warning, error", should we hardcode the allowed levels too and exclude (just in docs) `warning` and `error`?
```suggestion
argsman.AddArg("-loglevel=<level>|<category>:<level>", strprintf("Set the global or per-category severity level for logging categories enabled with the -debug configuration option or the logging RPC. Possible values are info, debug, trace (default=%s). The following levels are always logged: info, warning, error. If <category
...

👍 theuni approved a pull request: "depends: Include `config.guess` and `config.sub` into `meta_depends`"
(https://github.com/bitcoin/bitcoin/pull/28870#pullrequestreview-1816000666)
ACK ff3f51b402efe6dc0b4bd14aecb9b58c2815c6e4.

For context, this will force rebuilds of everything whenever these files are updated.

🚀 achow101 merged a pull request: "test: add assumeutxo wallet test"
(https://github.com/bitcoin/bitcoin/pull/28838)

💬 stickies-v commented on pull request "logging: Simplify API for level based logging":
(https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1449114654)
> it's about allowing the end user to articulate what they see

which is trivial to do with `grep`? My point about system resources is that theoretically we could always log _everything_ but that would use an unreasonable amount of system resources, hence the nuance.

💬 jamesob commented on pull request "test: add assumeutxo wallet test":
(https://github.com/bitcoin/bitcoin/pull/28838#issuecomment-1887533530)
Posthumous ACK https://github.com/bitcoin/bitcoin/commit/997b9a73e5166b4244f7c5b4fe144d524f3005f4

Was just in the middle of reviewing this and figuring out how to add some balance checks. May file a followup.

🚀 fanquake merged a pull request: "depends: Include `config.guess` and `config.sub` into `meta_depends`"
(https://github.com/bitcoin/bitcoin/pull/28870)

💬 jonatack commented on pull request "doc: update -loglevel help following merge of PR 28318":
(https://github.com/bitcoin/bitcoin/pull/29230#discussion_r1449116831)
Thanks! On current master, I think `warning` and `error` are already excluded.

```
$ ./src/bitcoind -regtest -help-debug | grep -A12 loglevel=
-loglevel=<level>|<category>:<level>
Set the global or per-category severity level for logging categories
enabled with the -debug configuration option or the logging RPC:
info, debug, trace (default=debug); warning and error levels are
always logged. If <category>:<level> is supplied, the setting
will overrid
...

👍 fanquake approved a pull request: "ci: Rename tasks (previous releases, macOS cross)"
(https://github.com/bitcoin/bitcoin/pull/29218#pullrequestreview-1816017963)
ACK fa0c594b33970e12d97e6879ab4ca57045453492

💬 fanquake commented on pull request "depends: remove dependency on Darwin libtool":
(https://github.com/bitcoin/bitcoin/pull/29232#issuecomment-1887550112)
Actually, you'll also need to move `cmake-minimal` from the darwin target into the package list for all targets, in our Guix manifest. Ideally as the first commit. Otherwise this wont Guix build.

💬 theStack commented on pull request "log mempool loading progress":
(https://github.com/bitcoin/bitcoin/pull/29227#issuecomment-1887556899)
Concept ACK

👍 fanquake approved a pull request: "doc: update Bitcoin Core license to 2024"
(https://github.com/bitcoin/bitcoin/pull/29222#pullrequestreview-1816034826)
ACK 1f8450f066724dfbb5c5bc4060843e2f3340ed88

🚀 fanquake merged a pull request: "doc: update Bitcoin Core license to 2024"
(https://github.com/bitcoin/bitcoin/pull/29222)

💬 maflcko commented on pull request "test: add assumeutxo wallet test":
(https://github.com/bitcoin/bitcoin/pull/28838#issuecomment-1887580464)
https://github.com/bitcoin/bitcoin/actions/runs/7491713362/job/20393561752?pr=29218#step:27:7881

```
test_framework.authproxy.JSONRPCException: remove_all: The process cannot access the file because it is being used by another process.: "D:\a\_temp\test_runner_?_??_20240111_163825\wallet_assumeutxo_47\node1\regtest\w" (-1)

💬 stickies-v commented on pull request "doc: update -loglevel help following merge of PR 28318":
(https://github.com/bitcoin/bitcoin/pull/29230#discussion_r1449155399)
Sorry I didn't check and just assumed it printed all levels 🤦 resolved indeed.