💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#issuecomment-1465942262)
All you need to do to add a test is adding a call to start a node with the `prune=1` arg. For example:


```diff
diff --git a/test/functional/rpc_blockchain.py b/test/functional/rpc_blockchain.py
index 7a0cedb1f5..8e086cf268 100755
--- a/test/functional/rpc_blockchain.py
+++ b/test/functional/rpc_blockchain.py
@@ -69,6 +69,7 @@ class BlockchainTest(BitcoinTestFramework):

def run_test(self):
self.wallet = MiniWallet(self.nodes[0])
+ self._test_prune_disk_space()
...

💬 willcl-ark commented on issue "RFC: Miniscript integration":
(https://github.com/bitcoin/bitcoin/issues/18040#issuecomment-1465966738)
@michaelfolkson do you think this can be closed now that we have #24149 (amongst other capabilities)?

💬 stickies-v commented on issue "rest: Further API and code cleanup with query parameters":
(https://github.com/bitcoin/bitcoin/issues/25752#issuecomment-1465971535)
Closing this (and draft PRs). I still think the suggested changes are an improvement, and that the state of our current interfaces is an impediment to (new) developers building on Bitcoin Core instead of using third-party services, but as evidenced by my lack of activity on this issue I don't feel anymore like this is currently a particularly worthwhile endeavour given current development resources and other active projects that require developer attention.

Moreover, I think I'm now leaning m
...

✅ stickies-v closed an issue: "rest: Further API and code cleanup with query parameters"
(https://github.com/bitcoin/bitcoin/issues/25752)

💬 stickies-v commented on pull request "rest: Move format string from path-like parameter to query parameter":
(https://github.com/bitcoin/bitcoin/pull/25753#issuecomment-1465972038)
Closing as per https://github.com/bitcoin/bitcoin/issues/25752#issuecomment-1465971535

✅ stickies-v closed a pull request: "rest: Move format string from path-like parameter to query parameter"
(https://github.com/bitcoin/bitcoin/pull/25753)

💬 stickies-v commented on pull request "rest: Extend HTTPRequest interface to support querying path (parameters)":
(https://github.com/bitcoin/bitcoin/pull/25754#issuecomment-1465972292)
Closing as per https://github.com/bitcoin/bitcoin/issues/25752#issuecomment-1465971535

✅ stickies-v closed a pull request: "rest: Extend HTTPRequest interface to support querying path (parameters)"
(https://github.com/bitcoin/bitcoin/pull/25754)

💬 stickies-v commented on pull request "rest: Use from_blockhash and txdetails query parameters":
(https://github.com/bitcoin/bitcoin/pull/25755#issuecomment-1465972431)
Closing as per https://github.com/bitcoin/bitcoin/issues/25752#issuecomment-1465971535

✅ stickies-v closed a pull request: "rest: Use from_blockhash and txdetails query parameters"
(https://github.com/bitcoin/bitcoin/pull/25755)

💬 stickies-v commented on pull request "rest: Remove support for a number of `-deprecatedrest` options":
(https://github.com/bitcoin/bitcoin/pull/25756#issuecomment-1465972551)
Closing as per https://github.com/bitcoin/bitcoin/issues/25752#issuecomment-1465971535

✅ stickies-v closed a pull request: "rest: Remove support for a number of `-deprecatedrest` options"
(https://github.com/bitcoin/bitcoin/pull/25756)

💬 glozow commented on pull request "Add feerate histogram to getmempoolinfo":
(https://github.com/bitcoin/bitcoin/pull/21422#discussion_r1133744544)
fyi you can get the same information for each transaction by calling `infoAll()`. I think it's not great practice for outside callers to reach into `mapTx`

💬 MarcoFalke commented on issue "RFC: Miniscript integration":
(https://github.com/bitcoin/bitcoin/issues/18040#issuecomment-1465993119)
Closing for now. If there are new discussions or feature request (or ones missed here), a new issue can be created or this one reopened.

✅ MarcoFalke closed an issue: "RFC: Miniscript integration"
(https://github.com/bitcoin/bitcoin/issues/18040)

✅ MarcoFalke closed a pull request: "[WIP] DRAFT NOMERGE Tidy up RPCTxSerializationFlags"
(https://github.com/bitcoin/bitcoin/pull/23599)

👍 MarcoFalke approved a pull request: "Avoid integer overflow in CheckDiskSpace"
(https://github.com/bitcoin/bitcoin/pull/27235)
lgtm

💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#discussion_r1133824606)
```suggestion
self.log.info("Test that a manually pruned node does not run into integer overflow on first start")
```

nit: Not sure if more context is helpful. Otherwise, I suspect this test will be removed in the future due to being redundant.

💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#discussion_r1133825558)
Can also add my test to check that no false warning will be issued anymore? Integer overflow isn't the only issue you are fixing here.

💬 desirepl commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1466048126)
I see only translation changes 2 hours ago.
I'm not so familiar with git, so checked code updates here at main and other branches. Only your updates to translations 2 hours ago. Seems doing something wrong or don't understand, короче.