📝 maflcko opened a pull request: "build: Bump clang minimum supported version to 15"
(https://github.com/bitcoin/bitcoin/pull/29165)

💬 ismaelsadeeq commented on pull request "test: doc: follow-up #28368":
(https://github.com/bitcoin/bitcoin/pull/29013#discussion_r1439347276)
All the doc changes here or only `TransactionInfo` doctring?

💬 maflcko commented on pull request "miniscript: make operator""_mst consteval":
(https://github.com/bitcoin/bitcoin/pull/28657#issuecomment-1873890422)
Locally, it works, starting with `clang++-15`.

💬 hebasto commented on issue "`./configure` fails for clang-14 on Ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873892281)
> I don't understand why this isn't caught by CI. Maybe libc++ somehow works around the bug in the corresponding clang?

We do not have a combination of clang-14 with libstdc++-13-dev in the CI.

💬 hebasto commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-1873895559)
Related:
- https://github.com/bitcoin/bitcoin/pull/28657#issuecomment-1873890422
- https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873883731

💬 glozow commented on pull request "test: doc: follow-up #28368":
(https://github.com/bitcoin/bitcoin/pull/29013#discussion_r1439354796)
Just the added docstrings. I think it's self-explanatory that they store information about a tx.

💬 fanquake commented on issue "`./configure` fails for clang-14 on Ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873896783)
> Maybe libc++ somehow works around the bug in the corresponding clang?

The issue is only when Clang is being used with `libstdc++`. i.e:
```cpp
#include <chrono>

int main() { return 0;}
```

```bash
clang-13 test.cpp -O2 -std=c++20
...
#include <...> search starts here:
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/x86_64-linux-gnu/c++/13
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../inclu
...

💬 maflcko commented on issue "`./configure` fails for clang-14 on Ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873906575)
> I don't understand why this isn't caught by CI. Maybe libc++ somehow works around the bug in the corresponding clang?

Oh, I guess libc++ doesn't use `consteval`, but `constexpr`:

https://github.com/llvm/llvm-project/blob/9b7cf5bfb08b6e506216ef354dfd61adb15acbff/libcxx/include/__chrono/hh_mm_ss.h#L42

💬 maflcko commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-1873912312)
The macOS CI fails (as expected). Moving to draft for now, until someone clarifies the macOS clang situation. (I don't use macOS)

📝 maflcko converted_to_draft a pull request: "build: Bump clang minimum supported version to 15"
(https://github.com/bitcoin/bitcoin/pull/29165)
Most supported operating systems ship with clang-15 (or later), so bump the minimum to that and remove now unused workarounds for previous clang bugs.

For reference:
* https://packages.debian.org/bookworm/clang-15
* https://packages.ubuntu.com/jammy/clang-15
* CentOS-like 8/9 Stream: All Clang versions from 13 to 15
* FreeBSD 12/13: All Clang version from 13 to 16
* OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (`clang16`); No idea about OpenSuse Leap

On o
...

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1873915600)
I guess it was:

```
$ base64 ~/Downloads/clusterfuzz-testcase-scriptpubkeyman-5467976815738880
dHIoJWQxLzEvMC8wMC8wMC8wLzAwLzAvMC8wLzAwLzE5LzEwOTAvMC8wLzAvMC8wLzAwLzE5LzEw
OTAvMC8wLzAwLzAvMC8wLzAwLzEvMC8wMC8wLzAvMDAvMDkvMTkvMC8wLzAvMC8wMC8wLzAvMC8w
MC8xOS8wLzAwMC8wMC8wLzAvMC8wMC8xLzAvMDAvMC8wLzAwLzA5LzE5LzAvMC8wLzAvMDAvMC8w
LzAvMDAvMTkvMC8wMC8wLzAvMC8wMC8xOS8xLzAwLyonKQ==

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1873916162)
Responding to [https://petertodd.org/2023/v3-transactions-review](https://petertodd.org/2023/v3-transactions-review)

In general, I agree that RBF is a great fee-bumping mechanism. The entire point of v3 and EA is to make RBF more useful and less prone to pinning, and to enable us to use it in conjunction with CPFP while eliminating some of the inefficiency.

We seem to have entirely different perspectives about what RBF's limitations are today. Pointing out limitations in RBF is not intende
...

💬 maflcko commented on pull request "fuzz: avoid underflow in `coins_view` target":
(https://github.com/bitcoin/bitcoin/pull/29164#issuecomment-1873918402)
```
fuzz: coins.cpp:338: void CCoinsViewCache::SanityCheck() const: Assertion `recomputed_usage == cachedCoinsUsage' failed.

💬 ismaelsadeeq commented on pull request "test: doc: follow-up #28368":
(https://github.com/bitcoin/bitcoin/pull/29013#discussion_r1439371178)
Thanks fixed now

💬 darosior commented on pull request "fuzz: avoid underflow in `coins_view` target":
(https://github.com/bitcoin/bitcoin/pull/29164#issuecomment-1873927193)
My bad, i ran the new `coins_db` introduced in #28216 for a while but not this one.. Will debug to find the other source of inconsistency.

💬 fanquake commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-1873927915)
> The macOS CI fails (as expected). Moving to draft for now, until someone clarifies the macOS clang situation. (I don't use macOS)

Xcode 14.3.1 (currently used in the CI) is based on ~ LLVM 14. It's failing because removing the fuzz workaround requires LLVM/Clang 15 or later. The GH image ships with newer Xcodes, https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode, so I assume we could switch to using Xcode 15.x + in the CI (based on LLVM 16.x).

The mu
...

💬 fanquake commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-1873930799)
The libbitcoinkernel `clang-15 libc++` job is also failing, so I guess this isn't actually fixed with clang-15, regardless of macOS?

💬 maflcko commented on pull request "fuzz: avoid underflow in `coins_view` target":
(https://github.com/bitcoin/bitcoin/pull/29164#issuecomment-1873934953)
> The crash can be reproduced with the following seed:

On what commit? For me it seems to pass on current master.

💬 darosior commented on pull request "fuzz: avoid underflow in `coins_view` target":
(https://github.com/bitcoin/bitcoin/pull/29164#issuecomment-1873935640)
You need to add the sanity check to trigger it.

💬 hebasto commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#discussion_r1439389706)
```suggestion
sudo xcode-select --switch "/Applications/Xcode15.1.app"
```