💬 Willtech commented on issue "Signmessage doesn't work with segwit addresses":
(https://github.com/bitcoin/bitcoin/issues/10542#issuecomment-1873646556)
Key is not address is fine the address is a cryptographic construct the feature is to be able to use the address to sign and verify messages.

💬 eragmus commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1873670326)
> OCEAN has _not_ paid any miners anything that wasn't derived from the rewards from blocks found by the pool. The "bonus" shown is not something paid from other funds (investors or otherwise), it's just that the reward system's sharelog is not yet full, so shares are weighted more heavily since there are fewer in the log, and we're showing that delta as "a bonus".

Thanks for clarifying the source of the bonus. If Ocean reps don't provide the actual information, then obviously people will spec
...

💬 stratospher commented on pull request "test: create deterministic addrman in the functional tests":
(https://github.com/bitcoin/bitcoin/pull/29007#discussion_r1439231283)
nice! done.

🤔 shaavan reviewed a pull request: "init: handle empty settings file gracefully"
(https://github.com/bitcoin/bitcoin/pull/29144#pullrequestreview-1800095106)
> Thus I proposed a different solution for non-interactive users who are manually modifying the file. See https://github.com/bitcoin/bitcoin/pull/29144#pullrequestreview-1798109497.
Stating that the file is JSON-formatted and auto-generated gives bitcoind users another hint over what they can and can't do.

I see your point, @furszy

But I think my points still apply to creating an "auto-generated" file.

1. A regular user might not tinker with their settings file regularly and hence the
...

💬 darosior commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1873789701)
> The largest lightning channels out there are about 5BTC. Even if you were willing to bump fees, all the way to spending the entire 5BTC towards fees, you'd need just 68 different fee variants to go all the way from 1sat/vbyte to spending the full 5BTC on fees, with a 25% increase for each each fee variant.

So you'd potentially hand to your supposedly untrusted channel partner a signature for a transaction burning your whole 4.95BTC balance to fees? This trivially opens a blackmail vector: "
...

💬 t-bast commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1873793179)
> Now, as for the choosing a feerate in advance problem, I explained fully in my article, showing how it's quite easy to pre-sign every conceivable feerate because there just aren't that many of them. In fact, you could easily pre-sign feerates all the way to making the channel uneconomical to close, because you've spent every cent towards fees. This is not a problem.

That proposal ignores important drawbacks on the lightning side. I'm actually quite surprised that you don't even mention thos
...

💬 maflcko commented on issue "`./configure` fails for clang-14 on Ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873858150)
That is a bug in clang-14, fixed in 15. Reproducer:

```cpp
template <class A>
struct ch {
static consteval unsigned w() { return {}; };
static constexpr unsigned bar{w()};
};

int main() {}

📝 darosior opened a pull request: "fuzz: avoid underflow in `coins_view` target"
(https://github.com/bitcoin/bitcoin/pull/29164)
Catching the exception in `AddCoin` and continuing will lead to the calculated memory usage of the cache to be out of sync (lower by the size of the existing coin). If we later remove more coins, this can lead to an underflow and the sanitizer will trip on a later overflow when we add back to `cachedCoinsUsage`. See https://github.com/bitcoin/bitcoin/pull/28216#issuecomment-1872991949.

I found this while rebasing #28216 but another way of exposing this mistake is to simply run the cache sanit
...

💬 darosior commented on pull request "fuzz: a new target for the coins database":
(https://github.com/bitcoin/bitcoin/pull/28216#issuecomment-1873876560)
Rebased on top of #29164 to fix the above.

💬 maflcko commented on issue "`./configure` fails for clang-14 on Ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873883731)
I don't understand why this isn't caught by CI. Maybe libc++ somehow works around the bug in the corresponding clang?

Not sure how to fix it. The easiest would obviously be to bump the minimum required to clang-15. However, I am not sure if that works for macOS users.

📝 maflcko opened a pull request: "build: Bump clang minimum supported version to 15"
(https://github.com/bitcoin/bitcoin/pull/29165)

💬 ismaelsadeeq commented on pull request "test: doc: follow-up #28368":
(https://github.com/bitcoin/bitcoin/pull/29013#discussion_r1439347276)
All the doc changes here or only `TransactionInfo` doctring?

💬 maflcko commented on pull request "miniscript: make operator""_mst consteval":
(https://github.com/bitcoin/bitcoin/pull/28657#issuecomment-1873890422)
Locally, it works, starting with `clang++-15`.

💬 hebasto commented on issue "`./configure` fails for clang-14 on Ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873892281)
> I don't understand why this isn't caught by CI. Maybe libc++ somehow works around the bug in the corresponding clang?

We do not have a combination of clang-14 with libstdc++-13-dev in the CI.

💬 hebasto commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-1873895559)
Related:
- https://github.com/bitcoin/bitcoin/pull/28657#issuecomment-1873890422
- https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873883731

💬 glozow commented on pull request "test: doc: follow-up #28368":
(https://github.com/bitcoin/bitcoin/pull/29013#discussion_r1439354796)
Just the added docstrings. I think it's self-explanatory that they store information about a tx.

💬 fanquake commented on issue "`./configure` fails for clang-14 on Ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873896783)
> Maybe libc++ somehow works around the bug in the corresponding clang?

The issue is only when Clang is being used with `libstdc++`. i.e:
```cpp
#include <chrono>

int main() { return 0;}
```

```bash
clang-13 test.cpp -O2 -std=c++20
...
#include <...> search starts here:
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/x86_64-linux-gnu/c++/13
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../inclu
...

💬 maflcko commented on issue "`./configure` fails for clang-14 on Ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29161#issuecomment-1873906575)
> I don't understand why this isn't caught by CI. Maybe libc++ somehow works around the bug in the corresponding clang?

Oh, I guess libc++ doesn't use `consteval`, but `constexpr`:

https://github.com/llvm/llvm-project/blob/9b7cf5bfb08b6e506216ef354dfd61adb15acbff/libcxx/include/__chrono/hh_mm_ss.h#L42

💬 maflcko commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-1873912312)
The macOS CI fails (as expected). Moving to draft for now, until someone clarifies the macOS clang situation. (I don't use macOS)

📝 maflcko converted_to_draft a pull request: "build: Bump clang minimum supported version to 15"
(https://github.com/bitcoin/bitcoin/pull/29165)
Most supported operating systems ship with clang-15 (or later), so bump the minimum to that and remove now unused workarounds for previous clang bugs.

For reference:
* https://packages.debian.org/bookworm/clang-15
* https://packages.ubuntu.com/jammy/clang-15
* CentOS-like 8/9 Stream: All Clang versions from 13 to 15
* FreeBSD 12/13: All Clang version from 13 to 16
* OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (`clang16`); No idea about OpenSuse Leap

On o
...